anemet added a comment. In https://reviews.llvm.org/D31168#716153, @rjmccall wrote:
> I may have missed earlier steps in this patch series. Why is this being done > statefully and contextually in the IRBuilder instead of just applying the > flag from the BinaryOperator to the instruction when building it? It's not > like ScalarExprEmitter doesn't know that it's building an FMul. The main reason is that the other FMFlags are currently maintained in the IRBuilder (see CodeGenFunction.cpp:87). That said as we move those over to the operators as well, it makes more sense to move away from using the IRBuilder for this. See updated patch and thanks for the suggestion! Also let me know if you have post-commit comments on the patches in the series. You can find them either on the cfe-dev thread or in the dependencies of https://reviews.llvm.org/D31276 https://reviews.llvm.org/D31168 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
