ahatanak added a comment.

I think you can add a test case in this patch (after the llvm changes are 
checked in)?



================
Comment at: lib/CodeGen/CGExprScalar.cpp:262
+    ApplyFPFeatures(llvm::IRBuilderBase &Builder, Expr *E)
+        : CGBuilderTy::FastMathFlagGuard(Builder) {
+      if (const auto *BO = dyn_cast<BinaryOperator>(E)) {
----------------
Is it necessary to check CXXOperatorCallExpr too here? 

Since CXXOperatorCallExpr has an FPFeatures field too, I was wondering how 
CodeGen was going to use that information.


https://reviews.llvm.org/D31168



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to