This revision was automatically updated to reflect the committed changes.
Closed by commit rL296576: [libc++abi] Clean up visibility (authored by
smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26949?vs=90119&id=90120#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26949
Fil
smeenai updated this revision to Diff 90119.
smeenai added a comment.
Addressing inline comment
https://reviews.llvm.org/D26949
Files:
include/__cxxabi_config.h
src/abort_message.cpp
src/abort_message.h
src/cxa_exception.cpp
src/cxa_exception.hpp
src/cxa_handlers.cpp
src/cxa_handl
smeenai added inline comments.
Comment at: src/abort_message.h:19
-__attribute__((visibility("hidden"), noreturn))
- void abort_message(const char* format, ...)
-__attribute__((format(printf, 1, 2)));
-
+_LIBCXXABI_HIDDEN __attribute__((noreturn)) void
+abort
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus inline comments.
@smeenai confirmed that this patch doesn't change the ABI list for
`libc++abi.dylib` using `sym_check.py`.
Comment at: src/abort_message.h:19
smeenai updated this revision to Diff 90114.
smeenai added a comment.
Rebase
https://reviews.llvm.org/D26949
Files:
include/__cxxabi_config.h
src/abort_message.cpp
src/abort_message.h
src/cxa_exception.cpp
src/cxa_exception.hpp
src/cxa_handlers.cpp
src/cxa_handlers.hpp
src/cxa_n
smeenai added inline comments.
Comment at: src/abort_message.cpp:25
-#pragma GCC visibility push(hidden)
-
EricWF wrote:
> Is this really redundant? There is an `#include `
> after it. Is this not going to affect those symbols?
That's a fair point. I think it'
smeenai updated this revision to Diff 87362.
smeenai edited the summary of this revision.
smeenai added a comment.
Addressing comments
https://reviews.llvm.org/D26949
Files:
include/__cxxabi_config.h
src/abort_message.cpp
src/abort_message.h
src/cxa_exception.cpp
src/cxa_exception.hpp
compnerd added inline comments.
Comment at: src/cxa_new_delete.cpp:34
*/
-__attribute__((__weak__, __visibility__("default")))
+__attribute__((__weak__))
void *
EricWF wrote:
> Can we abstract this away to a `_LIBCXXABI_NEW_DELETE_VIS` macro?
Are `operator new`
EricWF added inline comments.
Comment at: src/abort_message.cpp:25
-#pragma GCC visibility push(hidden)
-
Is this really redundant? There is an `#include ` after
it. Is this not going to affect those symbols?
Comment at: src/cxa_handlers.hpp
smeenai added a comment.
Ping.
https://reviews.llvm.org/D26949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
https://reviews.llvm.org/D26949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
https://reviews.llvm.org/D26949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai updated this revision to Diff 80361.
smeenai added a comment.
Addressing @compnerd's comments
https://reviews.llvm.org/D26949
Files:
src/abort_message.cpp
src/abort_message.h
src/cxa_exception.cpp
src/cxa_exception.hpp
src/cxa_handlers.cpp
src/cxa_handlers.hpp
src/cxa_new_
compnerd added a comment.
I really like the clean up this does. It removes the unnecessary usage of the
GCC pragmas and cleans up the definitions by using the headers more properly.
Comment at: src/abort_message.h:19
-__attribute__((visibility("hidden"), noreturn))
+_LIBCXX
smeenai added a comment.
Ping.
Lmk if there's any other tests I should run on this to ensure there's no
functional difference.
https://reviews.llvm.org/D26949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, howard.hinnant, mclow.lists.
smeenai added a subscriber: cfe-commits.
Use the libc++abi visibility macros instead of pragmas or using
visibility attributes directly. Clean up redundant attributes on
definitions (where the de
16 matches
Mail list logo
