smeenai added inline comments.
================ Comment at: src/abort_message.cpp:25 -#pragma GCC visibility push(hidden) - ---------------- EricWF wrote: > Is this really redundant? There is an `#include <CrashReporterClient.h>` > after it. Is this not going to affect those symbols? That's a fair point. I think it's kinda unusual to wrap a header file this way (we don't do it for any other system headers, for example), and the header file in question appears to be Apple-internal, so I don't know if it's necessary. I can leave it in place for just the header file inclusion if you prefer, however. https://reviews.llvm.org/D26949 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
