bcraig closed this revision.
bcraig added a comment.
r266730
Comment at: test/libcxx/test/config.py:454
@@ -464,1 +453,3 @@
+else:
+self.cxx.link_flags += ['-lc++']
EricWF wrote:
> In this fallback case do we want to explicitly ask
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. It's up to you if you want to address the inline comments before
committing.
Thanks for updating the Doc. I really need to kill one version of it.
Comment at: test/lib
bcraig marked 2 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated the summary for this revision.
bcraig updated this revision to Diff 54112.
bcraig added a comment.
EricWF's feedback. Removed libcxx_library option. I plan on submitting this
tomorrow morning.
http://reviews.llvm.org/D16544
Files:
docs/TestingLibcxx.rst
test/CMakeLists.txt
EricWF added a comment.
In http://reviews.llvm.org/D16544#404283, @bcraig wrote:
> In http://reviews.llvm.org/D16544#403273, @EricWF wrote:
>
> > Just spitballing but have you considered simply passing the full path,
> > including the library name, to LIT? Instead of needing `enable_shared`
> >
bcraig added a comment.
In http://reviews.llvm.org/D16544#403273, @EricWF wrote:
> Just spitballing but have you considered simply passing the full path,
> including the library name, to LIT? Instead of needing `enable_shared`
> variables we would simply use the named library, be it DSO or arch
EricWF added a comment.
If we choose not to use full library paths could you please remove the
'libcxx_library' option? It just does what your trying here but worse, no need
to keep it around.
http://reviews.llvm.org/D16544
___
cfe-commits mailin
EricWF added a comment.
Just spitballing but have you considered simply passing the full path,
including the library name, to LIT? Instead of needing `enable_shared`
variables we would simply use the named library, be it DSO or archive.
Comment at: test/libcxx/test/config.py:4
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig marked 6 inline comments as done.
bcraig added a comment.
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated this revision to Diff 48113.
bcraig added a comment.
Addressed EricWF's feedback (hopefully).
http://reviews.llvm.org/D16544
Files:
test/CMakeLists.txt
test/libcxx/test/config.py
test/libcxx/test/target_info.py
test/lit.site.cfg.in
Index: test/lit.site.cfg.in
===
bcraig added inline comments.
Comment at: test/libcxx/test/config.py:469
@@ +468,3 @@
+if cxx_library_root:
+abs_path = cxx_library_root + "/libc++.a"
+self.cxx.link_flags += [abs_path]
EricWF wrote:
> Why no
EricWF added a comment.
Did you consider simply wrapping the library in "-Wl,-Bstatic" and
"-Wl,-Bdynamic" linker flags? It seems like that would work almost as well as
explicitly naming the target.
Comment at: test/libcxx/test/config.py:463
@@ -462,2 +462,3 @@
else:
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
ping
http://reviews.llvm.org/D16544
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig created this revision.
bcraig added reviewers: mclow.lists, EricWF, jroelofs.
bcraig added a subscriber: cfe-commits.
NOTE: related libc++abi changes are in a different patch that will be posted
shortly.
Tested with static libcxx and libcxxabi against custom embedded target.
Tested with st
18 matches
Mail list logo
