EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. It's up to you if you want to address the inline comments before
committing.
Thanks for updating the Doc. I really need to kill one version of it.
================
Comment at: test/libcxx/test/config.py:454
@@ -464,1 +453,3 @@
+ else:
+ self.cxx.link_flags += ['-lc++']
----------------
In this fallback case do we want to explicitly ask for static linkage using
`-Wl,-Bstatic -lc++ -Wl,-Bdynamic`? I think that will cause the linker to
diagnose that your not actually getting a static library.
================
Comment at: test/libcxx/test/config.py:473
@@ -474,1 +472,3 @@
+ else:
+ self.cxx.link_flags += ['-lc++abi']
elif cxx_abi == 'libcxxrt':
----------------
In this fallback case do we want to explicitly ask for static linkage using
`-Wl,-Bstatic -lc++abi -Wl,-Bdynamic`?
http://reviews.llvm.org/D16544
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
