[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added a comment. Reland 82dff24bde112984314568e7d581379fd0ea48e6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 __

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 534417. HaohaiWen added a comment. Add -- to clang_cl input file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 534413. HaohaiWen edited the summary of this revision. HaohaiWen added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clan

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen reopened this revision. HaohaiWen added a comment. This revision is now accepted and ready to land. The path of this test you were running (/Users/thakis/src/llvm-project/clang/test/Driver/split-debug.c) started with /User which was interpreted as OPT_U option. Therefore split-debug.c

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

thakis added a comment. Reverted in b851308b870a67ccb606d0d33f159a70fd3522c7 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing li

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

thakis added a comment. Looks like this breaks tests on Mac: http://45.33.8.238/macm1/63504/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen closed this revision. HaohaiWen added a comment. Thanks. This patch has been landed. https://github.com/llvm/llvm-project/commit/3eee5aa528abd67bb6d057e25ce1980d0d38c445 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://r

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added a comment. @MaskRay, any other comments? I'd like to land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing li

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533967. HaohaiWen added a comment. Restore DWARFContext.cpp since D153602 has fixed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. Tests seem mostly fine, but since this is the primary patch for a major feature, consider adding more descriptions how this works? For example, you can add something like the following to the summary/commit message, which should make a curious reader know how to play wi

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().empty()) + continue; HaohaiWen wrote: > skan wrot

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533623. HaohaiWen added a comment. Remove CoreOption for dumpdir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

mstorsjo added a comment. In D152785#4438544 , @MaskRay wrote: > CodeView is the default debug info format for COFF. Perhaps `-gsplit-dwarf` > should be rejected when the default `-gcodeview` is used, with a test. IIRC some users do generate both CodeVi

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. CodeView is the default debug info format for COFF. Perhaps `-gsplit-dwarf` should be rejected when the default `-gcodeview` is used, with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.l

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay requested changes to this revision. MaskRay added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdi

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added inline comments. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdir : Separate<["-"], "dumpdir">, Flags<[CC1Option]>, +def dumpdir : Separate<["-"], "dumpd

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533182. HaohaiWen marked 10 inline comments as done. HaohaiWen added a comment. Address maskray's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files:

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:1167 // GCC style -dumpdir. We intentionally don't implement the less useful -dumpbase{,-ext}. -def dumpdir : Separate<["-"], "dumpdir">, Flags<[CC1Option]>, +def dumpdir : Separate<["-"], "dumpdir

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: clang/test/Driver/split-debug.c:55 // RUN: %clang -### -c -target x86_64 -gsplit-dwarf=single -g -o %tfoo.o %s 2>&1 | FileCheck %s --check-prefix=SINGLE_WITH_FILENAME +// RUN: %clang_cl -### -c --target x86_64-unknown-windows-msvc -gs

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3898 if (!Args.hasArg(options::OPT_dumpdir)) { + Arg *FinalOutput = Args.getLastArg(options::OPT_o, options::OPT__SLASH_o); Arg *Arg = Args.MakeSeparateArg( Add a test to sho

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added a comment. Looking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen marked an inline comment as done. HaohaiWen added a comment. Any other comments? If not , I'll land this patch tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 _

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

skan accepted this revision. skan added a comment. This revision is now accepted and ready to land. LGTM for the MC part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 __

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen marked 7 inline comments as done. HaohaiWen added inline comments. Comment at: llvm/lib/MC/WinCOFFObjectWriter.cpp:124 +bool isDwoSection(const MCSection &Sec) { + return Sec.getName().endswith(".dwo"); MaskRay wrote: > static It's already in anonymo

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 532507. HaohaiWen added a comment. Use --target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Dr

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

MaskRay added inline comments. Comment at: clang/test/Driver/split-debug.c:19 // RUN: %clang -### -c -target amdgcn-amd-amdhsa -gsplit-dwarf -g %s 2>&1 | FileCheck %s --check-prefix=SPLIT +// RUN: %clang_cl -### -c -target x86_64-unknown-windows-msvc -gsplit-dwarf -g %s 2>&1 |

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().empty()) + continue; skan wrote: > Should we me

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 532060. HaohaiWen marked an inline comment as done. HaohaiWen added a comment. Address skan's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clan

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

skan added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896 +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().empty()) + continue; Should we merge the check into

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

skan added inline comments. Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1895 + if (RelocatedSection != Obj.section_end() && Name.contains(".dwo")) { +// Each section in COFF can directly contain relocations. +if (isa(&Obj) && Section.relocations().e

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 531219. HaohaiWen added a comment. Fix sections binding check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td clang

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 530825. HaohaiWen added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. HaohaiWen requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1, MaskRay, aheejin. Herald added a reviewer: jdoerfert. Herald added projects: clang