HaohaiWen added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1896
+ // Each section in COFF can directly contain relocations.
+ if (isa<COFFObjectFile>(&Obj) && Section.relocations().empty())
+ continue;
----------------
skan wrote:
> Should we merge the check into line 1894?
It's more elegant to not merge.
================
Comment at: llvm/test/DebugInfo/COFF/dwarf-headers.ll:75
+!14 = !{i32 1, !"MaxTLSAlign", i32 65536}
+!15 = !{!"clang version 17.0.0 (https://github.com/llvm/llvm-project.git
f1106ef6c9d14d5b516ec352279aeee8f9d12818)"}
----------------
skan wrote:
> Simplify it to "clang"?
I have attached source code in comments. It's better to save llvm version here
to help to reproduce it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152785/new/
https://reviews.llvm.org/D152785
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
