MaskRay added a comment. Tests seem mostly fine, but since this is the primary patch for a major feature, consider adding more descriptions how this works?
For example, you can add something like the following to the summary/commit message, which should make a curious reader know how to play with this new feature. % cat a.c int main() {} % clang --target=x86_64-windows-gnu -g -gsplit-dwarf -c a.c % llvm-objdump -h a.dwo ... CodeView is the primary debug info format. I expect some description about it as well, even if we decide to let `-gsplit-dwarf` be silently ignored in CodeView and no-DWARF mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits