[PATCH] D144878: __builtin_FILE_NAME()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2147e940e8a8: Add __builtin_FILE_NAME() (authored by karapsinie, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D144878?vs=505468&id=506078#toc Repository: rG LLVM Git

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:805-807 +/// [C++11] simple-type-specifier braced-init-list [C++11 5.2.3] /// [C++] typename-specifier '(' expression-list[opt] ')' [C++ 5.2.3] +/// [C++11] typename-specifier braced-init-li

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. In D144878#4199297 , @aaron.ballman wrote: > LGTM aside from a small formatting issue. Do you need someone to land this on > your behalf? If so, what name and email address would y

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small formatting issue. Do you need someone to land this on your behalf? If so, what name and email address would you like used for patch attribution? ==

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 505468. karapsinie marked 4 inline comments as done. karapsinie added a comment. Added "__" for "builtin..." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/docs/LanguageExtensions.rst

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 505462. karapsinie added a comment. Execute "git-clang-format HEAD~1" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 505410. karapsinie added a comment. Fulfilled the wishes of aaron.ballman CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:113-114 nondeterministic value of the same type as the provided argument. +- Clang now supports ``__builtin_FILE_NAME`` that returns a + ``__FILE_NAME__`` value at the "invocation point". -

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 504648. karapsinie added a comment. Updated a release note and documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst c

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 504625. karapsinie marked 3 inline comments as done. karapsinie added a comment. Fulfilled the wishes of cor3ntin №2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 504577. karapsinie marked an inline comment as done. karapsinie added a comment. Fulfilled the wishes of cor3ntin CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h

[PATCH] D144878: __builtin_FILE_NAME()

cor3ntin added a comment. > In terms of the encoding question I was asking, that's information we'll have > to figure out (CC @tahonermann and @cor3ntin for text encoding question). My > guess (which needs verification) is that we convert the file name from the > system encoding to UTF-8 intern

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added subscribers: cor3ntin, tahonermann. aaron.ballman added a comment. In D144878#4183893 , @karapsinie wrote: > In D144878#4172639 , @aaron.ballman > wrote: > >> In D144878#4171234

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. In D144878#4172639 , @aaron.ballman wrote: > In D144878#4171234 , @karapsinie > wrote: > >> PTAL. > > Have you seen the comments on the GC

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 503696. karapsinie added a comment. Removed the spurious whitespace changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/TokenKind

[PATCH] D144878: __builtin_FILE_NAME()

aaron.ballman added a comment. In D144878#4171234 , @karapsinie wrote: > PTAL. Have you seen the comments on the GCC issue that @MaskRay filed? Is that something we should do as well? (It doesn't have to be part of this patch, but it'd be good to ensu

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie added a comment. PTAL. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie marked an inline comment as done. karapsinie added a comment. If all is well, approve and merge the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 ___ cfe-commits mailing list cfe

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 501486. karapsinie added a comment. Execute "git-clang-format HEAD~1" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/TokenKinds.def

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 501484. karapsinie added a comment. Duplicate code moved to "Preprocessor::processPathToFilename" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 501451. karapsinie added a comment. Execute "git-clang-format HEAD~1" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://reviews.llvm.org/D144878 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/TokenKinds.def

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie added a comment. I tried rebase revision, but edit other revision (https://reviews.llvm.org/D145040). We need to rebase the revision, because the tests are falling, because there is no this commit: https://reviews.llvm.org/rG24d144571dbffc6993d13fb7ca781248eed024de How do it? Repos

[PATCH] D144878: __builtin_FILE_NAME()

MaskRay added a comment. It'd be nice to have compiler feature parity. I created a GCC feature request for `__builtin_FILE_NAME`: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108978 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https:/

[PATCH] D144878: __builtin_FILE_NAME()

shafik added inline comments. Comment at: clang/lib/AST/Expr.cpp:2283 + case SourceLocExpr::FileName: { +SmallString<256> Path; +// builtin_FILE_NAME() is a Clang-specific extension that expands to the It looks like a copy of the code from `ExpandBuiltin

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie updated this revision to Diff 500809. karapsinie added a comment. Execute "arc diff `git merge-base HEAD origin` --update D144878 " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144878/new/ https://revi

[PATCH] D144878: __builtin_FILE_NAME()

karapsinie created this revision. karapsinie added reviewers: klimek, aaron.ballman. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simonc