aaron.ballman added a comment.
In D144878#4171234 <https://reviews.llvm.org/D144878#4171234>, @karapsinie
wrote:
> PTAL.
Have you seen the comments on the GCC issue that @MaskRay filed? Is that
something we should do as well? (It doesn't have to be part of this patch, but
it'd be good to ensure we're collaborating with GCC so we get the same builtin
functionality in this space.)
There should be a release note and documentation for the new functionality. One
thing to consider for the docs is explaining what's going on with text
encodings (and perhaps that text applies to this entire class of file-related
builtins). e.g., if the system code page is Shift-JIS does this builtin return
the text in Shift-JIS or UTF-8 or something else?
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:1553
int a = d;
- union {
+ union {
int b;
----------------
You should back out the spurious whitespace changes (I'd recommend setting your
editor to not discard trailing whitespace on save as that's a common culprit
for this).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144878/new/
https://reviews.llvm.org/D144878
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
