[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#4001704 , @davide wrote: > In D139717#4001702 , @MaskRay wrote: > >> In D139717#4001688 , @davide wrote: >> >>> In D139717#4001685

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#4001702 , @MaskRay wrote: > In D139717#4001688 , @davide wrote: > >> In D139717#4001685 , @MaskRay >> wrote: >> >>> In D139717#3998077

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#4001688 , @davide wrote: > In D139717#4001685 , @MaskRay wrote: > >> In D139717#3998077 , @manojgupta >> wrote: >> >>> Xlinker still w

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#4001685 , @MaskRay wrote: > In D139717#3998077 , @manojgupta > wrote: > >> Xlinker still works. Xcompiler is failing. >> >> A google search will show that Xcompiler is a wide-sp

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3999098 , @rsundahl wrote: > Added the test warn-not-error-Xfoo `-Xfoo` leads to a warning (expected) which is weird. Can you change it to a form which actually reflects how `-X` is used? (aka `-Xparser`) I am not su

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3998077 , @manojgupta wrote: > Xlinker still works. Xcompiler is failing. > > A google search will show that Xcompiler is a wide-spread option used by many > packages. Whether or not GCC supports it is not relevant. P

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f8bd8ac0658: Revert "[Driver] Remove Joined -X" (authored by rsundahl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 ___

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl added a comment. I added a test so we can catch any regression. If we choose to deprecate then we can modify the test to watch for the "is deprecated" message that should be asserted for "some time" appropriate. Thank you all for your input. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl updated this revision to Diff 483297. rsundahl added a comment. Added the test warn-not-error-Xfoo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 Files: clang/include/clang/Driver/Options.td

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#3997193 , @MaskRay wrote: > In D139717#3991765 , @rsundahl > wrote: > >> In D139717#3987963 , @MaskRay >> wrote: >> This change i

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. Xlinker still works. Xcompiler is failing. A google search will show that Xcompiler is a wide-spread option used by many packages. Whether or not GCC supports it is not relevant. Please do not remove options just because you do not use them. Repository: rG LLVM G

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3991765 , @rsundahl wrote: > In D139717#3987963 , @MaskRay wrote: > >>> This change is breaking internal builds. We use the -Xfoo pattern but can >>> now no longer manage wheth

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3988902 , @manojgupta wrote: > We use -Xcompiler and -Xlinker which are passed in programs and they raise > error now. Sorry, I do not understand. `clang -Xlinker --verbose a.c` works well. `-Xcompiler` is invalid i

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#3987963 , @MaskRay wrote: >> This change is breaking internal builds. We use the -Xfoo pattern but can >> now no longer manage whether we allow an unused -Xfoo option to pass as a >> warning or promote it to an error.

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl added a comment. In D139717#3987963 , @MaskRay wrote: >> This change is breaking internal builds. We use the -Xfoo pattern but can >> now no longer manage whether we allow an unused -Xfoo option to pass as a >> warning or promote it to an err

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. We use -Xcompiler and -Xlinker which are passed in programs and they raise error now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 _

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. > This change is breaking internal builds. We use the -Xfoo pattern but can now > no longer manage whether we allow an unused -Xfoo option to pass as a warning > or promote it to an error. Which `-Xfoo` is used? Do your internal builds reserve `-Xfoo` as a placeholder

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

MaskRay added a comment. In D139717#3986227 , @manojgupta wrote: > The removal is also breaking ChromeOS builds which use -Xpattern in some > cases. Do you have a justifying example showing which `-Xpattern` is used? It needs to do useful work, instea

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

manojgupta added a comment. The removal is also breaking ChromeOS builds which use -Xpattern in some cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 ___

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#3984648 , @lebedev.ri wrote: > This is missing a test, like the original commit mentioned. > Why can you not just use the the split variant, `-X clang ...`? This breaks many projects internally. There's no real complex

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

lebedev.ri added a comment. This is missing a test, like the original commit mentioned. Why can you not just use the the split variant, `-X clang ...`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl created this revision. Herald added a project: All. rsundahl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is breaking internal builds. We use the -Xfoo pattern but can now no longer manage whether we allow an unused