davide added a comment. In D139717#3997193 <https://reviews.llvm.org/D139717#3997193>, @MaskRay wrote:
> In D139717#3991765 <https://reviews.llvm.org/D139717#3991765>, @rsundahl > wrote: > >> In D139717#3987963 <https://reviews.llvm.org/D139717#3987963>, @MaskRay >> wrote: >> >>>> This change is breaking internal builds. We use the -Xfoo pattern but can >>>> now no longer manage whether we allow an unused -Xfoo option to pass as a >>>> warning or promote it to an error. >>> >>> Which `-Xfoo` is used? Do your internal builds reserve `-Xfoo` as a >>> placeholder to do other non-upstream work? Then you can consider `-Gfoo` if >>> your builds don't need the mips semantics. >> >> We use -Xparser > > There are two possibilities. > > First, your downstream projects incorrectly pass a previously-ignored > `-Xparser`. Then it seems the right call is to remove it. It is not. You first deprecate and then you remove. This commit needs to be reverted. HTH, - D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
