rsundahl added a comment.
In D139717#3987963 <https://reviews.llvm.org/D139717#3987963>, @MaskRay wrote: >> This change is breaking internal builds. We use the -Xfoo pattern but can >> now no longer manage whether we allow an unused -Xfoo option to pass as a >> warning or promote it to an error. > > Which `-Xfoo` is used? Do your internal builds reserve `-Xfoo` as a > placeholder to do other non-upstream work? Then you can consider `-Gfoo` if > your builds don't need the mips semantics. We use -Xparser > Is it possible to clean up the previously-ignored-with-a-warning `-Xfoo`? Possibly. Maybe preferably. Builds are breaking now though. Dependent projects would have to be notified and changes scheduled. Was there a diff that we should have been part of? It looks like at least two of us are surprised with downstream consequences. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
