[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bcb85c638c1: Stop evaluating trailing requires clause after overload resolution (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 ___ cfe-commits mailing list c

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane updated this revision to Diff 468185. erichkeane marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.cpp clang/lib/Sema/SemaExpr.cpp

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6748 + SourceLocation ConstraintFailLoc = NakedFn->getBeginLoc(); + ChuanqiXu wrote: > It looks like `ConstraintFailLoc` is not used? Woops!

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

ChuanqiXu added a comment. LGTM basically. Comment at: clang/lib/Sema/SemaExpr.cpp:6748 + SourceLocation ConstraintFailLoc = NakedFn->getBeginLoc(); + It looks like `ConstraintFailLoc` is not used? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1357

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane updated this revision to Diff 467762. erichkeane marked an inline comment as done. erichkeane added a comment. Thanks for the review @shafik CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 Files: clang/include/clang/Sema/Sema.h

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

shafik added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6785 +// other than to declare it, is ill-formed. [...] +//if (CheckReferencedFunctionTrailingRequiresClause(FD, ConstraintFailLoc)) +// return ExprError(); This code is commente

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

erichkeane created this revision. erichkeane added a reviewer: clang-language-wg. Herald added a project: All. erichkeane requested review of this revision. Reported as it showed up as a constriants failure after the deferred instantiation patch, we were checking constraints TWICE after overload r