shafik added inline comments.
================ Comment at: clang/lib/Sema/SemaExpr.cpp:6785 + // other than to declare it, is ill-formed. [...] +// if (CheckReferencedFunctionTrailingRequiresClause(FD, ConstraintFailLoc)) +// return ExprError(); ---------------- This code is commented out, did you mean to remove it? Since this is the only code using `ConstraintFailLoc ` then that should go to if you delete this code. ================ Comment at: clang/test/SemaTemplate/concepts.cpp:712 +// These should not diagnose, where we were unintentionally doing so before by +// checking these two times, yet not having the ability to the 2nd time, since +// it was no longer a dependent variant. ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
