[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz added a comment. The llvm-config test issue should be resolved in rGa4b010034f57 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz added a comment. I think I have a fix for this and I'll get it up today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110 ___ cfe-commits mailing list cfe-

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

dstuttard added a comment. I think that the reason we don't see the same failure for e.g. OpenACC is that there's a unittest/Frontend that requires OpenACC - if I comment out that subdir in the unittests/CMakeLists.txt it fails llvm-config test in the same way for OpenACC. Similarly, if I add F

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

mariusz-sikora-at-amd added a comment. In D135110#3859844 , @mstorsjo wrote: > I don't quite know why, but it seems like this new library breaks tests of > llvm-config; if I start out with an empty build directory and run `ninja > check-llvm` (or `ninja

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

mstorsjo added a comment. I don't quite know why, but it seems like this new library breaks tests of llvm-config; if I start out with an empty build directory and run `ninja check-llvm` (or `ninja llvm-test-depends`), then this library doesn't get built, and llvm-config prints `llvm-config: err

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG911d2dc23035: [NFC] [HLSL] Move common metadata to LLVMFrontend (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz added inline comments. Comment at: llvm/lib/Target/DirectX/DXILResource.h:46 // can only be added to the end, and not removed. enum class Kinds : uint32_t { Invalid = 0, python3kgae wrote: > Could we move ResourceBase::Kinds to Frontend/HLSL/HLSL

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

python3kgae added inline comments. Comment at: llvm/lib/Target/DirectX/DXILResource.h:46 // can only be added to the end, and not removed. enum class Kinds : uint32_t { Invalid = 0, Could we move ResourceBase::Kinds to Frontend/HLSL/HLSLResource.h so w

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz updated this revision to Diff 467606. beanz added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/CodeGen/CMakeLists.txt

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz added a comment. In D135110#3832728 , @tschuett wrote: > The OpenMP frontend is mainly an IRBuilder. It is a different layering than > for HLSL. Are there plans for an HLSL(IR)Builder? HLSL and OpenMP are different in a lot of ways. HLSL's code ge

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

tschuett added a comment. The OpenMP frontend is mainly an IRBuilder. It is a different layering than for HLSL. Are there plans for an HLSL(IR)Builder? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110 ___

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

python3kgae added inline comments. Comment at: llvm/include/llvm/Frontend/HLSL/HLSLResource.h:35 + GlobalVariable *getGlobalVariable(); + StringRef getSourceType(); + Constant *getID(); Could we save things like shape and component type instead of a StringRef

[PATCH] D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend

beanz created this revision. beanz added reviewers: python3kgae, tschuett, jdoerfert, bogner, pow2clk, tex3d, Anastasia, efriedma. Herald added a subscriber: hiraditya. Herald added a project: All. beanz requested review of this revision. Herald added projects: clang, LLVM. This change pulls some