python3kgae added inline comments.
================ Comment at: llvm/include/llvm/Frontend/HLSL/HLSLResource.h:35 + GlobalVariable *getGlobalVariable(); + StringRef getSourceType(); + Constant *getID(); ---------------- Could we save things like shape and component type instead of a StringRef which needs to be parsed later? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135110/new/ https://reviews.llvm.org/D135110 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits