[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion"

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">,

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">,

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Muhammad Usman Shahid via Phabricator via cfe-commits
Codesbyusman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion"

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">,

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: aaron.ballman, erichkeane, xgupta. aaron.ballman added a comment. Thank you for looking into this! I'm adding a few more reviewers for awareness. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

2022-06-14 Thread Muhammad Usman Shahid via Phabricator via cfe-commits
Codesbyusman created this revision. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127759 Files: clang/include/clang/Basic/Diagno