erichkeane added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">, InGroup<InfiniteRecursion>, DefaultIgnore; ---------------- aaron.ballman wrote: > A few things: > > * Diagnostics in Clang are not intended to be grammatically correct, so they > don't start with a capital letter or end with a trailing full stop (so if > this wording was kept, you should use `in order` instead of `In order`). > * While this is a cute way to get the point across, we want the diagnostic to > help guide the user as to why their code is wrong so they have the best > chance to fix the issue. > > I think the original wording isn't too bad here because it's lexically > associated with the function definition itself (so the "this function" is > clear in situ), but I do think "will call itself" is a bit awkward. Perhaps > "this function is called recursively on all paths through the function", but > I don't feel strongly either. I like the suggestion by Aaron here, "function %0 is called recursively through all paths through %0" (or the function). Perhaps the double %0 is a touch of a recursion joke as well :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127759/new/ https://reviews.llvm.org/D127759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
