[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8fbd1157deb: [clang-tidy] Ignore concepts in `misc-redundant-expression` (authored by Izaron). Changed prior to commit: https://reviews.llvm.org/D122078?vs=466271&id=466273#toc Repository: rG LLVM G

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 466271. Izaron added a comment. Removed redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressio

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, just one small nit. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/redundant-expression-cxx20.cpp:3 + +// Note: this test expects no diagnostics, but

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron added a comment. Hi! A friendly ping =) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 461003. Izaron added a comment. Fix test with `count 0`, thanks to @njames93 ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files: clang-tools-extra/clang-tidy/mi

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 added a comment. In D122078#3797519 , @Izaron wrote: > The new file was failing with message > > CHECK-FIXES, CHECK-MESSAGES or CHECK-NOTES not found in the input > > So I had to add an additional urrelevant check. > I added a check for constev

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 460990. Izaron added a comment. The new file was failing with message CHECK-FIXES, CHECK-MESSAGES or CHECK-NOTES not found in the input So I had to add an additional urrelevant check. I added a check for consteval function (there were no such tests previous

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 460976. Izaron added a comment. Created redundant-expression-cxx20.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files: clang-tools-extra/clang-tidy/misc/Redun

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 requested changes to this revision. njames93 added a comment. This revision now requires changes to proceed. Just address that test issue then it'll be good Comment at: clang-tools-extra/test/clang-tidy/checkers/misc/redundant-expression.cpp:1 -// RUN: %check_clang_ti

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron updated this revision to Diff 460209. Izaron added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 Files: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cp

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

njames93 added a comment. In D122078#3407984 , @aaron.ballman wrote: > Okie dokie, thanks for weighing in! This LGTM (feel free to add the release > note when landing). If @alexfh has some technical concerns with > `hasAncestor()`, we can always revert

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D122078#3407981 , @sammccall wrote: > I don't actually know a great deal about matcher performance :-( I wish I did. > I think this is

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

sammccall added a comment. I don't actually know a great deal about matcher performance :-( I wish I did. I think this is pretty much in line with how plenty of check matchers already work though, in particular unless(isInTemplateInstantiation()) is basically the same thing and is used in many p

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

aaron.ballman added reviewers: alexfh, sammccall. aaron.ballman added subscribers: sammccall, alexfh. aaron.ballman added a comment. Thanks for the fix, can you also add a release note for it? I'm a bit worried about using `hasAncestor()` for this; that has a tendency to do surprising things in

[PATCH] D122078: [clang-tidy] Ignore concepts in `misc-redundant-expression`

Izaron created this revision. Izaron added reviewers: hokein, njames93, aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The c