aaron.ballman added reviewers: alexfh, sammccall. aaron.ballman added subscribers: sammccall, alexfh. aaron.ballman added a comment.
Thanks for the fix, can you also add a release note for it? I'm a bit worried about using `hasAncestor()` for this; that has a tendency to do surprising things in addition to being expensive because it's very greedy. However, I can't see a situation in which it's going to be wrong, because the body of the requires expression is always unevaluated (so we really don't need to worry about nonsense like defining a lambda in the requires body, and then defining a class in the lambda, and having a redundant expression we care to diagnose in a member function of that class). @alexfh or @sammccall -- do you see any concerns with this use of `hasAncestor()`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
