aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D122078#3407981 <https://reviews.llvm.org/D122078#3407981>, @sammccall wrote: > I don't actually know a great deal about matcher performance :-( I wish I did. > I think this is pretty much in line with how plenty of check matchers already > work though, in particular unless(isInTemplateInstantiation()) is basically > the same thing and is used in many places including this check. > So I wouldn't be particularly worried. > > (Obviously from first principles you'd prefer to prune the subtree rather > than match within it and then walk up the parent chain, but I don't think > matchers supports this pattern well). Okie dokie, thanks for weighing in! This LGTM (feel free to add the release note when landing). If @alexfh has some technical concerns with `hasAncestor()`, we can always revert and address them once we know more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122078/new/ https://reviews.llvm.org/D122078 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits