[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG146ec74a8382: [clang][deps] NFC: Stop going through ClangTool (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D10897

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

jansvoboda11 updated this revision to Diff 370545. jansvoboda11 added a comment. Resolve test failing on Windows by re-setting the VFS on `FileManager`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108979/new/ https://reviews.llvm.org/D108979 Files: clang/lib/Tooling/DependencyScann

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

dexonsmith added a comment. Thanks for explaining why ToolInvocation fits well here. SGTM. In D108979#2979484 , @jansvoboda11 wrote: > I think we can move that conversion into the current constructor that accepts > `std::vector`, add another constructo

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

jansvoboda11 added a comment. I think `ToolInvocation` is somewhat well-suited for the dependency scanner. It takes care of the `DiagnosticOptions` setup, running the driver, extracting source-reading cc1 command-line, creating `CompilerInvocation` and invoking the action itself. This is what w

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

dexonsmith added a comment. In D108979#2974642 , @dexonsmith wrote: > I'm approving as-is, since this is a step forward, but I'm curious if you can > clarify what ToolInvocation is providing, and whether that's worth it or if > it'd make sense (eventua

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. I've independently been wondering for a while whether ClangTool was doing more harm than good for the scanning usecase. I'm approving as-is, since this is a step forward, but I'm

[PATCH] D108979: [clang][deps] NFC: Stop going through ClangTool

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner currently uses `ClangTool` to invoke the dependency scan