dexonsmith added a comment. In D108979#2974642 <https://reviews.llvm.org/D108979#2974642>, @dexonsmith wrote:
> I'm approving as-is, since this is a step forward, but I'm curious if you can > clarify what ToolInvocation is providing, and whether that's worth it or if > it'd make sense (eventually) to go a step further. (To be concrete, I feel any libclang API is likely to accept command-lines as something directly representable as `ArrayRef<const char *>`. Having to repackage that as `std::vector<std::string>` seems a bit unfortunate since the CompilerInvocation will want it repackaged again as `ArrayRef<const char *>`. But maybe ToolInvocation is doing something valuable, and certainly we could change that later.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108979/new/ https://reviews.llvm.org/D108979 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
