dexonsmith added a comment. Thanks for explaining why ToolInvocation fits well here. SGTM.
In D108979#2979484 <https://reviews.llvm.org/D108979#2979484>, @jansvoboda11 wrote: > I think we can move that conversion into the current constructor that accepts > `std::vector<std::string>`, add another constructor that takes > `ArrayRef<const char *>` and use that from the dependency scanner. Yeah, that makes sense. (No reason to block this though... can be done later.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108979/new/ https://reviews.llvm.org/D108979 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits