[PATCH] D106909: [clang] Add clang builtins support for gfx90a

This revision was automatically updated to reflect the committed changes. Closed by commit rG39dac1f7f656: [clang] Add clang builtins support for gfx90a (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://rev

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. I will merge this patch in as soon as the builds are successful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits ma

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. Thanks a lot for the review, I will merge this patch in :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits mailing

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 364266. gandhi21299 added a comment. - combined tests into a single file - renamed tests for consistency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files:

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-fp-atomics-unsupported-gfx7.cl:8 +} \ No newline at end of file Add new line. Comment at: clang/test/CodeGenOpenCL/unsupported-fadd2f16-gfx908.cl:1 +// REQUIRES: amd

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 364242. gandhi21299 added a comment. - added more negative tests - fixed some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files: clang/include/clang/B

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1f", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2f16, "V2hV2h*1V2h", "t", "gfx90a-insts") +TA

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1f", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2f16, "V2hV2h*1V2h", "t", "gfx90a-insts")

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 364152. gandhi21299 added a comment. updating test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clang/l

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } gandhi21299 wrote: > rampitec wrote: > > gand

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } rampitec wrote: > gandhi21299 wrote: > > r

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added a comment. In D106909#2923724 , @gandhi21299 wrote: > @rampitec what should I be testing exactly in the IR test? Produced call to the intrinsic. All of these tests there doing that. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. @rampitec what should I be testing exactly in the IR test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits mailing

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added a comment. In D106909#2922567 , @gandhi21299 wrote: > @rampitec how do I handle the following? > > builtins-fp-atomics.cl:38:10: error: > '__builtin_amdgcn_global_atomic_fadd_f64' needs target feature > atomic-fadd-insts > *rtn = _

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. @rampitec how do I handle the following? builtins-fp-atomics.cl:38:10: error: '__builtin_amdgcn_global_atomic_fadd_f64' needs target feature atomic-fadd-insts *rtn = __builtin_amdgcn_global_atomic_fadd_f64(addr, x, memory_order_relaxed); ^ Reposit

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 marked 5 inline comments as done. gandhi21299 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } -

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } Should we map flags since we already have the

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); arsenm wrote: > rampitec wrote

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); rampitec wrote: > arsenm wrote:

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); arsenm wrote: > rampitec wrote

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); rampitec wrote: > gandhi21299 wr

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); gandhi21299 wrote: > rampitec

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 marked 3 inline comments as done. gandhi21299 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext())

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. Needs an IR test, a test for different supported targets, and a negative test for unsupported features. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.de

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 363196. gandhi21299 added a comment. refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files: clang/include/clang/Basic/BuiltinsAMDGPU.def clan

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 363159. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. addressed reviewers' feedback: - changed a builtin name, - corrected tests, - minor formatting nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 marked 7 inline comments as done. gandhi21299 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fa

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_2f16, "hh*1hi", "t", "gfx90a-insts") +TARGET_BU

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16114 +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); +switch (BuiltinID) { arsenm wrote: > Initializing this here is strange, sink down

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_2f16, "hh*1hi", "t", "gfx90a-insts") +TARGET_BU

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

arsenm added a comment. Missing sema test for rejecting the builtins on targets that don't support this Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builti

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 added a comment. Passed PSDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 362804. gandhi21299 added a comment. fixed tests by replacing checks for the functions with generic-qualified arguments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 362555. gandhi21299 added a comment. - eliminated scope argument, seemed irrelevant Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 Files: clang/include/clang/B

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 362522. gandhi21299 added a comment. Herald added subscribers: llvm-commits, foad, hiraditya. Herald added a project: LLVM. - removed `kernel` from functions taking in `__generic` qualified `addr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 362487. gandhi21299 added a comment. - added scope argument - removed irrelevant tests and updated them - replaced __constant by __generic qualifier for two of the test functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 updated this revision to Diff 362433. gandhi21299 added a comment. - added more tests with supported combinations of address spaces - minor nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 created this revision. gandhi21299 added reviewers: arsenm, yaxunl, rampitec. Herald added subscribers: kerbowa, jfb, tpr, nhaehnle, jvesely. gandhi21299 requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Implement target buil