rampitec added a comment. In D106909#2922567 <https://reviews.llvm.org/D106909#2922567>, @gandhi21299 wrote:
> @rampitec how do I handle the following? > > builtins-fp-atomics.cl:38:10: error: > '__builtin_amdgcn_global_atomic_fadd_f64' needs target feature > atomic-fadd-insts > *rtn = __builtin_amdgcn_global_atomic_fadd_f64(addr, x, > memory_order_relaxed); > ^ It is f64, it needs gfx90a-insts. atomic-fadd-insts is for global f32. ================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 + llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); + return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } ---------------- gandhi21299 wrote: > rampitec wrote: > > Should we map flags since we already have them? > Do you mean the memory order flag? All 3: ordering, scope and volatile. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits