gandhi21299 marked 3 inline comments as done.
gandhi21299 added inline comments.


================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212
+  case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: {
+    Intrinsic::ID IID;
+    llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext());
----------------
rampitec wrote:
> You do not need any of that code. You can directly map a builtin to intrinsic 
> in the IntrinsicsAMDGPU.td.
Sorry, I looked around for several days but I could not figure this out. Is 
there a concrete example?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106909/new/

https://reviews.llvm.org/D106909

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to