[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

2021-07-23 Thread Thomas Lively via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85157c007903: [WebAssembly] Codegen for pmin and pmax (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

2021-07-23 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106612/new/ https://reviews.llvm.org/D106612 __

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

2021-07-23 Thread Thomas Lively via Phabricator via cfe-commits
tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1141 +def : Pat<(vec.int_vt (vselect +(setolt (vec.vt (bitconvert V128:$rhs)), +(vec.vt (bitconvert V128:$lhs))), aheejin wrote: > Sorry

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

2021-07-23 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1141 +def : Pat<(vec.int_vt (vselect +(setolt (vec.vt (bitconvert V128:$rhs)), +(vec.vt (bitconvert V128:$lhs))), Sorry I asked this in

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

2021-07-22 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. R