[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Hongtao Yu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77aec978a911: [CSSPGO] Turn on unique linkage name by default for pseudo probe. (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Wenlei He via Phabricator via cfe-commits
wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-pref

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-name

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-name

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Wenlei He via Phabricator via cfe-commits
wenlei added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-n

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Hongtao Yu via Phabricator via cfe-commits
hoy added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-name

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Wenlei He via Phabricator via cfe-commits
wenlei added inline comments. Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-n

[PATCH] D106193: [CSSPGO] Turn on unique linkage name by default for pseudo probe.

2021-07-16 Thread Hongtao Yu via Phabricator via cfe-commits
hoy created this revision. Herald added subscribers: modimo, wenlei. hoy requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Turning on -funique-internal-linkage-names when -fpseudo-probe-for-profiling is on, unless -fno-unique-internal-linkag