wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land.
lgtm, thanks. ================ Comment at: clang/test/Driver/pseudo-probe.c:4 // RUN: %clang -### -fpseudo-probe-for-profiling -fdebug-info-for-profiling %s 2>&1 | FileCheck %s --check-prefix=CONFLICT +// RUN: %clang -### -fpseudo-probe-for-profiling -funique-internal-linkage-names %s 2>&1 | FileCheck %s --check-prefix=YESPROBE +// RUN: %clang -### -fpseudo-probe-for-profiling -fno-unique-internal-linkage-names %s 2>&1 | FileCheck %s --check-prefix=NONAME ---------------- hoy wrote: > hoy wrote: > > wenlei wrote: > > > hoy wrote: > > > > wenlei wrote: > > > > > how do we test unique linkage name is implied with probe on? > > > > These two test lines below corresponding to line 1 in the test, which > > > > show that -funique-internal-linkage-names is passed to cc1. > > > > > > > > ``` > > > > > > > > // YESPROBE: -fpseudo-probe-for-profiling > > > > // YESPROBE: -funique-internal-linkage-names > > > > ``` > > > > > > > > The change being made here is a driver change, so a driver test should > > > > be good. > > > The change is about making `-funique-internal-linkage-names` implied, but > > > the test specified that switch explicitly. I was asking how to test the > > > "implicit" part? Not sure what line 4 is testing wrt to this change. > > Line 1 is the -funique-internal-linkage-names switch , and we are checking > > `YESPROBE` for it. > > Line 1 is the -funique-internal-linkage-names switch , and we are checking > > `YESPROBE` for it. > > Line is w/o the -funique-internal-linkage-names switch. ah, sorry missed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106193/new/ https://reviews.llvm.org/D106193 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
