[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Oh interesting! Yes, it looks like you are right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Friendly Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 227605. jdoerrie marked 4 inline comments as done. jdoerrie added a comment. Addressed Marshall's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/include/span libcxx/test/std/cont

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added inline comments. Comment at: libcxx/test/std/containers/views/span.cons/span.fail.cpp:78 - -// Try to remove const and/or volatile (static -> static) -{ mclow.lists wrote: > Ok. The comment here is wrong; this is testing dynamic -> static. >

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Thanks Jorg! Given that the status is still "Needs Review", I assume I also still need an LGTM from Marshall, Louis or Eric, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Friendly Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226714. jdoerrie added a comment. Full patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/include/span libcxx/test/std/containers/views/span.cons/span.fail.cpp libcxx/test/std/contain

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 226713. jdoerrie added a comment. Formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/test/std/containers/views/span.cons/span.pass.cpp Index: libcxx/test/std/containers/views/span.

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie created this revision. jdoerrie added reviewers: mclow.lists, ldionne. Herald added a reviewer: EricWF. Herald added subscribers: libcxx-commits, dexonsmith, christof. [libc++] Disallow dynamic -> static span conversions This change disallows dynamic to static span conversions. This comp

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie added a comment. In D60069#1449979 , @mclow.lists wrote: > I'm less enthusiastic about this change than the one for PR39871, because > there we were being inconsistent with ourselves. > However, my lack of enthusiasm is no reason not to land thi

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie updated this revision to Diff 193106. jdoerrie added a comment. Remove redundant `public:` access controls CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60069/new/ https://reviews.llvm.org/D60069 Files: include/__tuple include/array include/span include/tuple include

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie added a comment. In D60069#1449932 , @mclow.lists wrote: > In D60069#1449928 , @mclow.lists > wrote: > > > Did you check the places that inherit from `tuple_element`? The > > public/private bits change b

[PATCH] D60069: Declare std::tuple_element as struct instead of class

jdoerrie created this revision. jdoerrie added a reviewer: mclow.lists. Herald added subscribers: libcxx-commits, ldionne. Similarly to https://reviews.llvm.org/rL350972 this revision changes std::tuple_element from class to struct. Fixes PR#41331. Repository: rCXX libc++ https://reviews.llv

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

jdoerrie added a comment. Thanks for applying a fix based on my patch! I could have sworn the added tests failed locally before applying the algorithm patch, though... oh well. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commit

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

jdoerrie added a comment. Ping, please take a look at this. https://reviews.llvm.org/D32788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

jdoerrie added inline comments. Comment at: include/algorithm:4471 _RBi(__middle), _RBi(__first), _RBi(__last), __negate<_Compare>(__comp)); } As marshall pointed out in https://bugs.llvm.org//show_

[PATCH] D32788: Fix std::inplace_merge to be stable for all inputs

jdoerrie created this revision. This change fixes std::inplace_merge to be stable for all inputs and adds corresponding tests. Fixes Bug 31166: https://bugs.llvm.org//show_bug.cgi?id=31166 https://reviews.llvm.org/D32788 Files: include/algorithm test/std/algorithms/alg.sorting/alg.merge/i