[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam added a comment. In D119199#3337699 , @vtjnash wrote: > Is that a bug in clang or in MSVC2019? We expected that > CLANG_PLUGIN_SUPPORT=ON can expose problems with the Windows linker, and we > add new tests here for verifying that configura

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam added a comment. `release/14.x` now configures but fails to build on MSVC2019 with `-D LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON` like at https://reviews.llvm.org/D00 FAILED: bin/CTTestTidyModule.dll cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_link_dll --intdir=tools\c

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam resigned from this revision. cristian.adam added a comment. This revision is now accepted and ready to land. In D119199#3309117 , @vtjnash wrote: > @cristian.adam Is this good now? You are blocking merging this, but I think > it is ready to

[PATCH] D119199: replace clang LLVM_ENABLE_PLUGINS -> CLANG_PLUGIN_SUPPORT in tests

cristian.adam requested changes to this revision. cristian.adam added a comment. This revision now requires changes to proceed. This patch is having problems on Windows with MSVC 2019 and `-D LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON` and `-D "LLVM_ENABLE_PROJECTS=clang;clang-tools-extra"`. CMake does

[PATCH] D111100: enable plugins for clang-tidy

cristian.adam requested changes to this revision. cristian.adam added a comment. I had on Windows two uses cases that failed due to this patch. 1. MSVC2019 with `-D LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON` FAILED: bin/CTTestTidyModule.dll cmd.exe /C "cd . && C:\tools\cmake\bin\cmake.exe -E vs_li

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. In D75068#2004072 , @davezarzycki wrote: > Rather than wholly reverting this, I committed a fix: > 665471907a5c072c6653a38c35f35e5d54cef220 > > > The pr

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added a comment. @mstorsjo can you merge (again) this on my behalf? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added a comment. Since I do not have commit rights, I require help to get this merged. Comment at: clang/tools/libclang/CMakeLists.txt:88 +if (WIN32 AND ENABLE_SHARED AND ENABLE_STATIC) + unset(ENABLE_STATIC)

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. @thakis ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping. I find it a bit uncool to revert commits and then be away for a month. I guess it's my fault for not making the patch perfect in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https:

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75068/new/ https://reviews.llvm.org/D75068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. I've tested this patch with: -D LIBCLANG_BUILD_STATIC=OFF -D LLVM_ENABLE_PIC=ON All green https://github.com/cristianadam/llvm-project/actions/runs/44839699 Then: -D LIBCLANG_BUILD_STATIC=ON -D LLVM_ENABLE_PIC=OFF All green https://github.com/cristianada

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam created this revision. cristian.adam added reviewers: yvvan, thakis, mstorsjo. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch is a squash for: https://reviews.llvm.org/D74564 https://reviews.llvm.org/D74907 And a fix for the issue that got

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. Thank you! A build with `-DLIBCLANG_BUILD_STATIC=ON` and `-DLLVM_ENABLE_PIC=OFF` is green at: https://github.com/cristianadam/llvm-project/actions/runs/42545217 The default build with `-DLIBCLANG_BUILD_STATIC=OFF` and `-DLLVM_ENABLE_PIC=ON` is green at: https:/

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. > The problem is (I believe) that `add_clang_library(libclang ` is passed > `${ENABLE_SHARED}` and that used to be true on Windows but no longer is after > your change (due to the change in line 80 in your original change), so > libclang.dll isn't built at all any

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam updated this revision to Diff 245683. cristian.adam added a comment. `-DLLVM_ENABLE_PIC=OFF` on Windows if `LIBCLANG_BUILD_STATIC` is not set to `ON` will generate a SHARED libclang.dll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74907/new/ https://reviews.llvm.org/D74907 ___ cfe-commits ma

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam added a comment. In D74907#1884795 , @thakis wrote: > Thanks! Does this make it so that libclang.dll is built again with > -DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that > correct? If so, could you reinstantiate

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam marked an inline comment as done. cristian.adam added inline comments. Comment at: clang/include/clang-c/Platform.h:33 #endif -#elif defined(CINDEX_EXPORTS) +#elif defined(CINDEX_EXPORTS) && defined(__GNUC__) #define CINDEX_LINKAGE __attribute__((visibility("d

[PATCH] D74907: libclang: Make shared object symbol exporting by default

cristian.adam created this revision. cristian.adam added reviewers: yvvan, mstorsjo, thakis. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. https://reviews.llvm.org/D74564 enabled static building for libclang, and for non CMake consumers they had to set the `CMAKE_E

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. > I'll submit it today. Done, see: https://reviews.llvm.org/D74907 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe-commi

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. In D74564#1884675 , @thakis wrote: > Great, thanks. Since we're currently broken due to this change, any ETA for > the follow-up? I'll submit it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. > Given that this is currently a breaking change: Does it make sense to re-use > LLVM_ENABLE_PIC for this, which currently doesn't have an effect on Windows > anywhere? Maybe there should be a dedicated "I want libclang to be a static > library" opt-in? And maybe

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam marked an inline comment as done. cristian.adam added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:117 if(ENABLE_SHARED) + target_compile_definitions(libclang PUBLIC CINDEX_EXPORTS) if(WIN32) thakis wrote: > Is this enough?

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. @mstorsjo can you help me with pushing this commit? Thank you in advance! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. I do not have commit rights, I need help to submit this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 ___ cfe-commits ma

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam updated this revision to Diff 244944. cristian.adam marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 Files: clang/include/clang-c/Platform.h clang/tools/libc

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added inline comments. Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif yvvan wrote: > Is it different from just leaving CINDEX_LINKAGE empty? On

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam added a comment. Build with this patch being built on GitHub Actions on Windows MSVC, Windows MinGW, Linux, macOS: https://github.com/cristianadam/llvm-project/actions/runs/38838989 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564

[PATCH] D74564: libclang: Add static build support for Windows

cristian.adam created this revision. cristian.adam added reviewers: chapuni, yvvan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. On Linux and macOS it was possible to build libclang statically by configuring CMake with: -D LIBCLANG_BUILD_STATIC=ON -D LLVM_ENABLE_