cristian.adam added a comment. > Given that this is currently a breaking change: Does it make sense to re-use > LLVM_ENABLE_PIC for this, which currently doesn't have an effect on Windows > anywhere? Maybe there should be a dedicated "I want libclang to be a static > library" opt-in? And maybe the Platform.h should default to the dll setup and > require a define to not use it, instead of the other way round? That seems > safer for embedders.
I'll try the other way around in a subsequent review. I agree that the existing code shouldn't be changed, and only the users that want a static libclang should have to do changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
