cristian.adam marked an inline comment as done. cristian.adam added inline comments.
================ Comment at: clang/tools/libclang/CMakeLists.txt:117 if(ENABLE_SHARED) + target_compile_definitions(libclang PUBLIC CINDEX_EXPORTS) if(WIN32) ---------------- thakis wrote: > Is this enough? Every target that depends on libclang now needs to define > CINDEX_EXPORTS – is that already the case? The targets that depend on libclang should get the `CINDEX_EXPORTS` from libclang due to the `PUBLIC` usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74564/new/ https://reviews.llvm.org/D74564 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
