r345545 - [ASTImporter] Reorder fields after structure import is finished

Author: a.sidorin Date: Mon Oct 29 14:46:18 2018 New Revision: 345545 URL: http://llvm.org/viewvc/llvm-project?rev=345545&view=rev Log: [ASTImporter] Reorder fields after structure import is finished There are multiple reasons why field structures can be imported in wrong order. The simplest is t

r344864 - [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu-extensions)

Author: a.sidorin Date: Sat Oct 20 15:49:23 2018 New Revision: 344864 URL: http://llvm.org/viewvc/llvm-project?rev=344864&view=rev Log: [AST, analyzer] Transform rvalue cast outputs to lvalues (fheinous-gnu-extensions) Despite the fact that cast expressions return rvalues, GCC still handles such

r344847 - [NFC][Test commit] Fix typos in a comment

Author: a.sidorin Date: Sat Oct 20 07:47:37 2018 New Revision: 344847 URL: http://llvm.org/viewvc/llvm-project?rev=344847&view=rev Log: [NFC][Test commit] Fix typos in a comment Modified: cfe/trunk/lib/StaticAnalyzer/Core/CheckerManager.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/Checke

r332338 - [ASTImporter] Extend lookup logic in class templates

Author: a.sidorin Date: Tue May 15 04:09:07 2018 New Revision: 332338 URL: http://llvm.org/viewvc/llvm-project?rev=332338&view=rev Log: [ASTImporter] Extend lookup logic in class templates During import of a class template, lookup may find a forward declaration and structural match falsely report

r332256 - [ASTImporter] Turn StringRefs back to std::strings to avoid use-after-free

Author: a.sidorin Date: Mon May 14 09:12:31 2018 New Revision: 332256 URL: http://llvm.org/viewvc/llvm-project?rev=332256&view=rev Log: [ASTImporter] Turn StringRefs back to std::strings to avoid use-after-free This is a workaround for the issue in buildASTFromCodeWithArgs() where a local buffer

r331762 - [ASTImporter] Properly import SourceLocations of Attrs

Author: a.sidorin Date: Tue May 8 05:45:21 2018 New Revision: 331762 URL: http://llvm.org/viewvc/llvm-project?rev=331762&view=rev Log: [ASTImporter] Properly import SourceLocations of Attrs Patch by Rafael Stahl! Differential Revision: https://reviews.llvm.org/D46115 Added: cfe/trunk/test

r330704 - [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls

Author: a.sidorin Date: Tue Apr 24 03:11:53 2018 New Revision: 330704 URL: http://llvm.org/viewvc/llvm-project?rev=330704&view=rev Log: [ASTImporter] Allow testing of import sequences; fix import of typedefs for anonymous decls This patch introduces the ability to test an arbitrary sequence of i

r330613 - Quick fix for rC330605: specify a target arch for test

Author: a.sidorin Date: Mon Apr 23 09:38:29 2018 New Revision: 330613 URL: http://llvm.org/viewvc/llvm-project?rev=330613&view=rev Log: Quick fix for rC330605: specify a target arch for test Modified: cfe/trunk/test/Analysis/sval-dump-int128.c Modified: cfe/trunk/test/Analysis/sval-dump-int

r330605 - [analyzer] Don't crash on printing ConcreteInt of size >64 bits

Author: a.sidorin Date: Mon Apr 23 08:41:44 2018 New Revision: 330605 URL: http://llvm.org/viewvc/llvm-project?rev=330605&view=rev Log: [analyzer] Don't crash on printing ConcreteInt of size >64 bits Printing of ConcreteInts with size >64 bits resulted in assertion failure in get[Z|S]ExtValue() b

r329301 - [ASTImporter] Fix for importing unnamed structs

Author: a.sidorin Date: Thu Apr 5 08:31:49 2018 New Revision: 329301 URL: http://llvm.org/viewvc/llvm-project?rev=329301&view=rev Log: [ASTImporter] Fix for importing unnamed structs Patch by Peter Szecsi! Differential Revision: https://reviews.llvm.org/D30876 Modified: cfe/trunk/lib/AST/

r325118 - Quick fix for 325116 buildbots: move template specialization into namespace

Author: a.sidorin Date: Wed Feb 14 03:39:33 2018 New Revision: 325118 URL: http://llvm.org/viewvc/llvm-project?rev=325118&view=rev Log: Quick fix for 325116 buildbots: move template specialization into namespace Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImpo

r325116 - [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl

Author: a.sidorin Date: Wed Feb 14 03:18:00 2018 New Revision: 325116 URL: http://llvm.org/viewvc/llvm-project?rev=325116&view=rev Log: [ASTImporter] Fix lexical DC for templated decls; support VarTemplatePartialSpecDecl Also minor refactoring in related functions was done. Differential Revisio

r323519 - [ASTImporter] Support LambdaExprs and improve template support

Author: a.sidorin Date: Fri Jan 26 03:36:54 2018 New Revision: 323519 URL: http://llvm.org/viewvc/llvm-project?rev=323519&view=rev Log: [ASTImporter] Support LambdaExprs and improve template support Also, a number of style and bug fixes was done: * ASTImporterTest: added sanity check for sourc

r322091 - [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

Author: a.sidorin Date: Tue Jan 9 08:40:40 2018 New Revision: 322091 URL: http://llvm.org/viewvc/llvm-project?rev=322091&view=rev Log: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr * Note: This solution is based on https://github.com/haoNoQ/clang/blob/su

r322079 - [ASTImporter] Fix missing SourceLoc import for ObjCMethodDecl selectors

Author: a.sidorin Date: Tue Jan 9 06:25:05 2018 New Revision: 322079 URL: http://llvm.org/viewvc/llvm-project?rev=322079&view=rev Log: [ASTImporter] Fix missing SourceLoc import for ObjCMethodDecl selectors Patch by Nico Rieck, test case by Sean Callanan! Differential Revision: https://reviews.

Re: r320942 - [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr

ng%2F0%2Fstdout Please let me know if you have trouble reproducing. Thanks, Peter On Sun, Dec 17, 2017 at 6:16 AM, Aleksei Sidorin via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: a.sidorin Date: Sun Dec 17 06:16:17 2017 New Revision: 320942 URL: http:/

r321492 - [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr

Author: a.sidorin Date: Wed Dec 27 09:04:42 2017 New Revision: 321492 URL: http://llvm.org/viewvc/llvm-project?rev=321492&view=rev Log: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr * Also introduces ImportTemplateArgumentListInfo facility (A. Sidorin) Thi

r321285 - [ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing'

Author: a.sidorin Date: Thu Dec 21 09:41:06 2017 New Revision: 321285 URL: http://llvm.org/viewvc/llvm-project?rev=321285&view=rev Log: [ASTImporterTest] Add mandatory testing with '-fdelayed-template-parsing' * While running ASTImporterTests, we often forget about Windows MSVC buildbots whic

Re: r320942 - [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr

.g. https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin_upload_clang%2F277%2F%2B%2Frecipes%2Fsteps%2Fpackage_clang%2F0%2Fstdout Please let me know if you have trouble reproducing. Thanks, Peter On Sun, Dec 17, 2017 at 6:16 AM, Aleksei Sidorin via cfe-commits mailto:cfe-commits@list

r320942 - [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr

Author: a.sidorin Date: Sun Dec 17 06:16:17 2017 New Revision: 320942 URL: http://llvm.org/viewvc/llvm-project?rev=320942&view=rev Log: [ASTImporter] Support importing FunctionTemplateDecl and CXXDependentScopeMemberExpr * Also introduces ImportTemplateArgumentListInfo facility (A. Sidorin) Pat

r319632 - [ASTImporter] Add unit tests for UsingDecl and UsingShadowDecl

Author: a.sidorin Date: Sun Dec 3 08:04:07 2017 New Revision: 319632 URL: http://llvm.org/viewvc/llvm-project?rev=319632&view=rev Log: [ASTImporter] Add unit tests for UsingDecl and UsingShadowDecl Patch by Kareem Khazem! Differential Revision: https://reviews.llvm.org/D27181 Modified: cf

r319015 - [ASTImporter] Support importing CXXPseudoDestructorExpr

Author: a.sidorin Date: Mon Nov 27 02:30:00 2017 New Revision: 319015 URL: http://llvm.org/viewvc/llvm-project?rev=319015&view=rev Log: [ASTImporter] Support importing CXXPseudoDestructorExpr Patch by Peter Szecsi! Differential Revision: https://reviews.llvm.org/D38843 Modified: cfe/trunk/

r318998 - [ASTImporter] Support TypeTraitExpr

Author: a.sidorin Date: Sun Nov 26 09:04:06 2017 New Revision: 318998 URL: http://llvm.org/viewvc/llvm-project?rev=318998&view=rev Log: [ASTImporter] Support TypeTraitExpr Patch by Takafumi Kubota! Differential Revision: https://reviews.llvm.org/D39722 Modified: cfe/trunk/lib/AST/ASTImport

r318776 - [ASTImporter] Support new AST nodes:

Author: a.sidorin Date: Tue Nov 21 08:08:41 2017 New Revision: 318776 URL: http://llvm.org/viewvc/llvm-project?rev=318776&view=rev Log: [ASTImporter] Support new AST nodes: * UnresolvedUsingType * EmptyDecl * NamespaceAliasDecl * UsingDecl * UsingShadowDecl * UsingDirectiveDecl * Unresolve

r318754 - [Analyzer] Stable iteration on indirect goto LabelDecl's to avoid non-determinism (attempt 2)

Author: a.sidorin Date: Tue Nov 21 03:27:47 2017 New Revision: 318754 URL: http://llvm.org/viewvc/llvm-project?rev=318754&view=rev Log: [Analyzer] Stable iteration on indirect goto LabelDecl's to avoid non-determinism (attempt 2) CFG wass built in non-deterministic order due to the fact that ind

r318753 - [Analyzer] Revert r318750 because incorrect files were added for commit.

Author: a.sidorin Date: Tue Nov 21 03:20:07 2017 New Revision: 318753 URL: http://llvm.org/viewvc/llvm-project?rev=318753&view=rev Log: [Analyzer] Revert r318750 because incorrect files were added for commit. Sorry for the noise. Removed: cfe/trunk/test/Analysis/cfg-indirect-goto-determinis

r318750 - [Analyzer] Non-determinism: stable iteration on indirect goto LabelDecl's

Author: a.sidorin Date: Tue Nov 21 03:05:28 2017 New Revision: 318750 URL: http://llvm.org/viewvc/llvm-project?rev=318750&view=rev Log: [Analyzer] Non-determinism: stable iteration on indirect goto LabelDecl's CFG wass built in non-deterministic order due to the fact that indirect goto labels' de

r296884 - [Analyzer] Terminate analysis on OpenMP code instead of assertion crash

Author: a.sidorin Date: Fri Mar 3 10:58:53 2017 New Revision: 296884 URL: http://llvm.org/viewvc/llvm-project?rev=296884&view=rev Log: [Analyzer] Terminate analysis on OpenMP code instead of assertion crash * ExprEngine assumes that OpenMP statements should never appear in CFG. However, curren

r295654 - [ASTImporter] Support default argument initialization of ParmVarDecls

Author: a.sidorin Date: Mon Feb 20 05:57:12 2017 New Revision: 295654 URL: http://llvm.org/viewvc/llvm-project?rev=295654&view=rev Log: [ASTImporter] Support default argument initialization of ParmVarDecls Patch by Peter Szecsi! Differential Revision: https://reviews.llvm.org/D29612 Modified:

r295644 - [analyzer] Do not duplicate call graph nodes for functions that have definition and forward declaration

Author: a.sidorin Date: Mon Feb 20 03:16:48 2017 New Revision: 295644 URL: http://llvm.org/viewvc/llvm-project?rev=295644&view=rev Log: [analyzer] Do not duplicate call graph nodes for functions that have definition and forward declaration Patch by Ivan Sidorenko! Differential Revision: https:/

r292781 - ASTImporter: fix tests on Windows with removing slashed parts of paths

Author: a.sidorin Date: Mon Jan 23 04:39:45 2017 New Revision: 292781 URL: http://llvm.org/viewvc/llvm-project?rev=292781&view=rev Log: ASTImporter: fix tests on Windows with removing slashed parts of paths Differential Revision: https://reviews.llvm.org/D26753 Modified: cfe/trunk/test/ASTMe

r292779 - ASTImporter: quick test fix

Author: a.sidorin Date: Mon Jan 23 04:16:30 2017 New Revision: 292779 URL: http://llvm.org/viewvc/llvm-project?rev=292779&view=rev Log: ASTImporter: quick test fix Differential Revision: https://reviews.llvm.org/D26753 Modified: cfe/trunk/test/ASTMerge/class-template-partial-spec/test.cpp M

r292778 - ASTImporter: add forgotten tests for rL292776

Author: a.sidorin Date: Mon Jan 23 03:45:29 2017 New Revision: 292778 URL: http://llvm.org/viewvc/llvm-project?rev=292778&view=rev Log: ASTImporter: add forgotten tests for rL292776 Added: cfe/trunk/test/ASTMerge/class-template-partial-spec/ cfe/trunk/test/ASTMerge/class-template-partial

r292776 - ASTImporter: improve support for C++ templates

Author: a.sidorin Date: Mon Jan 23 03:30:36 2017 New Revision: 292776 URL: http://llvm.org/viewvc/llvm-project?rev=292776&view=rev Log: ASTImporter: improve support for C++ templates * Support template partial specialization * Avoid infinite recursion in IsStructurallyEquivalent for TemplateArg

[PATCH] D26753: ASTImporter: improve support for C++ templates

a.sidorin updated this revision to Diff 79054. a.sidorin added a comment. Add a simple test for import of complex `NestedNameSpecifierLoc`s. https://reviews.llvm.org/D26753 Files: include/clang/AST/TemplateBase.h lib/AST/ASTImporter.cpp test/ASTMerge/class-template-partial-spec/Inputs/cl

[PATCH] D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes

a.sidorin requested changes to this revision. a.sidorin added a reviewer: a.sidorin. a.sidorin added a comment. This revision now requires changes to proceed. Hi Kareem! I'll be happy to see this changes in upstream. Please see my comments inline. Comment at: lib/AST/ASTImport

[PATCH] D26904: [astimporter] Support importing CXXDependentScopeMemberExpr and FunctionTemplateDecl

a.sidorin requested changes to this revision. a.sidorin added a subscriber: aaron.ballman. a.sidorin added a comment. This revision now requires changes to proceed. Hello Kareem, Thank you for working on it! You can find my comments below. Comment at: include/clang/ASTMatchers/

[PATCH] D26838: [analyzer] Enforce super-region classes for various memory regions through compile-time and run-time type checks.

a.sidorin added a comment. Hi Artem! I like this change mostly but I also have some remarks. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279 /// associated element type, index, and super region. const ElementRegion *getElementRegion(QualType

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

a.sidorin added a comment. Personally, I like this change because it makes our assumptions clearer. My comments are below. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:54 + : store(st), region(r) { +assert(r->getValueType()->isRecor

[PATCH] D26753: ASTImporter: improve support for C++ templates

a.sidorin added a comment. Thank you! I'll update this review again when I have a test for NestedNameSpecifierLocs. Comment at: lib/AST/ASTImporter.cpp:458 + } + return true; +} spyffe wrote: > Is this really an appropriate default result? I would argue for

[PATCH] D26753: ASTImporter: improve support for C++ templates

a.sidorin updated this revision to Diff 78382. a.sidorin added a comment. Address review comments; fix tests. https://reviews.llvm.org/D26753 Files: include/clang/AST/TemplateBase.h lib/AST/ASTImporter.cpp test/ASTMerge/class-template-partial-spec/Inputs/class-template-partial-spec1.cpp

[PATCH] D26753: ASTImporter: improve support for C++ templates

a.sidorin created this revision. a.sidorin added reviewers: spyffe, khazem. a.sidorin added a subscriber: cfe-commits. - Support template partial specialization - Avoid infinite recursion in IsStructurallyEquivalent for TemplateArgument with implementing IsStructurallyEquivalent for TemplateName

[PATCH] D26571: Clean up layout of ASTMerge tests

a.sidorin added a comment. @spyffe : It seems to be OK. Repository: rL LLVM https://reviews.llvm.org/D26571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

a.sidorin added a comment. Hi Krzysztof! This change seems useful: I can imagine the situation where we want to ask current `LocationContext` in this callback. The change looks pretty intrusive but I mostly agree with it. Initially, I have some questions about the implementation of `getArgSVal

[PATCH] D26571: Clean up layout of ASTMerge tests

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Looks good, thank you! Repository: rL LLVM https://reviews.llvm.org/D26571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

[PATCH] D26589: Add static analyzer checker for finding infinite recursion

a.sidorin added a comment. Wow, thank you for such a contribution! Did you evaluate this checker on some real code? I have some minor inline comments below. Comment at: lib/StaticAnalyzer/Checkers/CMakeLists.txt:41 IdenticalExprChecker.cpp +RecursionChecker.cpp

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

a.sidorin added a comment. > Do you think it would be reasonable to take this diff the way it currently it > is, and start a new one that pulls all the input fiels into test-specific > subdirectories? > That way the desired layout of the `Inputs` directory will be clear to > future developers

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

a.sidorin added a comment. Hi Sean! I meant that I'd like to have a layout like this: macro-loc.m Inputs/macro-loc/macro.modulemap Inputs/macro-loc/macro1.h Inputs/macro-loc/macro1.m Inputs/macro-loc/macro2.m By the way, I see that we use another workaround for this issue: we use `getDecomposedE

[PATCH] D19979: [analyzer] ScopeContext - initial implementation

a.sidorin added a comment. Hm. A pretty nice example. But we should check if the initial patch supports `goto`s; afair, it doesn't. https://reviews.llvm.org/D19979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. Looks good. But I think it will be good to put the files in Input to a separate directory. https://reviews.llvm.org/D26054 ___ cfe-commits

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

a.sidorin added a comment. Thank you for this patch! I like some solutions used in it but I also have some comments (inline). https://reviews.llvm.org/D25660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D25660: [Analyzer] Checker for iterators dereferenced beyond their range.

a.sidorin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp:209 + CheckerContext &C) const { + const auto *Func = Call.getDecl()->getAsFunction(); + if (Func->isOverloadedOperator()) { ---

[PATCH] D25503: [analyzer] Remove superquadratic behaviour from DataflowWorklist

a.sidorin accepted this revision. a.sidorin added a comment. This patch reduces both the analysis time and the line count. I like it! :) Did you test Artem's approach? Repository: rL LLVM https://reviews.llvm.org/D25503 ___ cfe-commits mailing li

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

a.sidorin added inline comments. Comment at: test/Analysis/unreachable-code-path.c:201 +static int inlineFunction(const int i) { + if (table[i] != 0) +return 1; I have a small question. Is it possible to simplify this sample with removing of table[] array?

[PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

a.sidorin abandoned this revision. a.sidorin added a comment. Merged into https://reviews.llvm.org/D14326 and committed. https://reviews.llvm.org/D24807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

r282578 - ASTMerge: explicitly specify arch for GCCAsmStmt test to calm non-x86 buildbots

Author: a.sidorin Date: Wed Sep 28 06:04:42 2016 New Revision: 282578 URL: http://llvm.org/viewvc/llvm-project?rev=282578&view=rev Log: ASTMerge: explicitly specify arch for GCCAsmStmt test to calm non-x86 buildbots This should fix r282572. Added: cfe/trunk/test/ASTMerge/Inputs/asm-function.

r282576 - ASTMerge: specify arch for GCCAsmStmt test explicitly to calm non-x86 buildbots

Author: a.sidorin Date: Wed Sep 28 05:57:36 2016 New Revision: 282576 URL: http://llvm.org/viewvc/llvm-project?rev=282576&view=rev Log: ASTMerge: specify arch for GCCAsmStmt test explicitly to calm non-x86 buildbots Modified: cfe/trunk/test/ASTMerge/Inputs/exprs3.cpp Modified: cfe/trunk/tes

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin added a comment. Committed after Aaron's comment were addressed. Big thanks to all reviewers! Repository: rL LLVM https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

This revision was automatically updated to reflect the committed changes. Closed by commit rL282572: [ASTImporter] Implement some expression-related AST node import (part 2) (authored by a.sidorin). Changed prior to commit: https://reviews.llvm.org/D14326?vs=72625&id=72791#toc Repository: rL

r282572 - [ASTImporter] Implement some expression-related AST node import (part 2)

Author: a.sidorin Date: Wed Sep 28 05:16:56 2016 New Revision: 282572 URL: http://llvm.org/viewvc/llvm-project?rev=282572&view=rev Log: [ASTImporter] Implement some expression-related AST node import (part 2) * Some code cleanup * Add tests not present in http://reviews.llvm.org/D14286 * Integrat

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 72625. a.sidorin added a comment. Address review comments; add accidentally missed file. https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp lib/Serialization/ASTReaderStmt.

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated the summary for this revision. a.sidorin added reviewers: ABataev, aaron.ballman. a.sidorin updated this revision to Diff 72614. a.sidorin added a comment. Merge patch https://reviews.llvm.org/D24807 to both fix segmentation fault and provide a test for it. https://reviews.llv

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin added a comment. Don't hurry. The segfault is fixed already and patch waits for approval: https://reviews.llvm.org/D24807. I'll update this fix in Monday. https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D24807: [Serialization] ArrayTypeTraitExpr: serialize sub-expression to avoid keeping it undefined

a.sidorin created this revision. a.sidorin added reviewers: aaron.ballman, doug.gregor. a.sidorin added a subscriber: cfe-commits. I have encountered a segfault when I tried to get sub-expression of serialized ArrayTypeTraitExpr. The fix is simple but I have no idea about nice test. Maybe you ha

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

a.sidorin added a comment. This definitely seems to be useful. However, this patch is pretty big. Some of its parts are not directly related with the feature being introduced (for example, changes for copypaste/sub-sequences.cpp). Is it possible to split this patch? Moreover, as I understand, y

r280367 - [analyzer] ExprEngine: remove second call to PreStmt

Author: a.sidorin Date: Thu Sep 1 08:55:38 2016 New Revision: 280367 URL: http://llvm.org/viewvc/llvm-project?rev=280367&view=rev Log: [analyzer] ExprEngine: remove second call to PreStmt This patch also introduces AnalysisOrderChecker which is intended for testing of callback call correctness.

Re: [PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

This revision was automatically updated to reflect the committed changes. Closed by commit rL280360: [analyzer] Add more FileIDs to PlistDiagnostic map to avoid assertion (authored by a.sidorin). Changed prior to commit: https://reviews.llvm.org/D22090?vs=68987&id=69993#toc Repository: rL LL

r280360 - [analyzer] Add more FileIDs to PlistDiagnostic map to avoid assertion

Author: a.sidorin Date: Thu Sep 1 07:25:16 2016 New Revision: 280360 URL: http://llvm.org/viewvc/llvm-project?rev=280360&view=rev Log: [analyzer] Add more FileIDs to PlistDiagnostic map to avoid assertion Some FileIDs that may be used by PlistDiagnostics were not added while building a list of p

r280352 - [analyzer][test commit] ExprEngine.cpp: Remove training whitespace; NFC

Author: a.sidorin Date: Thu Sep 1 06:11:46 2016 New Revision: 280352 URL: http://llvm.org/viewvc/llvm-project?rev=280352&view=rev Log: [analyzer][test commit] ExprEngine.cpp: Remove training whitespace; NFC Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Modified: cfe/trunk/li

Re: [PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

a.sidorin updated this revision to Diff 68987. a.sidorin added a comment. Add plist output; give test files meaningful names. https://reviews.llvm.org/D22090 Files: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp test/Analysis/diagnostics/Inputs/include/plist-diagnostics-include-check-macro.d

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin added a comment. Serge, Sean, is this patch OK to commit? https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23272: [analyzer][Rewrite] Fix boxes and shadows in HTML rewrites in Firefox.

a.sidorin added inline comments. Comment at: lib/Rewrite/HTMLRewrite.cpp:304 @@ -303,2 +303,3 @@ + " border-radius:5px; box-shadow:1px 1px 7px #000; " " -webkit-border-radius:5px; -webkit-box-shadow:1px 1px 7px #000; " "position: absolute; top: -

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 64704. a.sidorin added a comment. Fix signed/unsigned mismatch warning in the loop condition. https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class3

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 64676. a.sidorin added a comment. Removed unneeded matcher. https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class3.cpp test/ASTMerge/Inputs/exprs3

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 64663. a.sidorin added a comment. An attempt to fix unit test on Windows. Serge, thank you! Could you please check this patch again? https://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImp

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

a.sidorin added a comment. Adam, It is not a debug checker. It is UndefinedAssignment checker which correctly tells us that `Inner.y` is assigned with an uninitialized value while copying. So I wonder if we are allowed to skip such warnings because these warnings don't look like false positive

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin added a comment. > I don't think this small improvement in Importer is worth invasive changes in > other components. Thanks, Serge. Is it OK to commit? https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D22374: [analyzer] Copy and move constructors - ExprEngine extended for "almost trivial" copy and move constructors

a.sidorin added inline comments. Comment at: test/Analysis/ctor.mm:177 @@ -176,3 +176,3 @@ Inner(const Inner &Other) -: x(Other.x), y(Other.y) // expected-warning {{undefined}} +: x(Other.x), y(Other.y) // no-warning { Seems like we m

[PATCH] D22090: [analyzer] Add more FileIDs to PlistDiagnostic map

a.sidorin created this revision. a.sidorin added reviewers: zaks.anna, dcoughlin. a.sidorin added a subscriber: cfe-commits. Some FileIDs that may be used by PlistDiagnostics are not added while building a list of pieces. This leads to assertion violation in `GetFID()` function. This patch tries

Re: [PATCH] D21978: [analyzer] Add LocationContext to SymbolMetadata

a.sidorin added a comment. In http://reviews.llvm.org/D21978#476200, @NoQ wrote: > I also never noticed that the block count gets reset on every stack frame, > that's pretty unobvious. Yes, that was surprising for me too. > Uhm, and it's already there in SymbolConjured. Anyway, fixing the blo

[PATCH] D21978: [analyzer] Add LocationContext to SymbolMetadata

a.sidorin created this revision. a.sidorin added reviewers: zaks.anna, dcoughlin. a.sidorin added a subscriber: cfe-commits. Currently, SymbolMetadata are distinguished by statement and block count. However, in case of inlining, block counts may be the same every time function is called because

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

a.sidorin added a comment. Gabor: Ok,will do. Repository: rL LLVM http://reviews.llvm.org/D14277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 62474. a.sidorin added a comment. Fix some issues pointed by Serge Pavlov. Serge: putting a check of FriendDecls to `IsStructurallyEquivalent()` seems like a good idea for me, but we need some additional changes for it. `CXXRecodeDecl::getFirstDecl()` is

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin marked 2 inline comments as done. Comment at: lib/AST/ASTImporter.cpp:3363 @@ +3362,3 @@ + + // Determine whether we've already imported this decl. + // FriendDecl is not a NamedDecl so we cannot use localUncachedLookup. a.sidorin wrote: > sepavloff wr

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin marked 5 inline comments as done. a.sidorin added a comment. Thank you for your comments! And sorry for late response after pinging. Comment at: lib/AST/ASTImporter.cpp:2518-2519 @@ +2517,4 @@ +Importer.Import(D->getMessage())); + if (!Message) +return nul

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin added a comment. Ping? http://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 57796. a.sidorin marked an inline comment as done. a.sidorin added a comment. Add some basic tests for ExpressionTraitExpr and ArrayTypeTraitExpr. http://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h l

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

a.sidorin added a comment. I' d like to have some tests for this. CXXCtorInitializers can be tested with D14224 -like stuff or with ASTMatchers (ASTImporterTest.cpp). Some code samples may be found in CXX/Sema tests, you just need to port/simplify them. ===

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin marked 4 inline comments as done. Comment at: lib/AST/ASTImporter.cpp:5527 @@ -5353,3 +5526,3 @@ FoundD, - /*FIXME:TemplateArgs=*/nullptr); + /*Templ

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated this revision to Diff 56860. a.sidorin added a comment. Add error checks; replace `NULL` with `nullptr`. http://reviews.llvm.org/D14326 Files: include/clang/AST/ASTImporter.h include/clang/AST/DeclFriend.h lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/class3.cpp test/

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin marked 7 inline comments as done. Comment at: lib/AST/ASTImporter.cpp:5859 @@ +5858,3 @@ + Expr *ToQueried = Importer.Import(E->getQueriedExpression()); + if (!ToQueried) +return nullptr; I usually prefer allocation with required size at the start

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

a.sidorin updated the summary for this revision. a.sidorin added a reviewer: spyffe. a.sidorin removed rL LLVM as the repository for this revision. a.sidorin updated this revision to Diff 56682. a.sidorin added a comment. - Some code cleanup - Add tests not present in http://reviews.llvm.org/D1428

[PATCH] D19979: [analyzer] ScopeContext - initial implementation

a.sidorin created this revision. a.sidorin added reviewers: zaks.anna, dcoughlin, bshastry. a.sidorin added a subscriber: cfe-commits. This patch enables ScopeContext to track variable lifetime. It is RFC mostly since the work on its dependencies is still not finished and it lacks some tests. Pr

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin updated this revision to Diff 53389. a.sidorin added a comment. Update to current master; Fix a memory leak introduced in cf8ccff5: an array is allocated in ImportArray and never freed. http://reviews.llvm.org/D14286 Files: include/clang/AST/Type.h lib/AST/ASTImporter.cpp unitt

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

a.sidorin added a subscriber: a.sidorin. a.sidorin added a comment. Matthias, Could you take a look at http://reviews.llvm.org/D16403? It looks like a duplicating work but it should cover not Objective-C only. http://reviews.llvm.org/D15031 ___ cf

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin added a comment. Is this patch OK to submit? http://reviews.llvm.org/D14286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin updated this revision to Diff 51027. a.sidorin added a comment. Serge, thank you for help! GNUNullExpr was 'long' on my platform. I weakened a matcher to check only if it has integer type. ParenListExpr issue was also successfully reproduced with 'fdelayed-template-parsing' and fixed.

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin updated this revision to Diff 50741. a.sidorin added a comment. An attempt to fix ParenListExpr test on Windows http://reviews.llvm.org/D14286 Files: include/clang/AST/Type.h lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp unittests/AST/CMakeLists.txt Index: unittes

Re: [PATCH] D16873: Refactor MemRegionManager::getVarRegion to call two new functions, improving readability

a.sidorin added a comment. Alexander, could you update status of this review? http://reviews.llvm.org/D16873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

a.sidorin added a comment. Serge: BTW, tests for CXXBoolLiteralExpr are presented in this patch. There is no test //exactly// for it but at least one test uses bool literal and matches it successfully with cxxBoolLiteral() matcher. http://reviews.llvm.org/D14286

  1   2   >