a.sidorin marked 7 inline comments as done. ================ Comment at: lib/AST/ASTImporter.cpp:5859 @@ +5858,3 @@ + Expr *ToQueried = Importer.Import(E->getQueriedExpression()); + if (!ToQueried) + return nullptr; ---------------- I usually prefer allocation with required size at the start and avoid push_back() because it may lead to reallocations.
================ Comment at: lib/AST/ASTImporter.cpp:6002 @@ +6001,3 @@ + } + + CXXNamedCastExpr *Named = cast<CXXNamedCastExpr>(E); ---------------- Hm, that's may be true, but I'm not sure. Added a FIXME. http://reviews.llvm.org/D14326 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
