[PATCH] D155540: [clangd] Remove extra dependancies for clangd

saghir added a comment. Thank you for the review and your comments @sammccall and @mstorsjo. As I understand there is no strong opinion here either way. I think we can leave things as they are for now. I am going to abandon this patch. If someone else feels strongly about removing them, they ca

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

saghir added a comment. In D155111#4495131 , @mstorsjo wrote: > To clarify the issue - the kind of builds that seems to be broken is builds > with `BUILD_SHARED_LIBS=ON`. The reason is that these libraries are needed is > because the `clangd` target inc

[PATCH] D155540: [clangd] Move dependancies for clangd

saghir created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. saghir requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch moves dependancies for clangd inst

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG915659bfa1e9: [clangd] Fix build failures observed on build bots for missing libs (authored by saghir). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

saghir added a comment. @mstorsjo @ivanmurashko Can you please take a look at this? This is blocking our builds on the PowerPC buildbots. Thanks a lot for your time! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155111/new/ https://reviews.llvm.or

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

saghir added a comment. This is to fix failures in the build bot: https://lab.llvm.org/buildbot/#/builders/57/builds/28356 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155111/new/ https://reviews.llvm.org/D155111

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

saghir created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. saghir requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This was broken by 56ac9d46a7c1468d587ccec02a

[PATCH] D113642: [PowerPC] Provide XL-compatible vec_round implementation

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113642/new/ https://reviews.llvm.org/D113642 __

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114088/new/ https://reviews.llvm.org/D114088 __

[PATCH] D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c8b8e0154f0: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113306

[PATCH] D113306: [PowerPC] Allow MMA built-ins to accept non-void pointers and arrays

saghir created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Calls to MMA builtins that take pointer to void do not accept other pointers/arrays whereas normal fu

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG564e082d0954: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers (authored by saghir). Repository: rG LLVM Github Mo

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

saghir updated this revision to Diff 375629. saghir added a comment. Stripped RV qualifiers for Sema checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaChecking.cpp cl

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG593b074a096c: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc… (authored by saghir). Repository: rG LLVM Github Monorepo

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 375443. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

saghir updated this revision to Diff 374529. saghir added a comment. Changed approach for Sema checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaChecking.cpp clang/test

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict qualified pointers

saghir updated this revision to Diff 372505. saghir added a comment. update test case name to be consistent with existing ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/Sema

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

saghir added a comment. In D109624#2998665 , @thakis wrote: > In D109624#2998550 , @saghir wrote: > >> Hi, this change also breaks Power PC bots: >> >> 1. >> https://lab.llvm.org/buildbot/#/builders/19/builds/645

[PATCH] D109624: [clang] Make the driver not diagnose errors on nonexistent linker inputs

saghir added a comment. Hi, this change also breaks Power PC bots: 1. https://lab.llvm.org/buildbot/#/builders/19/builds/6451/steps/24/logs/stdio 2. https://lab.llvm.org/buildbot/#/builders/18/builds/2443/steps/23/logs/stdio It fails consistently on our bots. Can you please take a look? Thanks!

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict qualified pointers

saghir updated this revision to Diff 372151. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaChecking.cpp clang/test/Sema/p

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 372149. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/l

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG203cd01b54dd: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir updated this revision to Diff 372143. saghir added a comment. Rebased before commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.org/D109126 Files: clang/test/CodeGen/builtins-ppc-pair-mma.c clang/test

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir updated this revision to Diff 371919. saghir added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.org/D109126 Files: clang/test/CodeGen/builtins-ppc-pair-mma.c clang/test/Sema/ppc-pair

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir marked an inline comment as done. saghir added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE -

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir updated this revision to Diff 371164. saghir added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109126/new/ https://reviews.llvm.org/D109126 Files: clang/test/CodeGen/builtins-ppc-pair-mma.c clang/

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

saghir created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds Big-Endian checks for the existing MMA test cases. Repository: rG LLVM Github Mon

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 368176. saghir added a comment. Added comments, and re-organized tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.

[PATCH] D107647: [PowerPC] MMA - Add __builtin_vsx_build_pair and __builtin_mma_build_acc builtins

saghir updated this revision to Diff 368109. saghir added a comment. Added some more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/C

[PATCH] D107647: [PowerPC] MMA - Remove deprecated built-ins and add new built-ins

saghir updated this revision to Diff 367530. saghir added a comment. Change the implementation to add new builtins and keep the depracated builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107647/new/ https://reviews.llvm.org/D107647 Files:

[PATCH] D107647: Remove depracated built-ins for MMA and replace with new built-ins

saghir created this revision. Herald added subscribers: kbarton, hiraditya, nemanjai, qcolombet, MatzeB. saghir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D106550: [PowerPC] Allow MMA builtins to accept restrict qualified pointers

saghir updated this revision to Diff 364467. saghir added a comment. Addressed review comments. Added another test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 Files: clang/lib/Sema/SemaCheckin

[PATCH] D106550: [PowerPC] Allow MMA builtins to accpet restrict qualified pointers

saghir created this revision. Herald added subscribers: steven.zhang, shchenz, kbarton, nemanjai. saghir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch allows MMA builtins on PowerPC to accept restrict qualified pointers. Repo

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25bbff632d01: [PowerPC] Provide MMA builtins for compatibility (authored by saghir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatibility

saghir updated this revision to Diff 342732. saghir added a comment. Addressed review comments to add _mma_ version of the built-ins as aliases to the existing _vsx_ versions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100482/new/ https://review

[PATCH] D100482: [PowerPC] Provide MMA builtins for compatability

saghir updated this revision to Diff 337765. saghir added a comment. Fixed spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100482/new/ https://reviews.llvm.org/D100482 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/CodeGen/

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGacce401068e7: [PowerPC] Change target data layout for 16-byte stack alignment (authored by saghir). Changed prior to commit: https://reviews.llvm.

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

saghir updated this revision to Diff 323451. saghir added a comment. Updated tests to add run line for llc and target datalayout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96265/new/ https://reviews.llvm.org/D96265 Files: clang/lib/Basic/Tar

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

saghir updated this revision to Diff 323307. saghir added a comment. Merged tests into one file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96265/new/ https://reviews.llvm.org/D96265 Files: clang/lib/Basic/Targets/PPC.h clang/test/CodeGen/t

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

saghir created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai, emaste. saghir requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This changes the target data layout to make stack align

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91819/new/ https://reviews.llvm.org/D91819 ___

[PATCH] D91974: [PowerPC] Rename the vector pair intrinsics and builtins to replace the _mma_ prefix by _vsx_

saghir accepted this revision. saghir added a comment. LGTM. A minor nit regarding an incomplete comment in `llvm/test/CodeGen/PowerPC/paired-vector-intrinsics.ll` which can be addressed when committing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D90799: [PowerPC] Add paired vector load and store builtins and intrinsics

saghir accepted this revision. saghir added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90799/new/ https://reviews.llvm.org/D90799 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D87921: Fix -funique-internal-linkage-names to work with -O2 and new pass manager

saghir added a comment. In D87921#2288096 , @morehouse wrote: > Thanks for looking. Indeed, it looks like an issue with the disk being full > on the bot. Hi, I checked the disk is not full on the bot. I am not sure what is going on here but its definit

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

This revision was automatically updated to reflect the committed changes. saghir marked an inline comment as done. Closed by commit rGf4c337ab85c0: [PowerPC] Add support for vector bool __int128 for Power10 (authored by saghir). Changed prior to commit: https://reviews.llvm.org/D81816?vs=271874

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:6 +// RUN:-target-feature +power10-vector -fsyntax-only -verify %s +// expected-no-diagnostics + amyk wrote: > I believe this co

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271874. saghir added a reviewer: stefanp. saghir added a comment. Updated comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/Dia

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271860. saghir edited the summary of this revision. saghir added a comment. Updated comment to reflect the change in allowed types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.o

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271498. saghir marked an inline comment as done. saghir added a comment. Updated tests features to check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:2 +// RUN: %clang_cc1 -triple=powerpc64-unknown-linux-gnu -target-feature +altivec -target-feature +vsx -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1170 // Only 'short' and 'long long' are valid with vector bool. (PIM 2.1) if ((TypeSpecWidth != TSW_unspecified) && (TypeSpecWidth != TSW_short) &&

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 3 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector bo

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271459. saghir marked 2 inline comments as done. saghir added a comment. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basi

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e72f47a41d: [PowerPC] Add -m[no-]power10-vector clang and llvm option (authored by saghir). Changed prior to commit: https://reviews.llvm.org/D80758?vs=268893&id=271179#toc Repository: rG LLVM Gith

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271164. saghir added a comment. Updated comment for allowing __int128 for vector bool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271144. saghir added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir updated this revision to Diff 271137. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81816/new/ https://reviews.llvm.org/D81816 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/DeclSpec.cpp clang/test/Parser/altivec

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 4 inline comments as done. saghir added inline comments. Comment at: clang/lib/Sema/DeclSpec.cpp:1155 + // TODO: Update comment with correct Programming Interface Manual + // version once it is available. __int128 has also been added + // to vector bo

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir created this revision. saghir added reviewers: PowerPC, hfinkel. saghir added projects: LLVM, PowerPC. Herald added subscribers: cfe-commits, shchenz, nemanjai. Herald added a project: clang. saghir added a parent revision: D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir updated this revision to Diff 268893. saghir added a comment. Updated the diff based on latest changes in master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80758/new/ https://reviews.llvm.org/D80758 Files: clang/include/clang/Driver/O

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir updated this revision to Diff 268031. saghir marked an inline comment as done. saghir removed a reviewer: power-llvm-team. saghir added a comment. Herald added a subscriber: kbarton. Addressed nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir updated this revision to Diff 267859. saghir added a comment. Removed `P10Altivec`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80758/new/ https://reviews.llvm.org/D80758 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Ta

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:414 +if (Name == "power9-vector") + Features["power10-vector"] = false; Features[Name] = false; lei wrote: > I think it would be good

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

saghir added inline comments. Comment at: clang/test/Driver/ppc-pcrel.cpp:1 +// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel -o %t.o 2>&1 | FileCheck -check-prefix=CHECK-PCREL %s +// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr

[PATCH] D80757: [PowerPC] Add clang option -m[no-]pcrel

saghir accepted this revision. saghir added a comment. This revision is now accepted and ready to land. Other than the nit, this looks good to me. Comment at: clang/test/Driver/ppc-pcrel.cpp:1 +// RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -mcpu=pwr10 -mpcrel -o %

[PATCH] D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option

saghir created this revision. saghir added reviewers: hfinkel, nemanjai, lei, power-llvm-team, amyk. saghir added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, shchenz, hiraditya. jsji added a reviewer: PowerPC. jsji added a project: PowerPC. This patch adds command l

[PATCH] D80294: Add support for vmsumudm

saghir marked an inline comment as done. saghir added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1365 +// Vector Multiply-Sum +def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm, amyk wrote: > Maybe we can put this

[PATCH] D80294: Add support for vmsumudm

saghir added a comment. In D80294#2048049 , @amyk wrote: > I think this overall looks good, but just curious, why was the builtin > support removed? I was hitting some errors with that, so removed it and would add that later on. CHANGES SINCE LAST ACT

[PATCH] D80294: Add support for vmsumudm

saghir updated this revision to Diff 265332. saghir edited the summary of this revision. saghir added a comment. Removing the builtin support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 Files: clang/include/clang/Basic/BuiltinsPPC.def l

[PATCH] D80294: Add support for vmsumudm

saghir updated this revision to Diff 265281. saghir added a comment. Added vec_msum builtin for vmsumudm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80294/new/ https://reviews.llvm.org/D80294 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Headers/altivec.h clang/te

[PATCH] D80294: Add support for vmsumudm

saghir created this revision. saghir added reviewers: power-llvm-team, nemanjai, stefanp, amyk, lei, hfinkel, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch adds support for Vector Multiply-Sum Unsigned Doubleword Modulo in

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

saghir closed this revision. saghir added a comment. Herald added subscribers: sstefan1, yaxunl. Support for 'close' map-type-modifier code generation in clang has been added by patch D65341 . This revision can be closed. Repository: rC Clang CHANGES SINCE L

[PATCH] D59843: [PowerPC] Add support for __dcbf builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rC359517: Add __builtin_dcbf support for PPC (authored by saghir, committed by ). Herald added subscribers: cfe-commits, kristina. Herald added a project: clang. Changed prior to commit: https://reviews.l

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

saghir created this revision. saghir added reviewers: ABataev, kkwli0, Hahnfeld, RaviNarayanaswamy, mikerice, hfinkel, gtbercea. saghir added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. This patch provides codegen support for close map-type-modifier in map clause. A map c

[PATCH] D55719: [OpenMP] parsing and sema support for 'close' map-type-modifier

saghir updated this revision to Diff 178336. saghir added a comment. Made following changes: - added more tests for checking diagnostic error messages. - added initialization of modifiers' location in OMPMapClause. - improved variable names to depict multiple modifiers as opposed to a single mod

[PATCH] D55719: [OpenMP] parsing and sema support for 'close' map-type-modifier

saghir created this revision. saghir added reviewers: ABataev, kkwli0, Hahnfeld, RaviNarayanaswamy, mikerice, hfinkel, gtbercea. saghir added a project: clang. Herald added subscribers: cfe-commits, guansong. A map clause with the close map-type-modifier is a hint to prefer that the variables ar

[PATCH] D54958: [OPENMP] remove redundant ColonExpected flag in ParseOpenMP.cpp - (NFC)

saghir created this revision. saghir added reviewers: ABataev, kkwli0, RaviNarayanaswamy, mikerice, Hahnfeld, hfinkel, gtbercea. saghir added a project: OpenMP. Herald added subscribers: cfe-commits, guansong. In ParseOpenMP.cpp: bool ColonExpected = false; ... ... ... else if (ColonExpected)

[PATCH] D54638: OpenMP: remove redundant MapTypeModifierSpecified flag in ParseOpenMP.cpp

saghir created this revision. saghir added reviewers: cfe-commits, ABataev, kkwli0. saghir added a project: OpenMP. Herald added a subscriber: guansong. In the below statement in ParseOpenMP.cpp: bool IsComma = 1942 (Kind != OMPC_reduction && Kind != OMPC_task_reduction && 1943 Kind != OMPC_in_re