https://github.com/adam-yang created
https://github.com/llvm/llvm-project/pull/123428
```- add clang builtin to Builtins.td
- link builtin in hlsl_intrinsics
- add codegen for spirv intrinsic and two directx intrinsics to retain
signedness information of the operands in C
https://github.com/adam-yang closed
https://github.com/llvm/llvm-project/pull/118580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From 9498523511a53c43b6282500fed2659e12ddd752 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/7] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From f98e5113bc83cae2118552466288a874d5e5d63d Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/7] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From f98e5113bc83cae2118552466288a874d5e5d63d Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/8] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From 9a1ad541ec6e2fbd72bd88727a5910da39a5b840 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/6] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From 9a1ad541ec6e2fbd72bd88727a5910da39a5b840 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/5] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From d435e26eb327b4d6c1e3530586b97372292ce214 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/5] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
@@ -9272,6 +9272,8 @@ def err_typecheck_expect_scalar_or_vector : Error<
"a vector of such type is required">;
def err_typecheck_expect_any_scalar_or_vector : Error<
"invalid operand of type %0 where a scalar or vector is required">;
+def err_typecheck_expect_scalar_or_vect
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From d435e26eb327b4d6c1e3530586b97372292ce214 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/5] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
@@ -1843,6 +1843,23 @@ static bool CheckAnyScalarOrVector(Sema *S, CallExpr
*TheCall,
return false;
}
+static bool CheckNotBoolType(Sema *S, CallExpr *TheCall, unsigned ArgIndex) {
adam-yang wrote:
Addressed both these comments.
https://github.com/llvm/ll
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From d435e26eb327b4d6c1e3530586b97372292ce214 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/4] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From d435e26eb327b4d6c1e3530586b97372292ce214 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/3] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From d435e26eb327b4d6c1e3530586b97372292ce214 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/2] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From aa2c7eda19f3a89112e0f6eb8630cef58d833abb Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/2] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
adam-yang wrote:
Originally based on https://github.com/llvm/llvm-project/pull/112400.
https://github.com/llvm/llvm-project/pull/118580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang ready_for_review
https://github.com/llvm/llvm-project/pull/118580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/118580
>From e97cf4d2158fff06e7a541da73c442a9daadc8f5 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Fri, 18 Oct 2024 10:49:18 -0700
Subject: [PATCH 1/2] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic
-
https://github.com/adam-yang edited
https://github.com/llvm/llvm-project/pull/118580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang edited
https://github.com/llvm/llvm-project/pull/118580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang created
https://github.com/llvm/llvm-project/pull/118580
- add clang builtin to Builtins.td
- link builtin in hlsl_intrinsics
- add codegen for spirv intrinsic and two directx intrinsics to retain
signedness information of the operands in CGBuiltin.cpp
- add s
https://github.com/adam-yang closed
https://github.com/llvm/llvm-project/pull/111883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/111883
>From b7d329a60d6de140df9d7a2484e7a998c3a7b532 Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Thu, 10 Oct 2024 10:20:37 -0700
Subject: [PATCH 1/8] Added the intrinsic to clang
---
clang/include/clang/Basic/B
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/111883
>From b7d329a60d6de140df9d7a2484e7a998c3a7b532 Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Thu, 10 Oct 2024 10:20:37 -0700
Subject: [PATCH 1/7] Added the intrinsic to clang
---
clang/include/clang/Basic/B
https://github.com/adam-yang closed
https://github.com/llvm/llvm-project/pull/113394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -83,12 +83,210 @@ entry:
ret i64 %0
}
-declare half @llvm.dx.clamp.f16(half, half, half)
-declare float @llvm.dx.clamp.f32(float, float, float)
-declare double @llvm.dx.clamp.f64(double, double, double)
-declare i16 @llvm.dx.clamp.i16(i16, i16, i16)
-declare i32 @llvm.dx.
@@ -40,8 +40,9 @@ def int_dx_cast_handle : Intrinsic<[llvm_any_ty],
[llvm_any_ty]>;
def int_dx_all : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty],
[IntrNoMem]>;
def int_dx_any : DefaultAttrsIntrinsic<[llvm_i1_ty], [llvm_any_ty],
[IntrNoMem]>;
-def int_dx_clamp : Defaul
@@ -2559,6 +2559,12 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register
ResVReg,
} break;
case Intrinsic::spv_saturate:
return selectSaturate(ResVReg, ResType, I);
+ case Intrinsic::spv_fclamp:
+return selectExtInst(ResVReg, ResType, I, CL::fclamp, GL::FCla
@@ -0,0 +1,130 @@
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - |
FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o -
-filetype=obj | spirv-val %}
adam-yang wrote:
clamp-vec is now gone. The vec
@@ -18661,14 +18661,30 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned
BuiltinID,
Value *OpMax = EmitScalarExpr(E->getArg(2));
QualType Ty = E->getArg(0)->getType();
-bool IsUnsigned = false;
if (auto *VecTy = Ty->getAs())
Ty = VecTy->getElemen
@@ -2559,6 +2559,12 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register
ResVReg,
} break;
case Intrinsic::spv_saturate:
return selectSaturate(ResVReg, ResType, I);
+ case Intrinsic::spv_fclamp:
+return selectExtInst(ResVReg, ResType, I, CL::fclamp, GL::FCla
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/113394
>From 8cf5032a5580b97c4c4965e577374f627fbe0643 Mon Sep 17 00:00:00 2001
From: Adam Yang <31109344+adam-y...@users.noreply.github.com>
Date: Mon, 14 Oct 2024 16:35:45 -0700
Subject: [PATCH 1/5] Added the intrins
@@ -0,0 +1,130 @@
+; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-unknown %s -o - |
FileCheck %s
+; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o -
-filetype=obj | spirv-val %}
adam-yang wrote:
I'm just following what was do
@@ -1,133 +1,143 @@
// RUN: %clang_cc1 -finclude-default-header -triple
dxil-pc-shadermodel6.3-library %s \
// RUN: -fnative-half-type -emit-llvm -disable-llvm-passes -o - | \
-// RUN: FileCheck %s --check-prefixes=CHECK,NATIVE_HALF
+// RUN: FileCheck %s --check-prefixes=CHE
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/113394
>From 8cf5032a5580b97c4c4965e577374f627fbe0643 Mon Sep 17 00:00:00 2001
From: Adam Yang <31109344+adam-y...@users.noreply.github.com>
Date: Mon, 14 Oct 2024 16:35:45 -0700
Subject: [PATCH 1/6] Added the intrins
https://github.com/adam-yang ready_for_review
https://github.com/llvm/llvm-project/pull/113394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/113394
>From 8cf5032a5580b97c4c4965e577374f627fbe0643 Mon Sep 17 00:00:00 2001
From: Adam Yang <31109344+adam-y...@users.noreply.github.com>
Date: Mon, 14 Oct 2024 16:35:45 -0700
Subject: [PATCH 1/4] Added the intrins
https://github.com/adam-yang created
https://github.com/llvm/llvm-project/pull/113394
Fixes #88052
- Added the following intrinsics:
- `int_spv_uclamp`
- `int_spv_sclamp`
- `int_spv_fclamp`
- Update the clamp.hlsl unit tests to include SPIRV
- Added the SPIRV specific tests
>From 8cf5032
@@ -2018,6 +2018,11 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
return true;
break;
}
+ case Builtin::BI__builtin_hlsl_group_memory_barrier_with_group_sync: {
+if (SemaRef.checkArgCountAtMost(TheCall, 0))
---
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/111883
>From 0f97b92617dcadd78362f24f3ef0719c19f6f3f6 Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Thu, 10 Oct 2024 10:20:37 -0700
Subject: [PATCH 1/6] Added the intrinsic to clang
---
clang/include/clang/Basic/B
@@ -0,0 +1,6 @@
+// RUN: %clang_cc1 -finclude-default-header -triple
dxil-pc-shadermodel6.6-library %s -emit-llvm-only -disable-llvm-passes -verify
-verify-ignore-unexpected
adam-yang wrote:
It's removed now.
https://github.com/llvm/llvm-project/pull/111883
__
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/111883
>From 0f97b92617dcadd78362f24f3ef0719c19f6f3f6 Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Thu, 10 Oct 2024 10:20:37 -0700
Subject: [PATCH 1/5] Added the intrinsic to clang
---
clang/include/clang/Basic/B
@@ -2018,6 +2018,11 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned
BuiltinID, CallExpr *TheCall) {
return true;
break;
}
+ case Builtin::BI__builtin_hlsl_group_memory_barrier_with_group_sync: {
+if (SemaRef.checkArgCountAtMost(TheCall, 0))
---
https://github.com/adam-yang ready_for_review
https://github.com/llvm/llvm-project/pull/111883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang edited
https://github.com/llvm/llvm-project/pull/111883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang edited
https://github.com/llvm/llvm-project/pull/111883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang edited
https://github.com/llvm/llvm-project/pull/111883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang edited
https://github.com/llvm/llvm-project/pull/111883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/111883
>From 0f97b92617dcadd78362f24f3ef0719c19f6f3f6 Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Thu, 10 Oct 2024 10:20:37 -0700
Subject: [PATCH 1/3] Added the intrinsic to clang
---
clang/include/clang/Basic/B
https://github.com/adam-yang edited
https://github.com/llvm/llvm-project/pull/111883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang created
https://github.com/llvm/llvm-project/pull/111883
partially fixes #70103
### Changes
* Implemented `GroupMemoryBarrierWithGroupSync` clang builtin
* Linked `GroupMemoryBarrierWithGroupSync` clang builtin with
`hlsl_intrinsics.h`
* Added sema checks for `Gro
adam-yang wrote:
@farzonl This is also ready for merging if there's no further feedback.
https://github.com/llvm/llvm-project/pull/110802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/110802
>From 30c96a73cc07aa8203f12157475b81eb947951fe Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Wed, 2 Oct 2024 01:21:19 -0700
Subject: [PATCH 1/4] Added radians to clang
---
clang/include/clang/Basic/Builtins
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/110802
>From 08f0b8a10f3e5292fe2f91946392141c9239ec2c Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Wed, 2 Oct 2024 01:21:19 -0700
Subject: [PATCH 1/4] Added radians to clang
---
clang/include/clang/Basic/Builtins
https://github.com/adam-yang ready_for_review
https://github.com/llvm/llvm-project/pull/110802
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/adam-yang updated
https://github.com/llvm/llvm-project/pull/110802
>From be88a591ed220714b21b73e34406bfcdb866ac17 Mon Sep 17 00:00:00 2001
From: Adam Yang
Date: Wed, 2 Oct 2024 01:21:19 -0700
Subject: [PATCH 1/2] Added radians to clang
---
clang/include/clang/Basic/Builtins
https://github.com/adam-yang created
https://github.com/llvm/llvm-project/pull/110802
partially fixes #99151
### Changes
* Implemented `radians` clang builtin
* Linked `radians` clang builtin with `hlsl_intrinsics.h`
* Added sema checks for `radians` to `CheckHLSLBuiltinFunctionCall` in
`SemaC
57 matches
Mail list logo
