[clang] [Clang] Default the warning for chained comparison to an error. (PR #128145)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes Boolean constructs of the form `a < b < c` never express the likely intent of the user and we have been warning on them since clang 19. WG21 is likely to deprecate or make that construct in the future. To gain m

[clang] [Clang] Default the warning for chained comparison to an error. (PR #128145)

2025-02-20 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/128145 Boolean constructs of the form `a < b < c` never express the likely intent of the user and we have been warning on them since clang 19. WG21 is likely to deprecate or make that construct in the future. To gain

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #125648)

2025-02-20 Thread Urvi Rav via cfe-commits
https://github.com/ravurvi20 updated https://github.com/llvm/llvm-project/pull/125648 >From 189dd3cc2230ea5752969f02f119b6ee30e3df69 Mon Sep 17 00:00:00 2001 From: Urvi Rav Date: Tue, 4 Feb 2025 01:35:41 -0600 Subject: [PATCH 1/6] default clause replaced by otherwise clause for metadirective

[clang] [flang] [flang] Align `-x f95[-cpp-input]` language modes with `gfortran` (PR #127986)

2025-02-20 Thread Iñaki Amatria Barral via cfe-commits
https://github.com/inaki-amatria edited https://github.com/llvm/llvm-project/pull/127986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow specifying the language for `.h` files (PR #128122)

2025-02-20 Thread Owen Pan via cfe-commits
owenca wrote: > a bit old school.. > > ``` > /* -*- Mode: C++; -*- */ > /* -*- Mode: C; -*- */ > /* -*- Mode: objc; -*- */ > ``` We support the following now: ```cpp // clang-format off // clang-format off: reason // clang-format on // clang-format on: reason /* clang-format off */ /* clang-for

[clang] [clang][bytecode] Use ExtendingDecl mechanism for primitives as well (PR #128141)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes ... when creating the temporary variables for a MaterializeTemporaryExpr. --- Patch is 24.69 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/128141.diff 3 Files

[clang] [clang][bytecode] Use ExtendingDecl mechanism for primitives as well (PR #128141)

2025-02-20 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/128141 ... when creating the temporary variables for a MaterializeTemporaryExpr. >From c097cff3502bf0fbbbd2a1c8c791f578fd1ce507 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 20 Feb 2025 20:2

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu-dwarf5` running on `doug-worker-1b` while building `clang` at step 2 "checkout". Full details are available at: https://lab.llvm.org/buildbot/#/builders/163/builds/13886 Here is the relevant p

[clang] [llvm] [AMDGPU] Add builtins for wave reduction intrinsics (PR #127013)

2025-02-20 Thread via cfe-commits
@@ -346,6 +346,24 @@ BUILTIN(__builtin_amdgcn_endpgm, "v", "nr") BUILTIN(__builtin_amdgcn_get_fpenv, "WUi", "n") BUILTIN(__builtin_amdgcn_set_fpenv, "vWUi", "n") +//===--===// + +// Wave Reduction builtins. +

[clang] [llvm] [AMDGPU] Add builtins for wave reduction intrinsics (PR #127013)

2025-02-20 Thread via cfe-commits
@@ -346,6 +346,24 @@ BUILTIN(__builtin_amdgcn_endpgm, "v", "nr") BUILTIN(__builtin_amdgcn_get_fpenv, "WUi", "n") BUILTIN(__builtin_amdgcn_set_fpenv, "vWUi", "n") +//===--===// + +// Wave Reduction builtins. +

[clang] [clang-format] Allow specifying the language for `.h` files (PR #128122)

2025-02-20 Thread via cfe-commits
mydeveloperday wrote: a bit old school.. ``` /* -*- Mode: C++; -*- */ /* -*- Mode: C; -*- */ /* -*- Mode: objc; -*- */ ``` https://github.com/llvm/llvm-project/pull/128122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang-format] Allow specifying the language for `.h` files (PR #128122)

2025-02-20 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. I think this should help, I wonder if there is a equivalent of this (but for C/ObjC) that we can support ``` # -*-Mode: Makefile;-*- ``` https://github.com/llvm/llvm-project/pull/128122 _

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-20 Thread Katya Romanova via cfe-commits
romanova-ekaterina wrote: > I'm fine with DTLTO as a shorthand for "integrated distributed ThinLTO". Great! I'm glad that you support this acronim too. :) > BTW thanks for sending the LLVM patch, I will review that tonight or more > likely tomorrow. Teresa, when reviewing, could you please fo

[clang] [Clang] Implement the core language parts of P2786 - Trivial relocation (PR #127636)

2025-02-20 Thread Younan Zhang via cfe-commits
@@ -757,7 +757,7 @@ static void InitializeCPlusPlusFeatureTestMacros(const LangOptions &LangOpts, Builder.defineMacro("__cpp_explicit_this_parameter", "202110L"); } - // We provide those C++23 features as extensions in earlier language modes, so + // We provide those

[clang] [Clang] Implement the core language parts of P2786 - Trivial relocation (PR #127636)

2025-02-20 Thread Younan Zhang via cfe-commits
@@ -2862,6 +2862,30 @@ bool QualType::isTriviallyRelocatableType(const ASTContext &Context) const { } } +bool QualType::isCppTriviallyRelocatableType(const ASTContext &Context) const { + QualType BaseElementType = Context.getBaseElementType(*this); + if (BaseElementType->

[clang] [Clang] Implement the core language parts of P2786 - Trivial relocation (PR #127636)

2025-02-20 Thread Younan Zhang via cfe-commits
@@ -12427,6 +12427,11 @@ def err_builtin_invalid_arg_type: Error < "an 'int'|" "a vector of floating points}1 (was %2)">; +def err_builtin_trivially_relocate_invalid_arg_type: Error < + "first%select{||| and second}0 argument%select{|||s}0 to " zyn0217 wr

[clang] [Clang] Implement the core language parts of P2786 - Trivial relocation (PR #127636)

2025-02-20 Thread Younan Zhang via cfe-commits
@@ -7258,6 +7261,217 @@ void Sema::CheckCompletedCXXClass(Scope *S, CXXRecordDecl *Record) { } } +static bool hasSuitableConstructorForReplaceability(CXXRecordDecl *D, +bool Implicit) { + assert(D->hasDefinition() && !D->

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/128106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fd5d1cb - [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (#128106)

2025-02-20 Thread via cfe-commits
Author: Nathan Ridge Date: 2025-02-21T00:45:51-05:00 New Revision: fd5d1cbb75e4278d9074ff105efd3ab48f778b4b URL: https://github.com/llvm/llvm-project/commit/fd5d1cbb75e4278d9074ff105efd3ab48f778b4b DIFF: https://github.com/llvm/llvm-project/commit/fd5d1cbb75e4278d9074ff105efd3ab48f778b4b.diff

[clang] Add clang atomic control options and attribute (PR #114841)

2025-02-20 Thread Yaxun Liu via cfe-commits
@@ -313,6 +313,8 @@ EXTENSION(datasizeof, LangOpts.CPlusPlus) FEATURE(cxx_abi_relative_vtable, LangOpts.CPlusPlus && LangOpts.RelativeCXXABIVTables) +FEATURE(atomic_attributes, true) yxsamliu wrote: will change https://github.com/llvm/llvm-project/pull/114

[clang] [Clang] Implement CWG2918 'Consideration of constraints for address of overloaded function' (PR #127773)

2025-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/127773 >From 2d9c248c70b6d24f277982a32f36e2ef1bde2829 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 19 Feb 2025 17:13:56 +0800 Subject: [PATCH 1/4] [Clang] Implement CWG2918 'Consideration of constraints for

[clang] [Clang] Implement CWG2918 'Consideration of constraints for address of overloaded function' (PR #127773)

2025-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/127773 >From 2d9c248c70b6d24f277982a32f36e2ef1bde2829 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 19 Feb 2025 17:13:56 +0800 Subject: [PATCH 1/3] [Clang] Implement CWG2918 'Consideration of constraints for

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-02-20 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,49 @@ +.. title:: clang-tidy - readability-ambiguous-smartptr-reset-call + +readability-ambiguous-smartptr-reset-call += + +Finds potentially erroneous calls to ``reset`` method on smart pointers when +the pointee type also has a

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-02-20 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/121291 >From 42e03bb9cc9bd815476b0a3f06ac5f58826e3708 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Fri, 31 Jan 2025 19:29:05 +0300 Subject: [PATCH 1/6] [clang-tidy] add new check bugprone-reset-ambiguous-call

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/128106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add clang atomic control options and attribute (PR #114841)

2025-02-20 Thread Yaxun Liu via cfe-commits
@@ -5400,6 +5400,151 @@ third argument, can only occur at file scope. a = b[i] * c[i] + e; } +Extensions for controlling atomic code generation += + +The ``[[clang::atomic]]`` statement attribute enables users to control ho

[clang] [Clang][CodeGen] Bail out on constexpr unknown values in ConstantEmitter (PR #127525)

2025-02-20 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/127525 >From d931667e3b7e18f8ba6f054405ffc5fe2fac36b4 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Tue, 18 Feb 2025 01:26:26 +0800 Subject: [PATCH 1/3] [Clang][CodeGen] Bail out on constexpr unknown values in Co

[clang] [clang-format] Allow specifying the language for `.h` files (PR #128122)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Closes #128119 --- Full diff: https://github.com/llvm/llvm-project/pull/128122.diff 5 Files Affected: - (modified) clang/docs/ClangFormatStyleOptions.rst (+7-1) - (modified) clang/docs/ReleaseNotes.rst

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks, this is a nice improvement. not: I think it'd be better to say NFC in the PR title. https://github.com/llvm/llvm-project/pull/128106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/128106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow specifying the language for `.h` files (PR #128122)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Owen Pan (owenca) Changes Closes #128119 --- Full diff: https://github.com/llvm/llvm-project/pull/128122.diff 5 Files Affected: - (modified) clang/docs/ClangFormatStyleOptions.rst (+7-1) - (modified) clang/docs/ReleaseNotes.rst (+3) -

[clang] [clang-format] Allow specifying the language for `.h` files (PR #128122)

2025-02-20 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/128122 Closes #128119 >From 507c54acac3e73826f63691c901ceba9c569869f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 20 Feb 2025 20:02:44 -0800 Subject: [PATCH] [clang-format] Allow specifying the language for `.h`

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Ridge (HighCommander4) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/128106.diff 1 Files Affected: - (modified) clang/lib/Index/IndexTypeSourceInfo.cpp (+3-21) ``diff diff --git a/clang/lib/Index/In

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 ready_for_review https://github.com/llvm/llvm-project/pull/128106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-20 Thread Teresa Johnson via cfe-commits
teresajohnson wrote: > > I'm fine with DTLTO as a shorthand for "integrated distributed ThinLTO". > > Great! I'm glad that you support this acronim too. :) > > > BTW thanks for sending the LLVM patch, I will review that tonight or more > > likely tomorrow. > > Teresa, when reviewing, could you

[clang] [Clang][CodeGen] Bail out on constexpr unknown values in ConstantEmitter (PR #127525)

2025-02-20 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: > Does it even make sense for evaluateValue to return a constexpr-unknown > value? If I'm following correctly, we can't actually do anything useful with > such a result: we don't actually know what the value is. It would make things > simpler if we kept such APValues as an inter

[clang] Revert "[HLSL] Implement default constant buffer `$Globals`" (PR #128112)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/13381 Here is the r

[clang] [clang-format] Fix a bug in BCIS_AfterColon and `ColumnLimit: 0` (PR #127964)

2025-02-20 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/127964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 204dcaf - [clang-format] Fix a bug in BCIS_AfterColon and `ColumnLimit: 0` (#127964)

2025-02-20 Thread via cfe-commits
Author: Owen Pan Date: 2025-02-20T19:06:51-08:00 New Revision: 204dcafec0ecf0db81d420d2de57b02ada6b09ec URL: https://github.com/llvm/llvm-project/commit/204dcafec0ecf0db81d420d2de57b02ada6b09ec DIFF: https://github.com/llvm/llvm-project/commit/204dcafec0ecf0db81d420d2de57b02ada6b09ec.diff LOG:

[clang] Revert "[HLSL] Implement default constant buffer `$Globals`" (PR #128112)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win` running on `as-builder-10` while building `clang` at step 17 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/197/builds/2288 Here is the relevant piece o

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-20 Thread Katya Romanova via cfe-commits
romanova-ekaterina wrote: > > I don't have a strong opinion on this but I have basically the same > > concerns with completely opposite conclusions. To me, the distributed > > thinLTO makes you think there is a distributed full LTO, while just call it > > distributed LTO will eliminate that co

[clang] Revert "[HLSL] Implement default constant buffer `$Globals`" (PR #128112)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/11795 Here is the relevant piece of the build lo

[clang] [HLSL] Implement default constant buffer `$Globals` (PR #125807)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot7` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/5528 Here is the releva

[clang] 24c06a1 - [C++20] [Modules] handling selectAny attribute for vardecl

2025-02-20 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2025-02-21T10:48:30+08:00 New Revision: 24c06a19be7bcf28b37e5eabbe65df95a2c0265a URL: https://github.com/llvm/llvm-project/commit/24c06a19be7bcf28b37e5eabbe65df95a2c0265a DIFF: https://github.com/llvm/llvm-project/commit/24c06a19be7bcf28b37e5eabbe65df95a2c0265a.diff LO

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-20 Thread via cfe-commits
bd1976bris wrote: > I don't have a strong opinion on this but I have basically the same concerns > with completely opposite conclusions. To me, the distributed thinLTO makes > you think there is a distributed full LTO, while just call it distributed LTO > will eliminate that confusion. Distrib

[clang] [llvm] [Coroutines] Mark parameter allocas with coro.outside.frame metadata (PR #127653)

2025-02-20 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > Adding metadata to an instruction should never be required for correctness > > I figured the existing use and the fact that it only needs to survive until > CoroSplit made it good enough. But you're right, we should do better. > > I do think we need an explicit way to tel

[clang] [HLSL] Implement default constant buffer `$Globals` (PR #125807)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot11` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/7360 Here is the rel

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/128106 >From 84fac9adf5ab366c85eac3a3abd4e52e0d3532d0 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 20 Feb 2025 20:44:52 -0500 Subject: [PATCH] [clang][Index] Use HeuristicResolver in IndexTypeSourceInf

[clang] [clang] Improve module out of date error message (PR #128103)

2025-02-20 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: would you like to add a test? https://github.com/llvm/llvm-project/pull/128103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++][ranges] P2542R8: Implement `views::concat` (PR #120920)

2025-02-20 Thread A. Jiang via cfe-commits
@@ -0,0 +1,646 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [clang][Index] Use HeuristicResolver in IndexTypeSourceInfo as well (PR #128106)

2025-02-20 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/128106 None >From 10edf87574f5473da01bd985cec4c7810f57c516 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 20 Feb 2025 20:44:52 -0500 Subject: [PATCH] [clang][Index] Use HeuristicResolver in IndexTypeSou

[clang] [WebAssembly] Generate invokes with llvm.wasm.(re)throw (PR #128105)

2025-02-20 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. https://github.com/llvm/llvm-project/pull/128105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Fix local submodule visibility of macros from transitive import (PR #122955)

2025-02-20 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. https://github.com/llvm/llvm-project/pull/122955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Feat] Allow Finding across only parts of an AST. (PR #127423)

2025-02-20 Thread via cfe-commits
matts1 wrote: > I'm not a modules or matcher expert, but this doesn't match my (perhaps > uninformed) understanding. I thought that when we import a module, it _is_ > part of our TU, similarly to when we include a header. You are correct. I phrased it very poorly. I'll reclarify - if we have a

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-02-20 Thread Denis Mikhailov via cfe-commits
@@ -0,0 +1,131 @@ +//===--- AmbiguousSmartptrResetCallCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-02-20 Thread Denis Mikhailov via cfe-commits
https://github.com/denzor200 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/121291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-02-20 Thread Denis Mikhailov via cfe-commits
@@ -0,0 +1,48 @@ +.. title:: clang-tidy - readability-ambiguous-smartptr-reset-call + +readability-ambiguous-smartptr-reset-call += + +Finds potentially erroneous calls to ``reset`` method on smart pointers when +the pointee type also has a

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Valentin Clement バレンタイン クレメン via cfe-commits
@@ -2958,6 +2958,8 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; +def emit_cir_mlir : Flag<["-"],

[clang] [Fix] Speedup -Wunsafe-buffer-usage when using clang modules. (PR #127161)

2025-02-20 Thread via cfe-commits
https://github.com/matts1 updated https://github.com/llvm/llvm-project/pull/127161 >From 46dc2732948e2776909d2ec752a235f22ac471f3 Mon Sep 17 00:00:00 2001 From: Matt Stark Date: Fri, 14 Feb 2025 14:14:03 +1100 Subject: [PATCH] [Fix] Speedup -Wunsafe-buffer-usage when using clang modules. See h

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-20 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt created https://github.com/llvm/llvm-project/pull/128086 Fixes #119641 Update SemaHLSL to correctly calculate the alignment barrier for scalars that are not 4 bytes wide >From bebfc20fac6b27d02bca9af328d0568018672c71 Mon Sep 17 00:00:00 2001 From: Ashley Coleman Da

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ashley Coleman (V-FEXrt) Changes Fixes #119641 Update SemaHLSL to correctly calculate the alignment barrier for scalars that are not 4 bytes wide --- Full diff: https://github.com/llvm/llvm-project/pull/128086.diff 2 Files Affected: -

[clang] [HLSL][Sema] Fix Struct Size Calculation containing 16/32 bit scalars (PR #128086)

2025-02-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Ashley Coleman (V-FEXrt) Changes Fixes #119641 Update SemaHLSL to correctly calculate the alignment barrier for scalars that are not 4 bytes wide --- Full diff: https://github.com/llvm/llvm-project/pull/128086.diff 2 Files Affected: -

[clang] [llvm] [Coroutines] Mark parameter allocas with coro.outside.frame metadata (PR #127653)

2025-02-20 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: In the issue (#127499) you pointed out that this issue applies to the MSVC ABI where all parameters are destroyed in the callee. Is it reasonable to construct the analogous test case in that environment? I tried to do this locally, but can't for unrelated buil

[clang] [Clang] emit -Wunused-variable warning for unused structured bindings without the [[maybe_unused]] attribute (PR #127061)

2025-02-20 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/127061 >From a76ee008bdb87655da465e21d09c840edecc2b1b Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Thu, 13 Feb 2025 15:24:09 +0200 Subject: [PATCH 1/2] [Clang] emit -Wunused-variable warning for unused structur

[clang] [libc] [Clang] Fix cross-lane scan when given divergent lanes (PR #127703)

2025-02-20 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#128085 https://github.com/llvm/llvm-project/pull/127703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [Clang] Fix cross-lane scan when given divergent lanes (PR #127703)

2025-02-20 Thread Joseph Huber via cfe-commits
jhuber6 wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/6cc7ca084a5bbb7ccf606cab12065604453dde59 https://github.com/llvm/llvm-project/pull/127703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

2025-02-20 Thread Michael Spencer via cfe-commits
@@ -3157,25 +2140,18 @@ bool ModuleMap::parseModuleMapFile(FileEntryRef File, bool IsSystem, assert((!Offset || *Offset <= Buffer->getBufferSize()) && "invalid buffer offset"); - // Parse this module map file. - Lexer L(SourceMgr.getLocForStartOfFile(ID), MMapLan

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Valentin Clement バレンタイン クレメン via cfe-commits
@@ -2958,6 +2958,8 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; +def emit_cir_mlir : Flag<["-"],

[clang] [NFC][hlsl][Sema] Simplify CBuffer Legacy Size Calculation Control Flow (PR #127921)

2025-02-20 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-windows` running on `premerge-windows-1` while building `clang` at step 8 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/7475 Here

[clang] [CodeGen] Ensure relative vtables use llvm.type.checked.load.relative (PR #126785)

2025-02-20 Thread via cfe-commits
https://github.com/PiJoules updated https://github.com/llvm/llvm-project/pull/126785 >From 07c7c069a57ec78e64df711cb17d5c873d3ad8cd Mon Sep 17 00:00:00 2001 From: Leonard Chan Date: Tue, 11 Feb 2025 11:31:17 -0800 Subject: [PATCH] [CodeGen] Ensure relative vtables use llvm.type.checked.load.re

[clang] [test] Remove `-emit-llvm` from the `and-errors.hlsl` test to avoid writing to a potentially write-protected directory (PR #128047)

2025-02-20 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/128047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WIP][clang]: Implement a conditional lifetimebound_if builtin. (PR #125520)

2025-02-20 Thread Haojian Wu via cfe-commits
hokein wrote: It feels like the current direction & discussion is expanding into a broader problem space beyond the specific issue this PR aims to address. We have two major problems which seem to be orthogonal: 1. **avoiding code duplication** – specifically, reducing the number of function

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Andy Kaylor via cfe-commits
@@ -2958,6 +2958,8 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; +def emit_cir_mlir : Flag<["-"],

[clang] [profile] runtime counter relocation is needed on windows-msvc targets (PR #127858)

2025-02-20 Thread Wael Yehia via cfe-commits
https://github.com/w2yehia edited https://github.com/llvm/llvm-project/pull/127858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [test] Remove `-emit-llvm` from the `and-errors.hlsl` test to avoid writing to a potentially write-protected directory (PR #128047)

2025-02-20 Thread Sarah Spall via cfe-commits
https://github.com/spall approved this pull request. https://github.com/llvm/llvm-project/pull/128047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CaptureTracking][FunctionAttrs] Add support for CaptureInfo (PR #125880)

2025-02-20 Thread Hans Wennborg via cfe-commits
zmodem wrote: > @zmodem Could you please check whether the clang build on windows works with > the patch at #128020? I'm afraid I get the same crashes with that one. https://github.com/llvm/llvm-project/pull/125880 ___ cfe-commits mailing list cfe-co

[clang] [WIP][clang]: Implement a conditional lifetimebound_if builtin. (PR #125520)

2025-02-20 Thread Haojian Wu via cfe-commits
hokein wrote: > It would be nice if you could share some code snippets how exactly this would > be used in practice. Some simple examples from Abseil. When using `lifetime_capture` in the `insert` method, we currently have two overloads: - [one overload](https://github.com/abseil/abseil-cpp

[clang] [WIP][clang]: Implement a conditional lifetimebound_if builtin. (PR #125520)

2025-02-20 Thread Haojian Wu via cfe-commits
hokein wrote: > auto& value = m[std::string_view(std::string())]; // Doesn't get caught This case is supported as well, https://godbolt.org/z/KKsvd8Kx1. https://github.com/llvm/llvm-project/pull/125520 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [MS][clang] Add support for vector deleting destructors (PR #126240)

2025-02-20 Thread Reid Kleckner via cfe-commits
rnk wrote: Thanks for the updates, I think this is almost done. @zmodem , this will probably have some impact on Chrome code size and will probably churn many crash stack traces. I think it's safe to rely on all the existing automated testing, but this is a high-risk change to keep in mind if

[clang] [clang][dataflow] Add test repro for a crash (PR #128065)

2025-02-20 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e7da07c73c179396e21fb729ac14d6b2a1c3152 a7002fb5a61c2f6f3c4df2347b6d5f861bf45f8e --e

[clang] [clang][dataflow] Add test repro for a crash (PR #128065)

2025-02-20 Thread Jan Voung via cfe-commits
https://github.com/jvoung created https://github.com/llvm/llvm-project/pull/128065 An issue with looking up the "this" when a default init of field2 refers to field1. >From a7002fb5a61c2f6f3c4df2347b6d5f861bf45f8e Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Thu, 20 Feb 2025 19:40:16 +

[clang] [CIR] Initial implementation of lowering CIR to MLIR (PR #127835)

2025-02-20 Thread Bruno Cardoso Lopes via cfe-commits
@@ -2958,6 +2958,8 @@ defm clangir : BoolFOption<"clangir", BothFlags<[], [ClangOption, CC1Option], "">>; def emit_cir : Flag<["-"], "emit-cir">, Visibility<[ClangOption, CC1Option]>, Group, HelpText<"Build ASTs and then lower to ClangIR">; +def emit_cir_mlir : Flag<["-"],

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

2025-02-20 Thread Jan Svoboda via cfe-commits
@@ -3157,25 +2140,18 @@ bool ModuleMap::parseModuleMapFile(FileEntryRef File, bool IsSystem, assert((!Offset || *Offset <= Buffer->getBufferSize()) && "invalid buffer offset"); - // Parse this module map file. - Lexer L(SourceMgr.getLocForStartOfFile(ID), MMapLan

[clang] Check for mutability better (PR #127843)

2025-02-20 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem approved this pull request. LGTM with a nit. I'll wait a day before merging in case anyone else wants to review as well. https://github.com/llvm/llvm-project/pull/127843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Check for mutability better (PR #127843)

2025-02-20 Thread Hans Wennborg via cfe-commits
@@ -13440,6 +13440,23 @@ bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated( return true; } +// Determine whether the object seems mutable for the purpose of diagnosing +// possible unique object duplication, i.e. non-const-qualified, and +// not an always-constan

[clang] Check for mutability better (PR #127843)

2025-02-20 Thread Hans Wennborg via cfe-commits
https://github.com/zmodem edited https://github.com/llvm/llvm-project/pull/127843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Update isAuxBuiltinID comment (PR #128038)

2025-02-20 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/128038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Integrated Distributed ThinLTO (DTLTO): Initial support (PR #126654)

2025-02-20 Thread Steven Wu via cfe-commits
cachemeifyoucan wrote: > This is clearer as we are currently only going to distribute the ThinLTO part > and have no plans to distribute the FullLTO part. Making the name more > general could confuse users who might then expect in e.g., a mixed Thin+Full > link that the Full bitcode part would

[clang] [llvm] [RISCV] Assembler support for XRivosVizip (PR #127694)

2025-02-20 Thread Philip Reames via cfe-commits
preames wrote: > > > I am kind of confused now. So the situation here is that RVIOS has > > > already implemented these vendor extensions in cores and RVIOS is also > > > trying to make these extensions official RVI standards, right? > > > > > > You're confusing two things. We (Rivos) have de

[clang] [profile] runtime counter relocation is needed on windows-msvc targets (PR #127858)

2025-02-20 Thread Anh Tuyen Tran via cfe-commits
https://github.com/anhtuyenibm approved this pull request. Thanks for pointing out this reference page. The changes look good to me. https://github.com/llvm/llvm-project/pull/127858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Assembler support for XRivosVizip (PR #127694)

2025-02-20 Thread Philip Reames via cfe-commits
https://github.com/preames updated https://github.com/llvm/llvm-project/pull/127694 >From 81e50773d34f788df750bf6d4a4cd8c727a6b148 Mon Sep 17 00:00:00 2001 From: Philip Reames Date: Wed, 22 Jan 2025 12:54:24 -0800 Subject: [PATCH 1/2] [RISCV] Assembler support for XRivosVizip This implements a

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2025-02-20 Thread Nicolas van Kempen via cfe-commits
@@ -0,0 +1,788 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] cc45365 - [clang][NFC] Update isAuxBuiltinID comment (#128038)

2025-02-20 Thread via cfe-commits
Author: Nick Sarnie Date: 2025-02-20T20:30:54Z New Revision: cc45365ab9065bc9e8ea48744f761b7ac30a5634 URL: https://github.com/llvm/llvm-project/commit/cc45365ab9065bc9e8ea48744f761b7ac30a5634 DIFF: https://github.com/llvm/llvm-project/commit/cc45365ab9065bc9e8ea48744f761b7ac30a5634.diff LOG: [

[clang] [llvm] [RISCV] Assembler support for XRivosVizip (PR #127694)

2025-02-20 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/127694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >