[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

@@ -320,10 +320,11 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") -return "!get" + getUpperName().str() + "()"; - if (type == "TypeSourceInfo *") + StringRef T = type; + if (T == "TypeSourceInf

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/67331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/67331 >From 67e19382fb45fe5e06a5c8de2e7b1434c8b1c68f Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Mon, 25 Sep 2023 15:37:34 +0200 Subject: [PATCH] [clang] Fix pretty-printing assume_aligned attributes Inside `w

[clang] 9f276d4 - [clang][dataflow] Avoid putting an assertion in an `LLVM_DEBUG` block. (#67313)

Author: martinboehme Date: 2023-09-26T08:49:11+02:00 New Revision: 9f276d4ddd0efa2e323d674a35317c253ab66d58 URL: https://github.com/llvm/llvm-project/commit/9f276d4ddd0efa2e323d674a35317c253ab66d58 DIFF: https://github.com/llvm/llvm-project/commit/9f276d4ddd0efa2e323d674a35317c253ab66d58.diff

[clang] [clang][dataflow] Avoid putting an assertion in an `LLVM_DEBUG` block. (PR #67313)

https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/67313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,135 @@ + +#include "clang/Frontend/CodeSnippetHighlighter.h" +#include "clang/Basic/DiagnosticOptions.h" +#include "cla

[clang] [clang][dataflow] Remove declarations from `DeclToLoc` when their lifetime ends. (PR #67300)

https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/67300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 834cb91 - [clang][dataflow] Remove declarations from `DeclToLoc` when their lifetime ends. (#67300)

Author: martinboehme Date: 2023-09-26T08:41:09+02:00 New Revision: 834cb919b3107f9db3efe80483908d31cb84ee7a URL: https://github.com/llvm/llvm-project/commit/834cb919b3107f9db3efe80483908d31cb84ee7a DIFF: https://github.com/llvm/llvm-project/commit/834cb919b3107f9db3efe80483908d31cb84ee7a.diff

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

llvmbot wrote: @llvm/pr-subscribers-clang-format Changes Replaced TT_AttributeParen with TT_AttributeLParen and TT_AttributeRParen. --- Full diff: https://github.com/llvm/llvm-project/pull/67396.diff 4 Files Affected: - (modified) clang/lib/Format/ContinuationIndenter.cpp (+1-1) - (mod

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/67396 >From 3ae647542b80edb47bb2e47e87118be6a1bdbdec Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 25 Sep 2023 23:21:38 -0700 Subject: [PATCH] [clang-format] Split TT_AttributeParen Replaced TT_AttributeParen with

[clang] [clang-format] Split TT_AttributeParen (PR #67396)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/67396 Replaced TT_AttributeParen with TT_AttributeLParen and TT_AttributeRParen. >From 32c071771910693e1ba739db32c0de212352e9d8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 25 Sep 2023 23:21:38 -0700 Subject: [PA

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: On a fast machine, the timings with a Release build of clang are: ``` /root/llvm-project/clang/lib/Sema/SemaExpr.cpp:21870:15: err

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

@@ -3412,13 +3416,23 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddressAIX(SDValue Op, return DAG.getNode(PPCISD::ADD_TLS, dl, PtrVT, TLSReg, VariableOffset); } - // Only Local-Exec, Initial-Exec and General-Dynamic TLS models are currently - // supported models. If

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

https://github.com/orcguru resolved https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

https://github.com/orcguru resolved https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

https://github.com/orcguru resolved https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

https://github.com/orcguru resolved https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

https://github.com/orcguru resolved https://github.com/llvm/llvm-project/pull/66316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

llvmbot wrote: @llvm/pr-subscribers-mlir-presburger Changes A new class, FracMatrix, has been created for rational matrices. It inherits from Matrix with no new data attributes and one new method, `inverse()`. Gaussian elimination is used in the inverse implementation. A basic te

[clang] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

llvmbot wrote: @llvm/pr-subscribers-mlir-presburger Changes A new class, FracMatrix, has been created for rational matrices. It inherits from Matrix with no new data attributes and one new method, `inverse()`. Gaussian elimination is used in the inverse implementation. A basic te

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65918 >From cfedbe3fb2f2f331b3f9ee1f4f3e2fcd348797e2 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 11 Sep 2023 09:15:41 +0800 Subject: [PATCH 1/6] [Sema] add cast from IncompleteArrayType to ConstantArray

[clang] [llvm][tblgen] Add `Source Filename` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: https://github.com/sunshaoce closed https://github.com/llvm/llvm-project/pull/65744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] b0e28eb - [llvm][tblgen] Add `Source Filename` for `emitSourceFileHeader` (#65744)

Author: Shao-Ce SUN Date: 2023-09-26T13:40:56+08:00 New Revision: b0e28eb832710964067a17d845de15ada2da2b9c URL: https://github.com/llvm/llvm-project/commit/b0e28eb832710964067a17d845de15ada2da2b9c DIFF: https://github.com/llvm/llvm-project/commit/b0e28eb832710964067a17d845de15ada2da2b9c.diff L

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang][Interp] Three-way comparisons (PR #65901)

tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/65901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 38dd67c - [clang-format][NFC] Minor cleanup of the parser and annotator

Author: Owen Pan Date: 2023-09-25T22:20:02-07:00 New Revision: 38dd67c8b3dbce4311e32a68d1100bd9f850c43e URL: https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e DIFF: https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e.diff LOG:

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: > > > I have concerns about Lexing twice every single file for which we display > > > a warning. > > > > > > Sure. Because of p

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

vvereschaka wrote: @sam-mccall , your 7ca8c21af36acb117529e797b3d36e85a286ca47 commit breaks `Clang-Unit :: Driver/./ClangDriverTests.exe/ToolChainTest/VFSGnuLibcxxPathNoSysroot` (`Clang-Unit::67`) test on the windows toolchain builders * https://lab.llvm.org/buildbot/#/builders/119/builds/1523

[clang-tools-extra] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

efriedma-quic wrote: I guess this ends up producing a CK_NoOp CastExpr? That's probably okay, but can we amend the documentation for CK_NoOp to give this as an example? https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-

[clang] [Sema] add cast from IncompleteArrayType to ConstantArrayType in TryReferenceListInitialization (PR #65918)

efriedma-quic wrote: I guess this ends up producing a CK_NoOp CastExpr? That's probably okay, but can we amend the documentation for CK_NoOp to give this as an example? https://github.com/llvm/llvm-project/pull/65918 ___ cfe-commits mailing list cfe-

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

llvmbot wrote: @llvm/pr-subscribers-libunwind Changes Avoid type warning of debug printf since VE uses 64 bits SjLj. --- Full diff: https://github.com/llvm/llvm-project/pull/67390.diff 1 Files Affected: - (modified) libunwind/src/Unwind-sjlj.c (+12-6) ``diff diff --git a/libu

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

https://github.com/kaz7 created https://github.com/llvm/llvm-project/pull/67390 Avoid type warning of debug printf since VE uses 64 bits SjLj. >From 18e3568db4a3a11c794f077e9effd0a713dbd2dc Mon Sep 17 00:00:00 2001 From: "Kazushi (Jam) Marukawa" Date: Sun, 24 Sep 2023 08:08:24 +0200 Subject: [P

[clang] [llvm][tblgen] Add `Source Filename` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: https://github.com/sunshaoce updated https://github.com/llvm/llvm-project/pull/65744 >From 8fd7007fa437a0eefb66015861f76f65095c31bc Mon Sep 17 00:00:00 2001 From: Shao-Ce SUN Date: Sat, 23 Sep 2023 11:38:33 +0800 Subject: [PATC

[clang] [llvm][tblgen] Add `Source Filename` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: https://github.com/sunshaoce edited https://github.com/llvm/llvm-project/pull/65744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] c84f9f9 - Reformat

Author: NAKAMURA Takumi Date: 2023-09-26T12:29:21+09:00 New Revision: c84f9f9a81e496acbef0855cbbb0858c817576dc URL: https://github.com/llvm/llvm-project/commit/c84f9f9a81e496acbef0855cbbb0858c817576dc DIFF: https://github.com/llvm/llvm-project/commit/c84f9f9a81e496acbef0855cbbb0858c817576dc.dif

[clang] [llvm][tblgen] Add `SourcePath` for `emitSourceFileHeader` (PR #65744)

" + sys::path::filename(Record.getInputFilename())," In-Reply-To: https://github.com/chapuni approved this pull request. Looks good. At the moment, this doesn't emit `path` but `file name`. Since I'll push reformatting, could you rebase, squash, and retitle before pushing? I guess we could e

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 557346. chaitanyav added a comment. Rebase with upstream and update code as per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/Releas

[clang] [RISCV] Add MC layer support for Zicfiss. (PR #66043)

@@ -165,6 +167,10 @@ def SP : GPRRegisterClass<(add X2)>; def SR07 : GPRRegisterClass<(add (sequence "X%u", 8, 9), (sequence "X%u", 18, 23))>; +def GPRRA : RegisterClass<"RISCV", [XLenVT], 32, (add X1, X5)> { tclin914 wrote: I

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

enh accepted this revision. enh added a comment. yeah, lgtm from the Android side too, unless rprichard has more comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158641/new/ https://reviews.llvm.org/D158641 _

[clang] [PowerPC] Support local-dynamic TLS relocation on AIX (PR #66316)

@@ -116,6 +116,10 @@ std::pair PPCXCOFFObjectWriter::getRelocTypeAndSignSize( return {XCOFF::RelocationType::R_TLS_IE, SignAndSizeForFKData}; case MCSymbolRefExpr::VK_PPC_AIX_TLSLE: return {XCOFF::RelocationType::R_TLS_LE, SignAndSizeForFKData}; +case MCSym

[libunwind] [runtimes] Remove explicit -isysroot from the testing configurations on macOS (PR #66265)

petrhosek wrote: > How do you build on Apple platforms then? Don't you need access to a SDK? I'm > a bit confused about what you're doing -- do you need to use the native > platform SDK when you're building Fuchsia? What SDK are you passing as > `--sysroot` when testing libc++? We use `-isysr

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

@@ -171,3 +171,12 @@ namespace CtorTemplateBeatsNonTemplateConversionFn { Foo f(Derived d) { return d; } // expected-error {{invokes a deleted function}} Foo g(Derived d) { return Foo(d); } // ok, calls constructor } + +namespace GH65522 { +template +class B3 : A3 { + tem

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

@@ -171,3 +171,12 @@ namespace CtorTemplateBeatsNonTemplateConversionFn { Foo f(Derived d) { return d; } // expected-error {{invokes a deleted function}} Foo g(Derived d) { return Foo(d); } // ok, calls constructor } + +namespace GH65522 { +template +class B3 : A3 { + tem

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

erichkeane wrote: > So it looks like this breaks the ast-dump-attr.cpp test, so that needs fixing. > > Also, there is quite a bit of changes happening around the SemaDeclAttr.cpp > changes by @AaronBallman, so the two need to be merged in some way. "Merged" could be: 1-rebased on the other, bu

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -2352,26 +2352,37 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } +template +static void handleCtorDtorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + uint32_t priority = Attr::Defaul

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -5661,10 +5662,20 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD, setNonAliasAttributes(GD, Fn); SetLLVMFunctionAttributesForDefinition(D, Fn); - if (const ConstructorAttr *CA = D->getAttr()) -AddGlobalCtor(Fn, CA->getPriority()); + auto getPri

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -1422,9 +1424,11 @@ def Deprecated : InheritableAttr { def Destructor : InheritableAttr { let Spellings = [GCC<"destructor">]; - let Args = [DefaultIntArgument<"Priority", 65535>]; + let Args = [ExprArgument<"Priority", 1>]; let Subjects = SubjectList<[Function]>;

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

https://github.com/erichkeane commented: So it looks like this breaks the ast-dump-attr.cpp test, so that needs fixing. Also, there is quite a bit of changes happening around the SemaDeclAttr.cpp changes by @AaronBallman, so the two need to be merged in some way. https://github.com/llvm/llvm-p

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -10,3 +13,14 @@ struct Foo { bar(); } }; + +template erichkeane wrote: Please write a test where the argument is NTTP dependent on another template argument. https://github.com/llvm/llvm-project/pull/67376 __

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

@@ -1156,9 +1156,11 @@ def ConstInit : InheritableAttr { def Constructor : InheritableAttr { let Spellings = [GCC<"constructor">]; - let Args = [DefaultIntArgument<"Priority", 65535>]; + let Args = [ExprArgument<"Priority", 1>]; let Subjects = SubjectList<[Function]>;

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/67376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Move assertion check before checking Output.isFilename (PR #67210)

https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/67210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8a4b9e9 - [Driver] Move assertion check before checking Output.isFilename (#67210)

Author: Brad Smith Date: 2023-09-25T20:19:25-04:00 New Revision: 8a4b9e9965dfdc7758153341561ff1e457a5346c URL: https://github.com/llvm/llvm-project/commit/8a4b9e9965dfdc7758153341561ff1e457a5346c DIFF: https://github.com/llvm/llvm-project/commit/8a4b9e9965dfdc7758153341561ff1e457a5346c.diff LO

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -2352,26 +2352,61 @@ static void handleUnusedAttr(Sema &S, Decl *D, const ParsedAttr &AL) { D->addAttr(::new (S.Context) UnusedAttr(S.Context, AL)); } -static void handleConstructorAttr(Sema &S, Decl *D, const ParsedAttr &AL) { - uint32_t priority = ConstructorAttr::Def

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

@@ -171,6 +171,11 @@ Attribute Changes in Clang automatic diagnostic to use parameters of types that the format style supports but that are never the result of default argument promotion, such as ``float``. (`#59824: `_)

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

@@ -1798,11 +1798,24 @@ def ArmMveStrictPolymorphism : TypeAttr, TargetSpecificAttr { let Documentation = [ArmMveStrictPolymorphismDocs]; } -def NoUniqueAddress : InheritableAttr, TargetSpecificAttr { - let Spellings = [CXX11<"", "no_unique_address", 201803>]; +def NoUniq

[clang] [Driver] Move assertion check before checking Output.isFilename (PR #67210)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff feb7b1914d513c709b9e024dfed709bb889cc853 e2201a10fe76be3de8efd0faca0f381f504b08d3 --

[clang] [clang] Predefined macros for float128 support (PR #67196)

@@ -1076,6 +1076,8 @@ static void InitializePredefinedMacros(const TargetInfo &TI, DefineFloatMacros(Builder, "FLT", &TI.getFloatFormat(), "F"); DefineFloatMacros(Builder, "DBL", &TI.getDoubleFormat(), ""); DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This patch adopts `FileEntryRef` in the `HeaderFileInfo`-writing part of `ASTWriter`. First, this patch removes the loop over `FileManager::VirtualFileEntries`. It's redundant, since all virtual file entries have a non-virtual/real counte

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/67383 This patch adopts `FileEntryRef` in the `HeaderFileInfo`-writing part of `ASTWriter`. First, this patch removes the loop over `FileManager::VirtualFileEntries`. It's redundant, since all virtual file entri

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

https://github.com/bwendling updated https://github.com/llvm/llvm-project/pull/67193 >From 6db37f7f76347a7821d9a95c0fdac4e250df2e78 Mon Sep 17 00:00:00 2001 From: Bill Wendling Date: Fri, 22 Sep 2023 12:35:09 -0700 Subject: [PATCH 1/2] [CodeGen] Avoid potential sideeffects from XOR XOR may cha

[clang] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-analysis]Fix false positive in mutation check when using pointer to member function (PR #66846)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/66846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] feb7b19 - [clang-analysis]Fix false positive in mutation check when using pointer to member function (#66846)

Author: Congcong Cai Date: 2023-09-26T07:40:15+08:00 New Revision: feb7b1914d513c709b9e024dfed709bb889cc853 URL: https://github.com/llvm/llvm-project/commit/feb7b1914d513c709b9e024dfed709bb889cc853 DIFF: https://github.com/llvm/llvm-project/commit/feb7b1914d513c709b9e024dfed709bb889cc853.diff

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. In D147655#4650666 , @rjmccall wrote: > Yeah, the more I think about this, the more I think that while (1) Apple > should upstream its use of an older default, regardless (2) the existence of > any targets at all with an older de

[clang] 7421dd5 - Don't specify the same flag twice.

Author: Richard Smith Date: 2023-09-25T16:38:17-07:00 New Revision: 7421dd55a16f18919a568499e4c0888ed3a5e8b5 URL: https://github.com/llvm/llvm-project/commit/7421dd55a16f18919a568499e4c0888ed3a5e8b5 DIFF: https://github.com/llvm/llvm-project/commit/7421dd55a16f18919a568499e4c0888ed3a5e8b5.diff

[clang] 9408500 - Add -fclang-abi-compat=latest to a bunch of tests for manglings that changed since v17.

Author: Richard Smith Date: 2023-09-25T16:34:38-07:00 New Revision: 940850066290a484144db80f09e6c19709f5fe49 URL: https://github.com/llvm/llvm-project/commit/940850066290a484144db80f09e6c19709f5fe49 DIFF: https://github.com/llvm/llvm-project/commit/940850066290a484144db80f09e6c19709f5fe49.diff

[clang] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c74398649f28ab78c74bacfe82e69224377008e7 69cce307842ab6bfbca10f44d3826623379a0385 --

[clang-tools-extra] [MLIR][Presburger] Define matrix inverse for rational matrices (PR #67382)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c74398649f28ab78c74bacfe82e69224377008e7 69cce307842ab6bfbca10f44d3826623379a0385 --

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

@@ -171,3 +171,12 @@ namespace CtorTemplateBeatsNonTemplateConversionFn { Foo f(Derived d) { return d; } // expected-error {{invokes a deleted function}} Foo g(Derived d) { return Foo(d); } // ok, calls constructor } + +namespace GH65522 { +template +class B3 : A3 { + tem

[clang] c743986 - Enter the function parameter mangling scope for a function encoding

Author: Richard Smith Date: 2023-09-25T16:19:02-07:00 New Revision: c74398649f28ab78c74bacfe82e69224377008e7 URL: https://github.com/llvm/llvm-project/commit/c74398649f28ab78c74bacfe82e69224377008e7 DIFF: https://github.com/llvm/llvm-project/commit/c74398649f28ab78c74bacfe82e69224377008e7.diff

[PATCH] D158296: [clang] Diagnose overly complex Record in __builtin_dump_struct

dblaikie added a comment. @rsmith ping on this thread - wondering what you'd prefer the direction be here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158296/new/ https://reviews.llvm.org/D158296 ___ cf

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

@@ -171,3 +171,12 @@ namespace CtorTemplateBeatsNonTemplateConversionFn { Foo f(Derived d) { return d; } // expected-error {{invokes a deleted function}} Foo g(Derived d) { return Foo(d); } // ok, calls constructor } + +namespace GH65522 { +template +class B3 : A3 { + tem

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

@@ -5414,6 +5414,8 @@ def note_constraint_normalization_here : Note< def note_parameter_mapping_substitution_here : Note< "while substituting into concept arguments here; substitution failures not " "allowed in concept arguments">; +def note_building_deduction_guide_here :

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. The Clang Driver/CodeGen and compiler-rt changes look good to me. Of course please wait for an Android reviewer :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Right now, `-Wformat` for a scoped enum will suggest a cast based on the format specifier being used. This can lead to incorrect results, e.g. attempting to format a scoped enum with `%s` would suggest casting to `char *` instead of fixing t

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/67378 Right now, `-Wformat` for a scoped enum will suggest a cast based on the format specifier being used. This can lead to incorrect results, e.g. attempting to format a scoped enum with `%s` would suggest casting to

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

efriedma updated this revision to Diff 557335. efriedma added a comment. Revised so guest exit thunks actually work. Thanks for the tip about the symbols; I forgot to look at the object file in addition to the generated assembly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

ilinpv added a comment. The patch tested on NDK r26 bulding simple Function Multi Versioning project and running on Android API 25,29,30,33 - works fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158641/new/ https://reviews.llvm.org/D158641 _

[PATCH] D158641: [AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.

ilinpv updated this revision to Diff 557332. ilinpv retitled this revision from "[AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs." to "[AArch64] Fix FMV ifunc resolver usage on old Android APIs. Rename internal compiler-rt FMV functions.". ilinpv edited the summary of t

[libunwind] f958381 - [libunwind] Clarify comment added in #67205

Author: Alex Richardson Date: 2023-09-25T15:04:23-07:00 New Revision: f9583815e7e9bd5d57ef27232e6cbbc426e03824 URL: https://github.com/llvm/llvm-project/commit/f9583815e7e9bd5d57ef27232e6cbbc426e03824 DIFF: https://github.com/llvm/llvm-project/commit/f9583815e7e9bd5d57ef27232e6cbbc426e03824.dif

[clang] [clang] Predefined macros for float128 support (PR #67196)

@@ -1076,6 +1076,8 @@ static void InitializePredefinedMacros(const TargetInfo &TI, DefineFloatMacros(Builder, "FLT", &TI.getFloatFormat(), "F"); DefineFloatMacros(Builder, "DBL", &TI.getDoubleFormat(), ""); DefineFloatMacros(Builder, "LDBL", &TI.getLongDoubleFormat(), "L

[libunwind] [libunwind] Pass -Wl,--export-dynamic on all supported platforms (PR #67205)

arichardson wrote: > Can you as a small follow-up just update the comment to include that part? > E.g. > Will do. > ``` > # On ELF platforms, link tests with -Wl,--export-dynamic if supported by the > linker. > ``` > > Side note: the much older way for doing this is actually `-rdynamic`. It

[clang] [NVPTX] Add support for maxclusterrank in launch_bounds (PR #66496)

https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/66496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Fix classIsDerivedFrom for recusrive cases (PR #67307)

Caslyn wrote: Hi @sam-mccall - thank you, and apologies for the false alarm. After closer inspection, it looks like https://github.com/llvm/llvm-project/issues/66114#issuecomment-1732319259 explains the particular failures we're seeing. Indeed, no relation to this PR - please consider this ma

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes Fixes #67154 --- Full diff: https://github.com/llvm/llvm-project/pull/67376.diff 6 Files Affected: - (modified) clang/include/clang/Basic/Attr.td (+6-2) - (modified) clang/lib/CodeGen/CodeGenModule.cpp (+14-3) - (modified) clan

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

shafik wrote: I was originally going to roll-up this fix as part of: https://reviews.llvm.org/D148474 but it felt distinct enough to fix on its own and then rebase the other PR afterwards. https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commi

[clang] [clang] All {con, de}structor attributes to use template args (PR #67376)

https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/67376 Fixes #67154 >From 5317e66d8997c0406994809901429d5a88c0e0c6 Mon Sep 17 00:00:00 2001 From: Alex Brachet Date: Mon, 25 Sep 2023 17:35:13 -0400 Subject: [PATCH] [clang] All {con,de}structor attributes to use temp

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

jacek added a comment. In D157547#4650643 , @efriedma wrote: > Seems to be working for simple cases, but I'm not sure this is actually > working properly (I'm still seeing LNK1000 crashes). I don't know if it's related to crashes that you're seeing, but

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

llvmbot wrote: @llvm/pr-subscribers-clang Changes In some cases where ill-formed code could be interpreted as a deduction guide we can crash because we reach an unreachable path. This fixes this issue by introducing a diagnostic instead. Fixes: https://github.com/llvm/llvm-project/issues

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

https://github.com/shafik created https://github.com/llvm/llvm-project/pull/67373 In some cases where ill-formed code could be interpreted as a deduction guide we can crash because we reach an unreachable path. This fixes this issue by introducing a diagnostic instead. Fixes: https://github.c

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

ziqingluo-90 updated this revision to Diff 557330. ziqingluo-90 added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158561/new/ https://reviews.llvm.org/D158561 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8586cd5ad8a7fa4f84b5913cbeaf634d68500095 dd3e3e6b8eb3f9f1f740d2a9fc8a62e1964f9153 --

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 557328. AlexVlx added a comment. Use double dash compiler flags only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Basic

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx added inline comments. Comment at: clang/docs/HIPSupport.rst:266 + +- ``-hipstdpar`` / ``--hipstdpar`` enables algorithm offload, which depending on + phase, has the following effects: MaskRay wrote: > Newer long options that don't use the common prefix

[clang] [ClangRepl] Type Directed Code Completion (PR #67349)

https://github.com/capfredf updated https://github.com/llvm/llvm-project/pull/67349 >From 4b371d40d74d6297bdb5ecbe2eae0573e20d0569 Mon Sep 17 00:00:00 2001 From: Fred Fu Date: Tue, 29 Aug 2023 11:56:59 -0400 Subject: [PATCH 1/4] [ClangRepl] Type Directed Code Completion Differential Revision:

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/67366 >From 19b73b3461f2dde1d7df6ef247f46b221cc652d4 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 25 Sep 2023 15:41:54 -0500 Subject: [PATCH] [Clang][HIP] Remove 'clangPostLink' from SDL handling Summary: Th

  1   2   3   4   >