[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541340. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Address commments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/R

[PATCH] D155540: [clangd] Remove extra dependancies for clangd

mstorsjo added a reviewer: sammccall. mstorsjo added a subscriber: sammccall. mstorsjo added a comment. Thanks for looking at my suggestion! At this point, I'd defer the judgement to the code owner, @sammccall - whether it's nicer to have a tighter set of dependencies, or to reduce the risk of c

[PATCH] D155547: [analyzer] Model lifetime of a variable declared in for condition in CFG correctly

tomasz-kaminski-sonarsource added inline comments. Comment at: clang/test/Analysis/lifetime-cfg-output.cpp:609 // CHECK-NEXT:1: [B9.2] (Lifetime ends) // CHECK-NEXT:T: continue; // CHECK-NEXT:Preds (1): B7 Note that the lifetime ends for `[B10.4]`/

[PATCH] D155442: [analyzer] Bind return value for assigment and copies of trivial empty classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61760bb98c46: [analyzer] Bind return value for assigment and copies of trivial empty classes (authored by tomasz-kaminski-sonarsource). Changed prio

[clang] 61760bb - [analyzer] Bind return value for assigment and copies of trivial empty classes

Author: Tomasz Kamiński Date: 2023-07-18T08:31:38+02:00 New Revision: 61760bb98c4694651261b2e10df3fa6f669098ed URL: https://github.com/llvm/llvm-project/commit/61760bb98c4694651261b2e10df3fa6f669098ed DIFF: https://github.com/llvm/llvm-project/commit/61760bb98c4694651261b2e10df3fa6f669098ed.dif

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks a lot for bearing with me, let's ship it! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:91 +const Inclusion &Inc, ParsedAST &AST, +std::shared_pt

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153693: [clang][Interp] Handle InitListExprs of composite type

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153693/new/ https://reviews.llvm.org/D153693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153689: [clang][Interp] Handle CXXConstructExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153689/new/ https://reviews.llvm.org/D153689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155548: [clang][ExprConst] Short-circuit ConstantExpr evaluation

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think this makes sense to do, given that the `Consta

[PATCH] D155547: CPP-4580 Model lifetime of a variable declared in for condition in CFG correctly

tomasz-kaminski-sonarsource created this revision. Herald added a reviewer: NoQ. Herald added a project: All. tomasz-kaminski-sonarsource requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per [stmt.for] p1 (https://eel.is/c++draft/stmt.for#1)

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154951/new/ https://reviews.llvm.org/D154951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155368: [clang][Interp] __builtin_copysign

tbaeder updated this revision to Diff 541325. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155368/new/ https://reviews.llvm.org/D155368 Files: clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp ===

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Split out from https://reviews.llvm.org/D155368 Repo

[PATCH] D155368: [clang][Interp] __builtin_copysign

tbaeder added a comment. I can add some basic tests for `__builtin_copysign` here, but there are test added in https://reviews.llvm.org/D155369 as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155368/new/ https://reviews.llvm.org/D155368 __

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:194 + + S.Stk.push>(Integral<32, true>::from(Arg.isFinite())); + return true; aaron.ballman wrote: > We have platforms on which the width of an integer is not 32-bits; because >

[PATCH] D155545: [clang][Interp] Pass CallExpr to builtin functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For some builtins, we need to do quite a bit of type

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25486 "comment\n" - " return;\n" "}", Why remove? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D140745: Generate Config {Fragment structure, json schema, docs, YAML parser} from schema spec

sammccall added a comment. In D140745#4508559 , @nridge wrote: > In D140745#4505829 , @sammccall > wrote: > >> ping on this one for when you have time > > (Just wanted to double-check, is this ping directed to me

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1035 IO.mapOptional("SpaceInEmptyBlock", Style.SpaceInEmptyBlock); -IO.mapOptional("SpaceInEmptyParentheses", Style.SpaceInEmptyParentheses); IO.mapOptional("SpacesBeforeTrailingComments",

[PATCH] D155544: [AIX][TLS] Add -maix-small-local-exec-tls option.

amyk created this revision. amyk added reviewers: PowerPC, stefanp, kamaub, nemanjai, hubert.reinterpretcast. amyk added a project: LLVM. Herald added subscribers: kbarton, hiraditya. Herald added a project: All. amyk requested review of this revision. Herald added a project: clang. Herald added s

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare marked an inline comment as done. gedare added a comment. I simplified this to treat the double parens identically, so that it will either inject spaces inside both parens, or not. Note: This option is necessary to disable ``SpacesInParens.Other`` from adding spaces inside of ``__attribu

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare updated this revision to Diff 541322. gedare added a comment. Merge the two options to just one for attribute parens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155529/new/ https://reviews.llvm.org/D155529 Files: clang/docs/ClangFormat

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare planned changes to this revision. gedare added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd937836ead34: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements (authored by tomasz-kaminski-sonarsource). Repository:

[clang] d937836 - [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

Author: tomasz-kaminski-sonarsource Date: 2023-07-18T07:03:32+02:00 New Revision: d937836ead34030f4ac016a8eb8a179bd5be10f3 URL: https://github.com/llvm/llvm-project/commit/d937836ead34030f4ac016a8eb8a179bd5be10f3 DIFF: https://github.com/llvm/llvm-project/commit/d937836ead34030f4ac016a8eb8a179b

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder updated this revision to Diff 541318. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155356/new/ https://reviews.llvm.org/D155356 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp =

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder updated this revision to Diff 541314. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155356/new/ https://reviews.llvm.org/D155356 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp =

[PATCH] D155445: [analyzer][docs] Add CSA release notes

OikawaKirie accepted this revision. OikawaKirie added a comment. LGTM for my part. Thx. Since I am not very familiar with other changes, I have no detailed suggestions for the order. Comment at: clang/docs/ReleaseNotes.rst:922-923 +- The ``CStringChecker`` will invalidate les

[PATCH] D155523: [clang] Fix a crash when casting to an array type

shafik added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:458 + case InitializationSequence::FK_ParenthesizedListInitFailed: +// In C++20, if the underlying destination type is a RecordType, then we +// attempt to perform parentesized aggregate initialization

[PATCH] D155111: [clangd] Fix build failures observed on build bots for missing libs

saghir added a comment. In D155111#4495131 , @mstorsjo wrote: > To clarify the issue - the kind of builds that seems to be broken is builds > with `BUILD_SHARED_LIBS=ON`. The reason is that these libraries are needed is > because the `clangd` target inc

[PATCH] D155540: [clangd] Move dependancies for clangd

saghir created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. saghir requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch moves dependancies for clangd inst

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: mattd, carlosgalvezp. Herald added a project: All. yaxunl requested review of this revision. Currently CUDA/HIP defines their own language standards in LanguageStandards.def but they are redundant. They are the

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

ast accepted this revision. ast added a comment. This revision is now accepted and ready to land. overall looks good. one small nit. Comment at: llvm/lib/Target/BPF/MCTargetDesc/BPFMCFixups.h:17 +enum FixupKind { + // These correspond directly to R_390_* relocations. + FK_BPF

[PATCH] D155537: [ASTImporter] Fix import failed when anonymous union defined in class

jcsxky created this revision. jcsxky added a reviewer: danix800. jcsxky added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. jcsxky requested review of this revision. Herald added a subscriber:

[PATCH] D104931: [AArch64] Wire up ILP32 ABI support in Clang

MaskRay added a comment. Herald added a subscriber: wangpc. We need some tests. https://maskray.me/blog/2021-08-08-toolchain-testing#i-dont-know-whether-a-test-is-needed Adding some to `clang/test/Preprocessor/init-aarch64.c` should cover many changes, but we also need one to cover setDataLayou

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

xazax.hun accepted this revision. xazax.hun added a comment. Thanks! Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153273/new/ https://reviews.llvm.org/D153273 ___ cfe-commits mailing l

[PATCH] D140745: Generate Config {Fragment structure, json schema, docs, YAML parser} from schema spec

nridge added a comment. In D140745#4505829 , @sammccall wrote: > ping on this one for when you have time (Just wanted to double-check, is this ping directed to me or Kadir (or both)? I haven't looked at this because Kadir has done a round of review and

[PATCH] D153310: Add builtin_elementwise_pow

bob80905 updated this revision to Diff 541294. bob80905 added a comment. fix void return, and incorrect expectation of arg count Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153310/new/ https://reviews.llvm.org/D153310 Files: clang/docs/Languag

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); craig.topper wro

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vwsll.c:12 +// +vint16mf4_t test_vwsll_vv_i16mf4(vint8mf8_t op1, vint8mf8_t op2, size_t vl) { + return __riscv_vwsll_vv_i16mf4(op1, op2, vl);

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2405 + defvar suffix = !if(IsVV, "vv", "vi"); + defvar prototype = !if(IsVV, "UvUvUvUv", "UvUvUvKz"); + defm "" : RVVBuiltinSet; Can we split this into two classes and ge

[PATCH] D155534: fix arg validation issue and void return issue, tests pass

bob80905 created this revision. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155534 Files: clang/lib/Sema/SemaChecking.cpp clang/

[PATCH] D155509: Revert "Remove rdar links; NFC"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0ac46e69d7a: Revert "Remove rdar links; NFC" (authored by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); eopXD wrote: > V

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:4208-4213 +/// Put a space in parentheses inside attribute specifier lists. +/// \code +///true: false: +///__attribute__(( noreturn ))vs.

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2249 } UnsafeOps = groupWarningGadgetsByVar(std::move(WarningGadgets)); Maybe early-return here when there are no gadgets? CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D155509: Revert "Remove rdar links; NFC"

lattner accepted this revision. lattner added a comment. Thank you, this should have been reverted immediately when concerns were raised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509 __

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:4214-4220 +/// Put a space in parentheses around the outside of attribute specifier +/// lists. +/// \code +///true: false: +///__attribute_

[PATCH] D154755: [clang-format] Fix formatting of if statements with BlockIndent

gedare added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154755/new/ https://reviews.llvm.org/D154755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155529: [clang-format] Add SpaceInParensOption for __attribute__ keyword

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. The __attribute((specifier-list)) currently is formatted bas

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added a comment. In D151683#4508209 , @MaskRay wrote: > Reverse ping @philnik :) > > The `release/17.x` branch will be created soon > (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). I know. I just didn't have the ti

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

owenpan accepted this revision. owenpan added a comment. LGTM except for D151047#4508359 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 ___

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:643-646 + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias_var;\n" + "}"; // Format this line only Then I'

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

rjmccall added a comment. In D155506#4508176 , @gribozavr2 wrote: > I'm not sure it is actually an anti-pattern. `dyn_cast` will transparently > handle subclasses, should any be added in the future, but a switch wouldn't. Yeah, I don't think we have a

[PATCH] D155525: WIP

rjmccall added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:362 // it. This makes the second scan not have to walk the AST again. +RecordJumpScope: LabelAndGotoScopes[S] = ParentScope; I would indent this at the same level as the `ca

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2346 + // computed above. We do not want to generate fix-its for such variables, + // since they are neither warned nor reachable from a warn

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pragma-fixit.cpp Index: clang/test/SemaCXX/warn-u

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 updated this revision to Diff 541269. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155524/new/ https://reviews.llvm.org/D155524 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp clang/test/SemaCXX/warn-unsafe-buffer-usage-pragma-fixit.cpp Index: clang/test/SemaCXX/warn-u

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. Sorry for the delay. Comment at: clang/include/clang/Frontend/FrontendOptions.h:286 + /// print the supported extensions for the current target + unsigned PrintSupportedExtensions : 1; Comment at: clang/include/c

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have nickdesaulniers wrote: > nickdesaulniers wrote: >

[PATCH] D155525: WIP

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Alternate to D155522 based on https://reviews.llvm.org/D155342#4507805

[PATCH] D144829: [WIP][BPF] Add a few new insns under cpu=v4

yonghong-song updated this revision to Diff 541265. yonghong-song edited the summary of this revision. yonghong-song added a comment. - Dropping 'CPUv4' in some variable/function names and also in debug flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

t-rasmud accepted this revision. t-rasmud added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2346 + // computed above. We do not want to generate fix-its for such variables, + // since they are neither

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

MaskRay added a comment. Reverse ping @philnik :) The `release/17.x` branch will be created soon (https://discourse.llvm.org/t/llvm-17-0-0-release-planning-and-update/71762). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://revie

[PATCH] D155509: Revert "Remove rdar links; NFC"

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509 __

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

ldionne added inline comments. Comment at: libcxx/test/std/utilities/meta/meta.const.eval/is_constant_evaluated.verify.cpp:27 static_assert(!std::is_constant_evaluated(), ""); - // expected-warning@-1 0-1 {{'std::is_constant_evaluated' will always evaluate to 'true' in a ma

[PATCH] D155339: Enable zba and zbs for RISCV64 Android

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7623f4f692d: Enable zba and zbs for RISCV64 Android (authored by AdityaK <1894981+hiradi...@users.noreply.github.com>). Repository: rG LLVM Githu

[clang] f7623f4 - Enable zba and zbs for RISCV64 Android

Author: AdityaK Date: 2023-07-17T16:16:13-07:00 New Revision: f7623f4f692d10ef0f764876d670968cba3c9981 URL: https://github.com/llvm/llvm-project/commit/f7623f4f692d10ef0f764876d670968cba3c9981 DIFF: https://github.com/llvm/llvm-project/commit/f7623f4f692d10ef0f764876d670968cba3c9981.diff LOG:

[PATCH] D155506: [clang][JumpDiagnostics] use StmtClass rather than dyn_cast chain NFC

gribozavr2 added a comment. I'm not sure it is actually an anti-pattern. `dyn_cast` will transparently handle subclasses, should any be added in the future, but a switch wouldn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155506/new/ https://r

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added a comment. I do like the look of https://reviews.llvm.org/D155522, yeah, since we have so many of these that aren't top-level in a case anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155342/new/ https://reviews.llvm.org/D1553

[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/include/clang/Sema/Lookup.h:197-200 +DiagnoseAccess(std::move(Other.DiagnoseAccess)), +DiagnoseAmbiguous(std::move(Other.DiagnoseAmbiguous)), AllowHidden(std::move(Ot

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have nickdesaulniers wrote: > rjmccall wrote: > > nick

[PATCH] D155524: [-Wunsafe-buffer-usage] Ignore the FixableGadgets that will not be fixed at an earlier stage

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: NoQ, jkorous, t-rasmud, malavikasamak. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. When some unsafe operations are suppre

[PATCH] D155523: [clang] Fix a crash when casting to an array type

ayzhao created this revision. ayzhao added a reviewer: aaron.ballman. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In C++20, if Clang fails to perform constructor overload on a RecordType, then Clang w

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have rjmccall wrote: > nickdesaulniers wrote: > > rjmc

[PATCH] D155522: [clang][JumpDiagnostics] refactor helper

nickdesaulniers created this revision. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Posting to phab for separate review from https://reviews.llvm.org/D155342#4507805 Will squash this i

[PATCH] D155339: Enable zba and zbs for RISCV64 Android

hiraditya added inline comments. Comment at: clang/test/Driver/riscv-features.c:13 +// ANDROID: "-target-feature" "+zba" // ANDROID: "-target-feature" "+zbb" MaskRay wrote: > If the features are adjacent, test them on one line. `// ANDROID: > "-target-feature

[PATCH] D155270: [clang][Interp] Basic support for bit fields

shafik added inline comments. Comment at: clang/test/AST/Interp/bitfields.cpp:36 + // TODO: +=, -=, etc. operators. +} This is an interesting test case: ``` struct A {int c:3;}; constexpr int f() { A a1{3}; return a1.c++; } void g() { constexpr int x

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

strimo378 added a comment. There are many ast-dump tests about decls but there are nearly no other type tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383

[PATCH] D155501: Add new option -fkeep-persistent-storage-variables to Clang release notes

hubert.reinterpretcast added inline comments. Comment at: clang/docs/ReleaseNotes.rst:259-260 +- ``-fkeep-persistent-storage-variables`` has been implemented to keep all + variables that have a persistent storage duration, including global, static + and thread-local variables,

[PATCH] D155342: [clang][JumpDiagnostics] ignore non-asm goto target scopes

rjmccall added inline comments. Comment at: clang/lib/Sema/JumpDiagnostics.cpp:361 + if (!GS->isAsmGoto()) +break; // Remember both what scope a goto is in as well as the fact that we have nickdesaulniers wrote: > rjmccall wrote: > > You can pul

[clang] 6c30b78 - Reland "[PS4/PS5] Tidy up driver warnings finding the SDK"

Author: Paul Robinson Date: 2023-07-17T13:57:08-07:00 New Revision: 6c30b7886919eb19289f5ed9216e72de9700c9fb URL: https://github.com/llvm/llvm-project/commit/6c30b7886919eb19289f5ed9216e72de9700c9fb DIFF: https://github.com/llvm/llvm-project/commit/6c30b7886919eb19289f5ed9216e72de9700c9fb.diff

[PATCH] D150320: [clang][modules][deps] Avoid checks for relocated modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227f71995804: [clang][modules][deps] Avoid checks for relocated modules (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D150479: [clang][modules] Skip submodule & framework re-definitions in module maps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdba2b5c9314e: [clang][modules] Skip submodule & framework re-definitions in module maps (authored by jansvoboda11). Repository: rG LLVM Github Mon

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe014563f2f4: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM (authored by jansvoboda11). Repository: rG LLVM Gi

[clang] dba2b5c - [clang][modules] Skip submodule & framework re-definitions in module maps

Author: Jan Svoboda Date: 2023-07-17T13:50:25-07:00 New Revision: dba2b5c9314e1d127ee5200e739e6c8ca53a9831 URL: https://github.com/llvm/llvm-project/commit/dba2b5c9314e1d127ee5200e739e6c8ca53a9831 DIFF: https://github.com/llvm/llvm-project/commit/dba2b5c9314e1d127ee5200e739e6c8ca53a9831.diff L

[clang] be01456 - [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

Author: Jan Svoboda Date: 2023-07-17T13:50:24-07:00 New Revision: be014563f2f492658abcfa68cfaffc58a4ed7d9a URL: https://github.com/llvm/llvm-project/commit/be014563f2f492658abcfa68cfaffc58a4ed7d9a DIFF: https://github.com/llvm/llvm-project/commit/be014563f2f492658abcfa68cfaffc58a4ed7d9a.diff L

[clang] 227f719 - [clang][modules][deps] Avoid checks for relocated modules

Author: Jan Svoboda Date: 2023-07-17T13:50:24-07:00 New Revision: 227f71995804fa5df3f917ae3a7b1499cd24726c URL: https://github.com/llvm/llvm-project/commit/227f71995804fa5df3f917ae3a7b1499cd24726c DIFF: https://github.com/llvm/llvm-project/commit/227f71995804fa5df3f917ae3a7b1499cd24726c.diff L

[PATCH] D150292: [clang][modules] Serialize `Module::DefinitionLoc`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGabcf7ce45794: [clang][modules] Serialize `Module::DefinitionLoc` (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D15

[clang] abcf7ce - [clang][modules] Serialize `Module::DefinitionLoc`

Author: Jan Svoboda Date: 2023-07-17T13:50:23-07:00 New Revision: abcf7ce45794839a473a236d55d163016cde5ba6 URL: https://github.com/llvm/llvm-project/commit/abcf7ce45794839a473a236d55d163016cde5ba6 DIFF: https://github.com/llvm/llvm-project/commit/abcf7ce45794839a473a236d55d163016cde5ba6.diff L

[PATCH] D155419: [Clang][CMake][WIP] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 541222. Amir added a comment. More plumbing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/utils/perf-training/CMakeLists.txt cl

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare added a comment. I addressed the comments, and I have redesigned this option to simplify it further. Now there are only two options at the top for `SpacesInParens` to be either `Never` or `Custom`. Then within `Custom` the individual behavior of the spaces can be controlled. This allows,

[PATCH] D155383: [clang][AST] TextNodeDumper learned to output exception specifications

shafik added a comment. I think we at least need some tests for this, looks like we have the AST tests in `clang/test/AST/ast-dump*` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155383/new/ https://reviews.llvm.org/D155383 __

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5336 + // least zve64x + if ((Ty->isRVVType(/* Bitwidth */ 64, /* IsFloat */ false) && + !TI.hasFeature("zve64x")) || Can we do ``` if ((Ty->isRVVType(/* Bitwidth */ 64, /* I

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

gedare updated this revision to Diff 541219. gedare marked 3 inline comments as done. gedare added a comment. Properly deprecate old options, and simplify top-level to Never and Custom Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https

  1   2   3   >