hiraditya added inline comments.
================ Comment at: clang/test/Driver/riscv-features.c:13 +// ANDROID: "-target-feature" "+zba" // ANDROID: "-target-feature" "+zbb" ---------------- MaskRay wrote: > If the features are adjacent, test them on one line. `// ANDROID: > "-target-feature" "+zba" "-target-feature" "+zbb" ...` that's a neat trick. it might work for zba, and zbb. But it could break for zbs if something else comes in between. that will make this test dependent on how flags are sorted internally. probably not worth micro-optimizing for this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155339/new/ https://reviews.llvm.org/D155339 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
