[PATCH] D150775: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG3bc1ea5b0ac9: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker. (authored by mb

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG96b22e1c378a: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp. (authored by mboehme). Rep

[clang] 3bc1ea5 - [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

Author: Martin Braenne Date: 2023-05-22T06:51:15Z New Revision: 3bc1ea5b0ac90e04e7b935a5d964613f8fbad4bf URL: https://github.com/llvm/llvm-project/commit/3bc1ea5b0ac90e04e7b935a5d964613f8fbad4bf DIFF: https://github.com/llvm/llvm-project/commit/3bc1ea5b0ac90e04e7b935a5d964613f8fbad4bf.diff LOG

[PATCH] D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG8bc8fc65c9b2: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp. (authored by mboe

[clang] 8bc8fc6 - [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

Author: Martin Braenne Date: 2023-05-22T06:51:12Z New Revision: 8bc8fc65c9b20de6ffad63d7ce6734c145265cc2 URL: https://github.com/llvm/llvm-project/commit/8bc8fc65c9b20de6ffad63d7ce6734c145265cc2 DIFF: https://github.com/llvm/llvm-project/commit/8bc8fc65c9b20de6ffad63d7ce6734c145265cc2.diff LOG

[clang] 96b22e1 - [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

Author: Martin Braenne Date: 2023-05-22T06:51:13Z New Revision: 96b22e1c378a93a26cd8fc8051bfc7b90f65b665 URL: https://github.com/llvm/llvm-project/commit/96b22e1c378a93a26cd8fc8051bfc7b90f65b665 DIFF: https://github.com/llvm/llvm-project/commit/96b22e1c378a93a26cd8fc8051bfc7b90f65b665.diff LOG

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG5a16665ed535: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp. (authored by mboehme

[clang] 5a16665 - [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

Author: Martin Braenne Date: 2023-05-22T06:51:10Z New Revision: 5a16665ed53500b7ee6703be3d5b9e0bca6f1c14 URL: https://github.com/llvm/llvm-project/commit/5a16665ed53500b7ee6703be3d5b9e0bca6f1c14 DIFF: https://github.com/llvm/llvm-project/commit/5a16665ed53500b7ee6703be3d5b9e0bca6f1c14.diff LOG

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The bit-shifting operator bui

[PATCH] D151059: [test] Add C++ ext_vector_type tests

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add initial tests for the beh

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

ebevhan added a comment. In D58346#4359291 , @jhuber6 wrote: > should C++ really be limited by OpenCL here? It probably shouldn't. There's many places in the codebase where OpenCL flags restrict generic address space behavior. I have a patch at D62574 <

[PATCH] D150937: [clang-repl] Disable all tests on unsupported platforms

v.g.vassilev added a comment. I would support this change but instead of asking the JIT we should just add `-fsyntax-only` to these invocations as they do not rely on the JIT at all. Comment at: clang/test/Interpreter/incremental-mode.cpp:3 // RUN: clang-repl -Xcc -emit-llvm

[PATCH] D150775: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789 - // of these accessors. - .CaseOfCFGStmt(valueOperatorCall(std::nullopt),

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin updated this revision to Diff 524165. yronglin added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D150840: [clang][NFC] Refactor emitSnippet()

tbaeder added a comment. Side-note: The `ToPrint` stuff here is just useful to "cache" the output string, isn't it? Is that really useful? I'd expect the output stream to be cached anyway? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150840/new/

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin updated this revision to Diff 524159. yronglin added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D150528: [Clang][Attribute] Improve the AST/diagnoses fidelity of alignas and _Alignas

yronglin updated this revision to Diff 524158. yronglin added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Fix crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D

[PATCH] D150945: [RISCV] Add missing test for ctz_32 on RV64

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d3d51d77a7: [RISCV] Add missing test for ctz_32 on RV64 (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150945/new/ https://reviews.llvm.

[clang] 33d3d51 - [RISCV] Add missing test for ctz_32 on RV64

Author: Jim Lin Date: 2023-05-22T10:28:27+08:00 New Revision: 33d3d51d77a7fb7ca6b919f9ba47999cd8531844 URL: https://github.com/llvm/llvm-project/commit/33d3d51d77a7fb7ca6b919f9ba47999cd8531844 DIFF: https://github.com/llvm/llvm-project/commit/33d3d51d77a7fb7ca6b919f9ba47999cd8531844.diff LOG:

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei abandoned this revision. pengfei added a comment. Abandon this in favor of D150913 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919/new/ https://reviews.llvm.org/D136919 _

[PATCH] D151051: [clang-tidy] Optimize misc-confusable-identifiers

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Main performance issu

[PATCH] D150126: [clang-tidy][WIP] Set traversal scope to prevent analysis in headers

PiotrZSL added a comment. I love an idea, but i'm afraid that it may impact checks that build some internal database, like misc-confusable-identifiers or misc-unused-using-decls. Probably some of those checks would need to be rewrite to use some own visitor. And probably we should have access t

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

barannikov88 added inline comments. Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.h:22 #include "mlir/Interfaces/SideEffectInterfaces.h" +#include IncludeGuardian wrote: > I wasn't sure if it is possible to include `` within `HLFIROps.td` so > it

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian requested review of this revision. IncludeGuardian added inline comments. Comment at: flang/include/flang/Optimizer/HLFIR/HLFIROps.h:22 #include "mlir/Interfaces/SideEffectInterfaces.h" +#include I wasn't sure if it is possible to include `` w

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

jhuber6 added a comment. Herald added a subscriber: arichardson. Herald added a project: All. Ran into this change trying to decay a qualifier pointer to a generic address space, e.g. https://godbolt.org/z/3dEd4TxjW. I understand that `addrspace_cast` was added to replace this functionality, but

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524125. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h flang/include/flang/Optimizer/HLFIR/HLFIROps.h llvm/includ

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

zahiraam added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:381 HasBFloat16 = SSELevel >= SSE2; codemzs wrote: > rjmccall wrote: > > pengfei wrote: > > > I'm not sure if I understand the meaning of `HasFullBFloat16`. If it is > > > used

[PATCH] D151048: [clang][ExtractAPI] Modify declaration fragment methods to add a new fragment at an arbitrary offset.

Ruturaj4 created this revision. Ruturaj4 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. Ruturaj4 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current implementation doesn't support merging dec

[PATCH] D148827: -fsanitize=function: support C

MaskRay updated this revision to Diff 524110. MaskRay added a comment. rebase. unsupport powerpc64-* as ppc64be ELFv1 may have an existing `error: Cannot represent a difference across sections` issue unrelated to the -fsanitize=function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524109. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150997/new/ https://reviews.llvm.org/D150997 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h llvm/include/llvm/ADT/DenseMapInfo.h llvm/include/llvm/ADT

[clang] 4aa1cad - [Driver] Disable -fsanitize=function for ppc64be after D148573

Author: Fangrui Song Date: 2023-05-21T09:14:40-07:00 New Revision: 4aa1cadf3c67c61b394051630896f06f35b562ca URL: https://github.com/llvm/llvm-project/commit/4aa1cadf3c67c61b394051630896f06f35b562ca DIFF: https://github.com/llvm/llvm-project/commit/4aa1cadf3c67c61b394051630896f06f35b562ca.diff

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. bump - @njames93 let me know if you have any further feedback. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 ___ cfe-commits

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin updated this revision to Diff 524108. yronglin added a comment. Test asm dump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Par

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin updated this revision to Diff 524107. yronglin added a comment. Remove extra include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Pa

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin updated this revision to Diff 524106. yronglin added a comment. Improve the AST fidelity of ``alignas`` and ``_Alignas`` attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150528/new/ https://reviews.llvm.org/D150528 Files: clang/

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei added a comment. Sorry for the back and forth! I just want to add a `:` after `warning`, but I forgot to amend it in the first reland.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 ___

[clang] c2cec8a - Revert "Reland "[Driver] Support multi /guard: options""

Author: Phoebe Wang Date: 2023-05-21T22:48:35+08:00 New Revision: c2cec8a91cf948aac6ec7c7b4e74aab2236769bd URL: https://github.com/llvm/llvm-project/commit/c2cec8a91cf948aac6ec7c7b4e74aab2236769bd DIFF: https://github.com/llvm/llvm-project/commit/c2cec8a91cf948aac6ec7c7b4e74aab2236769bd.diff L

[clang] 2f0a169 - Reland "[Driver] Support multi /guard: options"

Author: Phoebe Wang Date: 2023-05-21T22:49:34+08:00 New Revision: 2f0a1699eab7c00a64312e7f87e0d85a2e9b9e6e URL: https://github.com/llvm/llvm-project/commit/2f0a1699eab7c00a64312e7f87e0d85a2e9b9e6e DIFF: https://github.com/llvm/llvm-project/commit/2f0a1699eab7c00a64312e7f87e0d85a2e9b9e6e.diff L

[clang] caf01f9 - Reland "[Driver] Support multi /guard: options"

Author: Phoebe Wang Date: 2023-05-21T22:43:30+08:00 New Revision: caf01f9b1df732d4eda1577123be7ec5da964f8f URL: https://github.com/llvm/llvm-project/commit/caf01f9b1df732d4eda1577123be7ec5da964f8f DIFF: https://github.com/llvm/llvm-project/commit/caf01f9b1df732d4eda1577123be7ec5da964f8f.diff L

[clang] bc9fda0 - Revert "Reland "[Driver] Support multi /guard: options""

Author: Phoebe Wang Date: 2023-05-21T22:39:37+08:00 New Revision: bc9fda01ad1341519694bbf1e1b738298e3395f3 URL: https://github.com/llvm/llvm-project/commit/bc9fda01ad1341519694bbf1e1b738298e3395f3 DIFF: https://github.com/llvm/llvm-project/commit/bc9fda01ad1341519694bbf1e1b738298e3395f3.diff L

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna abandoned this revision. Manna added a comment. This is False Positive. We are correctly checking type mismatch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 ___ cfe-commits mailing list cfe

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524096. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp

[PATCH] D151033: [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable declaration when it has a dependent type

hazohelet updated this revision to Diff 524095. hazohelet retitled this revision from "[clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable template definition" to "[clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable declaration

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

IncludeGuardian updated this revision to Diff 524094. Herald added subscribers: bviyer, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, mgester, arpith-j

[PATCH] D151033: [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable template definition

hazohelet added a comment. In D151033#4359121 , @tbaeder wrote: > Can you briefly explain why the `FieldDecl` we see is null in that case? Consider `template constexpr T foo{};` `evaluateValue` here leads to a call of `EvaluateAsInitializer`. It calls

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524093. junaire added a comment. add `caas` namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/i

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono added a comment. The build failures seem to be unrelated to my changes. The builds of other reviews also show them, and the error messages point to things I haven't changed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ http

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524091. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono created this revision. Sedeniono added a reviewer: curdeius. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. Sedeniono requested review of this revision. Fixes github iss

[clang] 8b1727f - [NFC] remove duplicated dash in release note for #62447

Author: Congcong Cai Date: 2023-05-21T11:26:16+02:00 New Revision: 8b1727f8d9104df5ced4bdfdc065dea85ff84baf URL: https://github.com/llvm/llvm-project/commit/8b1727f8d9104df5ced4bdfdc065dea85ff84baf DIFF: https://github.com/llvm/llvm-project/commit/8b1727f8d9104df5ced4bdfdc065dea85ff84baf.diff

[PATCH] D151033: [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable template definition

tbaeder added a comment. Can you briefly explain why the `FieldDecl` we see is null in that case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151033/new/ https://reviews.llvm.org/D151033 ___ cfe-commit

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire added a comment. Invite more people to the party :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D146809: [clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 524088. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/Interp