v.g.vassilev added a comment.

I would support this change but instead of asking the JIT we should just add 
`-fsyntax-only` to these invocations as they do not rely on the JIT at all.



================
Comment at: clang/test/Interpreter/incremental-mode.cpp:3
 // RUN: clang-repl -Xcc -emit-llvm 
+// UNSUPPORTED: system-aix
 // expected-no-diagnostics
----------------
This test does not run anything, so this should be supported. Perhaps we could 
add `-fsyntax-only` mode to the RUN lines above.


================
Comment at: clang/unittests/Interpreter/IncrementalProcessingTest.cpp:74
+    return;
   std::vector<const char *> ClangArgv = {"-Xclang", "-emit-llvm-only"};
   auto CI = llvm::cantFail(IncrementalCompilerBuilder::create(ClangArgv));
----------------
Likewise, here `-fsyntax-only` mode should be enough since we do not execute 
anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150937/new/

https://reviews.llvm.org/D150937

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to