[clang] 5326c9e - Revert "Give NullabilityKind a printing operator<<"

Author: Caroline Tice Date: 2023-05-05T23:37:30-07:00 New Revision: 5326c9e480d70e16c2504cb5143524aff3ee2605 URL: https://github.com/llvm/llvm-project/commit/5326c9e480d70e16c2504cb5143524aff3ee2605 DIFF: https://github.com/llvm/llvm-project/commit/5326c9e480d70e16c2504cb5143524aff3ee2605.diff

[PATCH] D149650: Give NullabilityKind a printing operator<

cmtice added a comment. This is breaking some of our tests. I will give the author a reproducible test case. I am going to revert this while waiting for a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149650/new/ https://reviews.llvm.org/D149

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149579/new/ https://reviews.llvm.org/D149579 __

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

PiotrZSL added a comment. `forwarding reference parameter '' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]` consider ignoring unnamed parameters, they unused, so nothing to forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520034. barannikov88 edited the summary of this revision. barannikov88 added a comment. - Forward declare CodeGenTypes - Split a few more virtual functions into declaration+definition to not depend on transitive includes, which are going to be removed

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:136 +- New :doc:`cppcoreguidelines-missing-std-forward + ` check. Should be after `cppcoreguidelines-misleading-capture-default-by-value`. Repository: rG LLVM Github

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520032. ccotter added a comment. - fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

[PATCH] D149518: [clang][NFC] Optimize clang::ASTNodeKind::isBaseOf

PiotrZSL updated this revision to Diff 520031. PiotrZSL added a comment. Rebase without changes, just because some testcase in this baseline looks to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149518/new/ https://reviews.llvm.org/D149518

[PATCH] D150017: [Clang][BPF] Type print btf_type_tag properly

yonghong-song created this revision. yonghong-song added reviewers: ast, aaron.ballman. Herald added a project: All. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When running bcc tool execsnoop ([1]) which is built with lat

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. I think it should be ready for review now. One point to note. I didn't follow IWYU rule in target *.cpp files -- they include the smallest set of headers for now. My memory suggests me that IWYU is a requirement, but I couldn't find a proof in the coding standard. It

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added a comment. Note, @PiotrZSL I don't have commit access, so if you're happy with the updates, could you please land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 __

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520027. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt clang

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MissingStdForwardCheck.cpp:70 + Finder->addMatcher( + parmVarDecl( + parmVarDecl().bind("param"), isTemplateTypeOfFunction(), PiotrZSL wrote: > maybe think l

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 520026. ccotter marked 6 inline comments as done. ccotter added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520025. barannikov88 added a comment. Move interface comments to the header file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.

[clang] 5b388f8 - [C++20] [Modules] Don't check input files for C++20 Modules

Author: Chuanqi Xu Date: 2023-05-06T11:17:15+08:00 New Revision: 5b388f86aa9ce65778677ae56587867d6786355e URL: https://github.com/llvm/llvm-project/commit/5b388f86aa9ce65778677ae56587867d6786355e DIFF: https://github.com/llvm/llvm-project/commit/5b388f86aa9ce65778677ae56587867d6786355e.diff LO

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've tested this and it works for my build configuration. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

0x59616e added a comment. I didn't see any issue here. Let's wait for the approval from other (more senior) reviewers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___ cfe-commits mailing list cf

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

This revision was automatically updated to reflect the committed changes. Closed by commit rGbabe8629d73f: [NFC][Clang] Fix static analyzer tool remarks about large copies by values in… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] babe862 - [NFC][Clang] Fix static analyzer tool remarks about large copies by values in Format.cpp file

Author: Manna, Soumi Date: 2023-05-05T18:55:49-07:00 New Revision: babe8629d73fb52bf85516222cd484da0eed6c12 URL: https://github.com/llvm/llvm-project/commit/babe8629d73fb52bf85516222cd484da0eed6c12 DIFF: https://github.com/llvm/llvm-project/commit/babe8629d73fb52bf85516222cd484da0eed6c12.diff

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, JonChesterfield. Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, wdng. Herald a

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining added a comment. Thanks @rengolin and @peter.smith. I just added a new test to show options remain unused on a target that does not support them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.org/D149946

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 520015. barannikov88 added a comment. - Rebase on top of the stack - Fix a header comment - Split some virtual functions to avoid extra includes in header files - Forward declare a few classes and add necessary includes (IWYU, header files only) Reposi

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

SixWeining updated this revision to Diff 520014. SixWeining added a comment. Add a test to show related options remain unused on a target that does not support them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.or

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

Manna added a comment. >> Thanks again for catching our oops @HazardyKnusperkeks! Yup, Thank you @HazardyKnusperkeks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1418 + def int_riscv_vreinterpret_v +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], craig.topper wrote: > Do we need an intrinsic? > > m1 -> mask is bitcast m1 vsca

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

craig.topper added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsRISCV.td:1418 + def int_riscv_vreinterpret_v +: DefaultAttrsIntrinsic<[llvm_anyvector_ty], Do we need an intrinsic? m1 -> mask is bitcast m1 vscale type to and a llvm.ex

[PATCH] D149642: [RISCV] Support vreinterpret intrinsics between vector boolean type and m1 vector integer type

kito-cheng added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vreinterpret.c:1 -// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// NOTE: Assertions have been autogenerated by utils/upd

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaronpuchert added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3; aaronpuchert wrote: > e

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:13 + if(DEFINED CLANG_RESOURCE_DIR AND NOT CLANG_RESOURCE_DIR STREQUAL "") +set(ret_dir bin/${CLANG_RESOURCE_DIR}) + else() tstellar wrote: > tstellar wrote: > > tstella

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaronpuchert added inline comments. Comment at: clang/include/clang/Driver/Options.td:2544 +defm diagnostics_show_line_numbers : BoolFOption<"diagnostics-show-line-numbers", + DiagnosticOpts<"ShowLineNumbers">, DefaultTrue, + NegFlag, aaron.ballman wrote: > I'

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/6]

barannikov88 updated this revision to Diff 520004. barannikov88 edited the summary of this revision. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

barannikov88 added a comment. In D149978#4323457 , @jhuber6 wrote: > In D149978#4323452 , @tra wrote: > >>> I've discovered that LLVM adds -Wl,-fcolor-diagnostics >> >> Can you tell me where it's done? > > `llvm/c

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. In D149978#4323457 , @jhuber6 wrote: > `llvm/cmake/modules/HandleLLVMOptions.cmake:994` I do not think that we should work around this particular

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

benlangmuir added a comment. In D103930#4310061 , @ivanmurashko wrote: > Friendly ping > > @arphaman, @jansvoboda11, I have made the patch buildable on all platforms > and have all tests passed. There was also a small fix (temp path for modules > artef

[PATCH] D149980: Remove unused basic_android_tree/mipsel-linux-android

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f0eee16d9b4: Remove unused basic_android_tree/mipsel-linux-android (authored by AdityaK <1894981+hiradi...@users.noreply.github.com>). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8f0eee1 - Remove unused basic_android_tree/mipsel-linux-android

Author: AdityaK Date: 2023-05-05T15:50:22-07:00 New Revision: 8f0eee16d9b420c0b5339bf9c386dc6cbbf29b42 URL: https://github.com/llvm/llvm-project/commit/8f0eee16d9b420c0b5339bf9c386dc6cbbf29b42 DIFF: https://github.com/llvm/llvm-project/commit/8f0eee16d9b420c0b5339bf9c386dc6cbbf29b42.diff LOG:

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. In D149978#4323452 , @tra wrote: >> I've discovered that LLVM adds -Wl,-fcolor-diagnostics > > Can you tell me where it's done? `llvm/cmake/modules/HandleLLVMOptions.cmake:994` Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added a comment. > I've discovered that LLVM adds -Wl,-fcolor-diagnostics Can you tell me where it's done? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://reviews.llvm.org/D149978

[PATCH] D149920: ms inline asm: recognize case-insensitive JMP and CALL as TargetLowering::C_Address

This revision was automatically updated to reflect the committed changes. Closed by commit rG8afd831b456a: ms inline asm: recognize case-insensitive JMP and CALL as TargetLowering… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 8afd831 - ms inline asm: recognize case-insensitive JMP and CALL as TargetLowering::C_Address

Author: Fangrui Song Date: 2023-05-05T15:32:32-07:00 New Revision: 8afd831b456a46677e638cdf00dd649fbd5ca0a1 URL: https://github.com/llvm/llvm-project/commit/8afd831b456a46677e638cdf00dd649fbd5ca0a1 DIFF: https://github.com/llvm/llvm-project/commit/8afd831b456a46677e638cdf00dd649fbd5ca0a1.diff

[PATCH] D150001: [clang] Fix initializer_list matching failures with modules

ayzhao created this revision. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, if a class with a defined public virtual destructor is declared before including and initializer_list is provided

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. In D149978#4323328 , @tra wrote: >> The latter is a little difficult, > > The more we dig, the more we want GPU-capable lld. :-) My thoughts exactly. I had a small chat with @MaskRay about how difficult it would be to spin up su

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

Manna added a comment. Thank you everyone for reviews and comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 519983. myhsu added a comment. Minor updates. NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/lib/Basic/Targets/M68k.cpp clang/lib/Basic/Targets/M68k.h clang/lib/CodeGen/CGCall.cpp

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added a comment. > The latter is a little difficult, The more we dig, the more we want GPU-capable lld. :-) Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:641 + // by nvlink. + if (llvm::any_of(II.getInputArg().getValues(), [](StringRef Arg) { +retu

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 ___

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

myhsu updated this revision to Diff 519982. myhsu added a comment. Introduce `m68k_rtdcc` the textual LLVM IR designation for M68k_RTD CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 Files: clang/lib/Basic/Targets/M68k.cpp clang/lib/Basic/

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good. Thanks again for catching our oops @HazardyKnusperkeks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 _

[PATCH] D149999: [clang-tidy] [test] Narrow down a special case to MSVC mode

mstorsjo created this revision. mstorsjo added reviewers: alvinhochun, aaron.ballman, hans. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. For MinGW targets, size_t is

[PATCH] D149997: [clang] [test] Narrow down MSVC specific behaviours from "any windows" to only MSVC/clang-cl

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, hans. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. This fixes running tests with a toolchain that defaults to a MinGW target. Repository: rG LLVM Github Monorepo

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 updated this revision to Diff 519977. jhuber6 added a comment. Putting up the hack that works around my problem with `libc`. Definitely not a good solution though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://reviews.l

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks good with one exception; I think the changes for class `SemaDiagnosticBuilder` are not what was intended. Comment at: clang/include/clang/Anal

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

This revision was automatically updated to reflect the committed changes. Closed by commit rG07996804a0c0: [NFC] ][CLANG] Fix static code analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://review

[clang] 0799680 - [NFC] ][CLANG] Fix static code analyzer concerns

Author: Manna, Soumi Date: 2023-05-05T14:34:36-07:00 New Revision: 07996804a0c0290a4ee5d964a94333894c7792c2 URL: https://github.com/llvm/llvm-project/commit/07996804a0c0290a4ee5d964a94333894c7792c2 DIFF: https://github.com/llvm/llvm-project/commit/07996804a0c0290a4ee5d964a94333894c7792c2.diff

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

efriedma added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3; aaron.ballman wrote: > jrtc

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. In D149978#4323221 , @tra wrote: > In D149978#4323210 , @jhuber6 wrote: > >> Somewhat annoying, I've discovered that LLVM adds `-Wl,-fcolor-diagnostics` >> which obviously isn't supported

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added a comment. In D149978#4323210 , @jhuber6 wrote: > Somewhat annoying, I've discovered that LLVM adds `-Wl,-fcolor-diagnostics` > which obviously isn't supported by `nvlink` so it fails while including this > in `libc`'s CMake. Any clue if there

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. The main reason I made this patch was to allow passing `--suppress-stack-size-warning` to `nvlink`. But it turns out it's a little more difficult there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://re

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added a comment. > So I'm still not sure this is the 'right' away about it. I think we should > instead properly handle the containsErrors case and just always create a > non-dependent sized array, except with the RecoveryExpr having the correct > type. You are right. Fix as your s

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 519972. HerrCai0907 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaType.cpp c

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 added a comment. Somewhat annoying, I've discovered that LLVM adds `-Wl,-fcolor-diagnostics` which obviously isn't supported by `nvlink` so it fails while including this in `libc`'s CMake. Any clue if there's a way to work around that? Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added a comment. In D149461#4323175 , @tahonermann wrote: > These changes look good to me and I agree with not making a change for the > `KnownHeaders` case. >> I agree with not making a change for the `KnownHeaders` case. Yup. I closed them a

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. These changes look good to me and I agree with not making a change for the `KnownHeaders` case. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1131-1132

[PATCH] D149776: Re-land "[AMDGPU] Define data layout entries for buffers""

krzysz00 added a comment. From a quick skim of the backtrace, I think this comes down to the fact that there isn't a defined way to stick a `p7` into registers (or, equivalently, there's no `MVT::i160`) and that getting said pointers to that point was supposed to never happen (in that they were

[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

shafik updated this revision to Diff 519960. shafik added a comment. - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149694/new/ https://reviews.llvm.org/D149694 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaInit.cpp clang/test/Sema

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 519958. ziqingluo-90 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cp

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 marked an inline comment as done. ziqingluo-90 added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2363-2364 + if (isa(Node)) { +// to visit implicit children of `LambdaExpr`s: +IsVisitingLambda = true; +

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 updated this revision to Diff 519957. jhuber6 added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149978/new/ https://reviews.llvm.org/D149978 Files: clang/lib/Driver/ToolChains/Cuda.cpp clang/test/Driver

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:594 - // Add paths specified in LIBRARY_PATH environment variable as -L options. - addDirectoryList(Args, CmdArgs, "-L", "LIBRARY_PATH"); -

[PATCH] D149983: AMDGPU: Add basic gfx942 target

kzhuravl created this revision. kzhuravl added reviewers: arsenm, msearles, rampitec, t-tye. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. H

[PATCH] D149982: AMDGPU: Add basic gfx941 target

kzhuravl created this revision. kzhuravl added reviewers: arsenm, msearles, rampitec, t-tye. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, foad, kerbowa, hiraditya, tpr, dstuttard, yaxunl, jvesely, emaste. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. H

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

peter.smith added a comment. No objections for moving out m_arm_Features_Group or adding the alias. It looks like that is currently unused i.e. no driver filters out the m_arm_Features_Group. I can't comment on the LoongArch specific parts of the patch. I think you may want to note in the help

[PATCH] D149981: [clang][AST][NFC] Factor out check for structural equivalence of names.

davidstone created this revision. Herald added a subscriber: martong. Herald added a project: All. davidstone requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have four places that we try to decide which name to use for the test for stru

[PATCH] D149980: Remove unused basic_android_tree/mipsel-linux-android

hiraditya created this revision. hiraditya added reviewers: danalbert, enh, pirama, srhines. Herald added subscribers: danielkiss, atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. hiraditya requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:594 - // Add paths specified in LIBRARY_PATH environment variable as -L options. - addDirectoryList(Args, CmdArgs, "-L", "LIBRARY_PATH"); - Is removal of this line intentional? =

[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, MaskRay. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo updated this revision to Diff 519939. oontvoo added a comment. addressed review comments: - added explanation on why we left out _gcc personality - updated more clang tests hopefully should be all green now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D149922: Fix nullptr dereference found by Coverity static analysis tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e0c44174823: [NFC][CLANG] Fix nullptr dereference found by Coverity static analysis tool (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 6e0c441 - [NFC][CLANG] Fix nullptr dereference found by Coverity static analysis tool

Author: Manna, Soumi Date: 2023-05-05T11:57:33-07:00 New Revision: 6e0c44174823260fd74d14d036eaf1c64fa5eded URL: https://github.com/llvm/llvm-project/commit/6e0c44174823260fd74d14d036eaf1c64fa5eded DIFF: https://github.com/llvm/llvm-project/commit/6e0c44174823260fd74d14d036eaf1c64fa5eded.diff

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:56-57 + const Record *R = P.getOrCreateRecord(MD->getParent()); + llvm::DenseMap _LambdaCaptures; + FieldDecl *_LambdaThisCapture; + UB alert -- `_L` is reser

[PATCH] D149976: adding bf16 support to NVPTX

tra added a comment. This patch appears to *include* the changes in D144911 (e.g. llvm/test/CodeGen/NVPTX/bf16-instructions.ll is added by both patches). Can you update it as an incremental patch that actually excludes it? Repository: rG LLVM Github Monore

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

gribozavr2 added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:58 + (Lexer::getIndentationForLine(Loc, Loc.getManager()) + "/* " + + NoLintPrefix + "NOLINTNEXTLINE(" + Error.DiagnosticName

[PATCH] D149579: [X86][MC] Fix parsing Intel syntax indirect branch with symbol only

MaskRay added inline comments. Comment at: llvm/test/MC/X86/intel-syntax-branch.s:61-67 + // FIXME: MASM does not accept this syntax and GAS assembles this as a direct + //call/jump instead of indirect. Consider making this syntax an error? + call [offset fn_ref] + j

[PATCH] D147591: [clang][Interp] Handle CXXTemporaryObjectExprs

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/records.cpp:317-318 { - auto T = Test(Arr, Pos); + Test(Arr, Pos); // End of scope, should destroy Test. } Nit: nothing actually tests that this object is destroyed

[PATCH] D149976: adding bf16 support to NVPTX

kushanam created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, hiraditya. Herald added a project: All. kushanam requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jholewinski. Herald added projects: clang, LLVM. Currently, b

[PATCH] D144999: [RFC][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo marked an inline comment as done. oontvoo added a comment. In D144999#4319964 , @jyknight wrote: > I wonder if we actually need to define a clang frontend flag for this; I > suspect nobody will ever want to specify it, since the only non-canonica

[PATCH] D149846: [clang][Interp] Check inc/dec family of ops for initialization

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149846/new/ https://reviews.llvm.org/D149846

[PATCH] D149723: [clang-tidy] Optimize performance of RenamerClangTidyCheck

PiotrZSL updated this revision to Diff 519924. PiotrZSL marked 3 inline comments as done. PiotrZSL added a comment. Use operator + instead of hash_combine. Use TraverseAST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149723/new/ https://reviews.

[PATCH] D149723: [clang-tidy] Optimize performance of RenamerClangTidyCheck

PiotrZSL marked 3 inline comments as done. PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:47 -std::hash SecondHash; -return DenseMapInfo::getHashValue(Val.first) + - SecondHash(Val.second); +return

[PATCH] D149518: [clang] Optimize clang::ASTNodeKind::isBaseOf

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oh wow, I'm surprised that calculating the distance has that much compile time impact. Great catch! Please add `NFC` to the commit summary so folks know why there are no tests.

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf9fa8a599704: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td (authored by michaelmaitland). Repository: rG LLVM Github

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland updated this revision to Diff 519921. michaelmaitland added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149497/new/ https://reviews.llvm.org/D149497 Files: llvm/lib/Target/RISCV/RISCVSchedSiFive7.td Index:

[PATCH] D149497: [RISCV] Add scheduling information for Zba and Zbb to RISCVSchedSiFive7.td

michaelmaitland added a comment. This revision needs to be reopened because it was committed with changes that are not relevant to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149497/new/ https://reviews.llvm.org/D149497

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b3d73787704: Check if First argument in _builtin_assume_aligned_ is of pointer type (authored by Ris-Bali, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0b3d737 - Check if First argument in _builtin_assume_aligned_ is of pointer type

Author: Rishabh Bali Date: 2023-05-05T13:11:16-04:00 New Revision: 0b3d737877040a4eae03e47223f9a9ddfd7bd182 URL: https://github.com/llvm/llvm-project/commit/0b3d737877040a4eae03e47223f9a9ddfd7bd182 DIFF: https://github.com/llvm/llvm-project/commit/0b3d737877040a4eae03e47223f9a9ddfd7bd182.diff

[PATCH] D149596: [AIX][TLS] Relax front end diagnostics to accept the local-exec TLS model

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149596/new/ https://reviews.llvm.org/D149596

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

Ris-Bali added a comment. Name : Rishabh Bali Github Username : Ris-Bali email-id : rishabhsb...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149514/new/ https://reviews.llvm.org/D149514 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? CHANGES SINCE LAST ACTION https://

[clang] 8394694 - [RISCV] Add sifive-x280 processor with all of its extensions

Author: Michael Maitland Date: 2023-05-05T10:02:28-07:00 New Revision: 839469436afcbdf5bb6dc9b081b1bcf3a1b22fea URL: https://github.com/llvm/llvm-project/commit/839469436afcbdf5bb6dc9b081b1bcf3a1b22fea DIFF: https://github.com/llvm/llvm-project/commit/839469436afcbdf5bb6dc9b081b1bcf3a1b22fea.di

  1   2   >