[PATCH] D149978: [Clang][NVPTX] Allow passing arguments to the linker while standalone

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:594
-  // Add paths specified in LIBRARY_PATH environment variable as -L options.
-  addDirectoryList(Args, CmdArgs, "-L", "LIBRARY_PATH");
-
----------------
Is removal of this line intentional? 


================
Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:634
       }
-    } else {
-      CmdArgs.push_back(Args.MakeArgString(InputFile));
+      continue;
     }
----------------
I'd prefer to replace it with 
```
if (II.isFileName()) {
  do stuff...
} else {
  if (!II.isNothing()
      II.getInputArg().renderAsInput(Args, CmdArgs); 
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149978/new/

https://reviews.llvm.org/D149978

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits