tra requested changes to this revision.
tra added a comment.
This revision now requires changes to proceed.

In D149978#4323457 <https://reviews.llvm.org/D149978#4323457>, @jhuber6 wrote:

> `llvm/cmake/modules/HandleLLVMOptions.cmake:994`

I do not think that we should work around this particular source of options in 
clang driver.

This sounds like something that may need to be dealt with in cmake.
The root cause is that cmake assumes that if the linker accepts the flag for 
target X, it will accept that flag for target Y. Or that the flags will be used 
only for compiling for the default target. Considering that clang is a 
cross-compiler, neither of the assumptions is universally true.

We may need to add a concept of per-offload-arch options that would be checked 
with specific `--target=...`. It's a bigger can of worms than just filtering 
the argument out, but I think we'll need to deal with it sooner or later 
anyways.

As a short-term stop-gap solution, I would suggest adding a cmake knob to 
disable linker color output altogether. This should unblock you and would not 
affect anybody else until we have a better fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149978/new/

https://reviews.llvm.org/D149978

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to