[PATCH] D140462: [clangd] Add schema for `.clangd` config

hyperupcall created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. hyperupcall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Fixes https://github.com/clangd/cla

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139987/new/ https://reviews.llvm.org/D139987 __

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

gonglingqin updated this revision to Diff 484466. gonglingqin added a comment. Address @SixWeining's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139987/new/ https://reviews.llvm.org/D139987 Files: clang/lib/Headers/larchintrin.h cla

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

gonglingqin added inline comments. Comment at: clang/lib/Headers/larchintrin.h:17-20 +typedef struct drdtime { + unsigned long dvalue; + unsigned long dtimeid; +} __drdtime_t; SixWeining wrote: > Should be moved into the belowing `#if __loongarch_grlen == 64`.

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/AST/Interp/literals.cpp:553 + static_assert(IntRem(2, 1) == 0, ""); + static_assert(IntRem(9, 7) == 2, ""); + aaron.ballman wrote: > tbaeder wrote: > > aaron.ballman wrote: > >

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin updated this revision to Diff 484465. gonglingqin added a comment. Add comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139915/new/ https://reviews.llvm.org/D139915 Files: clang/include/clang/Basic/BuiltinsLoongArch.def clang

[PATCH] D140455: [Clang] Diagnose undefined behavior in a constant expression while evaluating a compound assignment with remainder as operand

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane, tahonermann. Herald added a project: All. shafik requested review of this revision. Currently we don't diagnose overflow in a constant expression for the case of compound assignment with remainder as a operand. In `

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

gonglingqin added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.h:91 IOCSRWR_D, + + CPUCFG, SixWeining wrote: > Better to leave some comment like line 82? Thanks, I'll add comments. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

BeMg updated this revision to Diff 484459. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

SixWeining added inline comments. Comment at: clang/lib/Headers/larchintrin.h:17-20 +typedef struct drdtime { + unsigned long dvalue; + unsigned long dtimeid; +} __drdtime_t; Should be moved into the belowing `#if __loongarch_grlen == 64`. Repository: rG LL

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM except a small nit. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.h:91 IOCSRWR_D, + + CPUCFG, Better to leave some comment lik

[PATCH] D140379: [clangd] Avoid triggering linkage computation for decl with unstable linkage in SymbolRelevanceSignals::computeASTSignals()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6761ba7639a4: [clangd] Avoid triggering linkage computation for decl with unstable linkage in… (authored by nridge). Repository: rG LLVM Github Mo

[clang-tools-extra] 6761ba7 - [clangd] Avoid triggering linkage computation for decl with unstable linkage in SymbolRelevanceSignals::computeASTSignals()

Author: Nathan Ridge Date: 2022-12-20T21:56:36-05:00 New Revision: 6761ba7639a4a1285a2e86a4beaad70569a6c222 URL: https://github.com/llvm/llvm-project/commit/6761ba7639a4a1285a2e86a4beaad70569a6c222 DIFF: https://github.com/llvm/llvm-project/commit/6761ba7639a4a1285a2e86a4beaad70569a6c222.diff

[PATCH] D137235: [clang][Interp] Fix ImplicitValueInitExprs for pointer types

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137235/new/ https://reviews.llvm.org/D137235 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D140389: [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

kito-cheng added a comment. Could you rebase with D140361 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 ___ cfe-commits ma

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. Sorry for the delay, I was out on vacation for a bit. I have a repro for this new issue now: F25778542: repro.tar.gz $ CLANG=~/dev/clang ./repro.sh ++ dirname /tmp/repro/repro.sh + DIR=/tmp/repro + : /tmp/D136554 + rm -rf

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, thanks for clean up this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

BeMg updated this revision to Diff 484437. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

BeMg updated this revision to Diff 484436. BeMg added a comment. Update format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140361/new/ https://reviews.llvm.org/D140361 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuil

[PATCH] D137070: [clang][Interp] Support destructors

shafik added inline comments. Comment at: clang/test/AST/Interp/cxx20.cpp:279 + static_assert(testInc2() == 1, ""); +}; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137070/new/ https://reviews.llvm.org/D137070 __

[PATCH] D137070: [clang][Interp] Support destructors

shafik added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:30 /// Scope used to handle temporaries in toplevel variable declarations. -template class DeclScope final : public LocalScope { +template class DeclScope final : public VariableScope { public

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. In D127812#4009447 , @hctim wrote: > Hi, this looks like a candidate for breaking the MSan bot: > https://lab.llvm.org/buildbot/#/builders/5/builds/30139 > > Still looking into it and bisecting, will let you know when I have more i

[clang] 74dd8c1 - Revert "[AArch64][NFC] Fix aarch64 target features test."

Author: Mitch Phillips Date: 2022-12-20T17:16:17-08:00 New Revision: 74dd8c1bf80bbc415f8f6f45cb8f3f9bd83b3850 URL: https://github.com/llvm/llvm-project/commit/74dd8c1bf80bbc415f8f6f45cb8f3f9bd83b3850 DIFF: https://github.com/llvm/llvm-project/commit/74dd8c1bf80bbc415f8f6f45cb8f3f9bd83b3850.diff

[PATCH] D139938: [clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG52aab0e4b4a5: [clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on… (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 52aab0e - [clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin

Author: Louis Dionne Date: 2022-12-20T19:56:28-05:00 New Revision: 52aab0e4b4a5d6728f4bb9c7b3340133f585fc15 URL: https://github.com/llvm/llvm-project/commit/52aab0e4b4a5d6728f4bb9c7b3340133f585fc15 DIFF: https://github.com/llvm/llvm-project/commit/52aab0e4b4a5d6728f4bb9c7b3340133f585fc15.diff

[PATCH] D139938: [clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin

ldionne added a comment. I'll ship this now since CI seems happy and I reproduced the issue and saw it was fixed by my new change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139938/new/ https://reviews.llvm.org/D139938

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

hctim added a comment. Hi, this looks like a candidate for breaking the MSan bot: https://lab.llvm.org/buildbot/#/builders/5/builds/30139 Still looking into it and bisecting, will let you know when I have more info. To reproduce the bots, the best way (because MSan setup is tricky because it r

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added a comment. I suppressed the assertion in rG8fd62e7 . It looks like we'll need a deeper investigation into this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138253/new

[clang] 8fd62e7 - [-Wunsafe-buffer-usage] Suppress an assertion for visiting VarDecl twice.

Author: Artem Dergachev Date: 2022-12-20T16:05:13-08:00 New Revision: 8fd62e70cde135943e54d80851984988cb0a URL: https://github.com/llvm/llvm-project/commit/8fd62e70cde135943e54d80851984988cb0a DIFF: https://github.com/llvm/llvm-project/commit/8fd62e70cde135943e54d80851984988cb0a.dif

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

ziqingluo-90 updated this revision to Diff 484412. ziqingluo-90 added a comment. To follow LLVM's convention that global variables better have types that do NOT require construction, I change the type of the global variable from `std::string` to `constexpr const char * const`. CHANGES SINCE LA

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

paulkirth added a comment. Thanks! I think we're good now. At least one of our builders is green now. https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8794218564332891457/overview I'll let you know if anything pops up, but this looks squared away to me. Repository:

[PATCH] D140361: [RISCV] Merge Masked and unMasked RVV manual codegen

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:629 { -if (DefaultPolicy == TAIL_AGNOSTIC) - Ops.insert(Ops.begin(), llvm::PoisonValue::get(ResultType)); -IntrinsicTypes = {ResultType, Ops[3]->getType()}; -

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

jrtc27 added a comment. Hm, this means that llvm/lib/Target/$TARGET/$TARGET.td needs to remain working (or at least mostly working, things like ISel patterns can fail to type check) in order for Clang to build, since we're now introducing a dependency on llvm/lib/Target/$TARGET in Clang where t

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) fpetrogalli wrote: > lenary wrote: > > fpetrogalli wrote: > > > craig.topp

[PATCH] D139938: [clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin

ldionne added inline comments. Comment at: compiler-rt/test/profile/lit.cfg.py:45-51 +# TODO: target_cflags can sometimes contain C++ only flags like -stdlib=, which are +# ignored when compiling as C code. Passing this flag when compiling as C results in +# warning

[PATCH] D139938: [clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin

ldionne updated this revision to Diff 484403. ldionne retitled this revision from "[clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin" to "[clang] Re-apply change to avoid passing -stdlib=libc++ spuriously to CC1 on Darwin". ldionne edited the summary of this revision. ldionne added a

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

ldionne reopened this revision. ldionne added a comment. This revision is now accepted and ready to land. In D139938#4008909 , @steven_wu wrote: > In D139938#4008232 , @hans wrote: > >> This seems to have broken t

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

kazu added a comment. Thank you for this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a subscriber: aprantl. fpetrogalli added inline comments. Comment at: llvm/include/llvm/module.modulemap:420 textual header "Support/CSKYTargetParser.def" -textual header "Support/RISCVTargetParser.def" textual header "Support/TargetOpcodes.def" --

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli marked an inline comment as done. fpetrogalli added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) lenary wrote: > fpetrog

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484391. fpetrogalli added a comment. @pcwang-thead, I addressed some of your comments. The value of `EnumFeatures` is now computed dynamicaly from the `Features` field of the `Processor` class. As for generating `MArch` out of the `Features` field, @crai

[PATCH] D140434: readability-const-return-type: don't diagnose a template function returning T, even if sometimes instantiated with e.g. T = const int.

suertreus created this revision. suertreus added a reviewer: ymandel. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. suertreus requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-comm

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4009014 , @paulkirth wrote: > Hi, thanks for the fix. that unblocked our builder. Unfortunately, we still > see some errors in tests. > > FAIL: Clang :: Driver/aarch64-features.c (7460 of 16622) > **

[clang] bf94eac - [AArch64][NFC] Fix aarch64 target features test.

Author: Pavel Iliin Date: 2022-12-20T22:29:16Z New Revision: bf94eac6a3f7c5cd8941956d44c15524fa3751bd URL: https://github.com/llvm/llvm-project/commit/bf94eac6a3f7c5cd8941956d44c15524fa3751bd DIFF: https://github.com/llvm/llvm-project/commit/bf94eac6a3f7c5cd8941956d44c15524fa3751bd.diff LOG: [

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1218 +auto GlobalIndex = P.getGlobal(VD); +assert(GlobalIndex); // visitVarDecl() didn't return false. +if (!this->emitGetPtrGlobal(*GlobalIndex, VD)) --

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, jdoerfert, tianshilei1992, MaskRay. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, StephenFan, tpr. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscri

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484380. fpetrogalli marked 8 inline comments as done. fpetrogalli added a comment. 1. I have split the RISCV bits of the target parser out of TargetParser.cpp so that none of the non-RISCV components need to include the folder with the autogenerated .inc

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

mingmingl updated this revision to Diff 484373. mingmingl added a comment. indent intrinsic definition in arm_neon.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140432/new/ https://reviews.llvm.org/D140432 Files: clang/include/clang/Basic/arm

[PATCH] D140432: [AArch64] Guard {vmull_p64, vmull_high_p64} with 'aes' target guard.

mingmingl created this revision. mingmingl added a reviewer: dmgreen. Herald added a subscriber: kristof.beyls. Herald added a project: All. mingmingl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In this way, cpp code that uses these int

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

paulkirth added a comment. Hi, thanks for the fix. that unblocked our builder. Unfortunately, we still see some errors in tests. FAIL: Clang :: Driver/aarch64-features.c (7460 of 16622) TEST 'Clang :: Driver/aarch64-features.c' FAILED Script: --

[PATCH] D140430: [clang][dataflow] Fix bug in handling of `return` statements.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. The handling of return statements, added

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

jansvoboda11 added inline comments. Herald added a project: All. Comment at: clang/lib/Lex/PPDirectives.cpp:115 // vends a module map, one might want to avoid hitting intermediate build -// products containing the the module map or avoid finding the system installed +// products

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

steven_wu added a comment. In D139938#4008232 , @hans wrote: > This seems to have broken the instrprof-darwin-exports.c test, see e.g. > https://green.lab.llvm.org/green/job/clang-stage1-RA/32351/ > > I'll revert for now. It seems you still need to clai

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the expression is Hazardy

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the expression is The com

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4008605 , @lenary wrote: > I'm working on a follow-up, which should make the split a bit clearer, but > I'm also not a modulemap expert and the `-DLLVM_ENABLE_MODULES=On` > configuration is broken on my linux dev box.

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) fpetrogalli wrote: > craig.topper wrote: > > fpetrogalli wrote: > > > lena

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:254 +def warn_for_global_ctor_for_dllimport : Warning< + "global constructor is generated for dllimport global var %0">, Missing code to emit this warning? ===

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

shafik added a comment. This looks good to me but I see at least one concern that Aaron had that he did not get back on, so I will wait for him to approve. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:835 IsTemporary = true; Ty = E->getType(); } --

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

ilinpv added a comment. In D127812#4008451 , @paulkirth wrote: > Hi, we're seeing a build failure in Fuchsia's Clang CI. We're seeing this on > all of our builders: arm64 & x64 linux, mac and windows > > FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir

[PATCH] D140195: [Clang][CGDebugInfo][ObjC] Mark objc bitfields with the DIFlagBitfield flag

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. > Unluckly, I wasn't able to test the combination of > https://reviews.llvm.org/D96334 and this patch together. If you have some > pointers about how to trigger a test job on "Green Dragon",

[PATCH] D139973: [llvm] Make llvm::Any similar to std::any

jloser added a comment. Sorry for the delay here; this patch LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139973/new/ https://reviews.llvm.org/D139973 ___ cfe-commits mailing list cfe-com

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) craig.topper wrote: > fpetrogalli wrote: > > lenary wrote: > > > crai

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) fpetrogalli wrote: > lenary wrote: > > craig.topper wrote: > > > Why

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli added a comment. Hi - gentle ping on reviewing this Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) lenary wrote: > craig.topper wrote: >

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

lenary added a comment. One comment on the build changes, I don't have opinions on the RISC-V changes. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/)

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. I'm working on a follow-up, which should make the split a bit clearer, but I'm also not a modulemap expert and the `-DLLVM_ENABLE_MODULES=On` configuration is broken on my linux dev box. I'll post it for review if those two patches have at least made the build greener.

[PATCH] D139737: [-Wunsafe-buffer-usage] Initiate Fix-it generation for local variable declarations

jkorous added a comment. Thanks for the rebase! Nit: I'd just replace `std::function` with `auto` as it saves us repeating the parameter types (and `#include `). Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:617 + // Printers that print extent into OS and sets ExtKnow

[PATCH] D137838: [Support] Move TargetParsers to new component

steven_wu added a comment. Also needed a follow up fix to completely fix module `9cd6fbee7ed8` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___ cfe-commits m

[clang] 9cd6fbe - Fix module build after TargetParser

Author: Steven Wu Date: 2022-12-20T10:31:19-08:00 New Revision: 9cd6fbee7ed881f8e80b735e95567040e56f189e URL: https://github.com/llvm/llvm-project/commit/9cd6fbee7ed881f8e80b735e95567040e56f189e DIFF: https://github.com/llvm/llvm-project/commit/9cd6fbee7ed881f8e80b735e95567040e56f189e.diff LOG

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe9babe757160: [OpenMP] Clang Support for taskwait nowait clause (authored by koops, committed by cchen). Repository: rG LLVM Github Monorepo CHAN

[clang] e9babe7 - [OpenMP] Clang Support for taskwait nowait clause

Author: Sunil Kuravinakop Date: 2022-12-20T12:13:56-06:00 New Revision: e9babe7571609c9de41d4d0dfc1bc4d2f02021d0 URL: https://github.com/llvm/llvm-project/commit/e9babe7571609c9de41d4d0dfc1bc4d2f02021d0 DIFF: https://github.com/llvm/llvm-project/commit/e9babe7571609c9de41d4d0dfc1bc4d2f02021d0.d

[clang] 2cf550a - Add missing textual header to module map

Author: Adrian Prantl Date: 2022-12-20T10:05:55-08:00 New Revision: 2cf550a80a0177f8a1aa9ae45c40b0d17ef7f11d URL: https://github.com/llvm/llvm-project/commit/2cf550a80a0177f8a1aa9ae45c40b0d17ef7f11d DIFF: https://github.com/llvm/llvm-project/commit/2cf550a80a0177f8a1aa9ae45c40b0d17ef7f11d.diff

[PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. Sorry, I pasted in the wrong hash: 6bdf378dcd349d97152846bb687c1d1de511d138 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.ll

[PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. I think I fixed it in a685bb8e333e , but please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D1

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4008443 , @aprantl wrote: > Can you please update `llvm/include/llvm/module.modulemap` for this change or > revert the patch? This is breaking all bots that build with > `-DLLVM_ENABLE_MODULES=On`. > > For example: >

[PATCH] D127812: [AArch64] FMV support and necessary target features dependencies.

paulkirth added a comment. Hi, we're seeing a build failure in Fuchsia's Clang CI. We're seeing this on all of our builders: arm64 & x64 linux, mac and windows FAILED: CMakeFiles/clang_rt.builtins-aarch64.dir/cpu_model.c.o /b/s/w/ir/x/w/recipe_cleanup/cxx-rbevgw5lbzc/reclient-cxx-wrapper.sh

[PATCH] D137838: [Support] Move TargetParsers to new component

aprantl added a comment. Can you please update `llvm/include/llvm/module.modulemap` for this change or revert the patch? This is breaking all bots that build with `-DLLVM_ENABLE_MODULES=On`. For example: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/lastFailedBuild/consoleFull#1110

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

ABataev accepted this revision. ABataev added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131830/new/ https://reviews.llvm.org/D131830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added inline comments. Comment at: llvm/lib/Target/AArch64/AsmParser/CMakeLists.txt:19 +target_include_directories(LLVMAArch64AsmParser PRIVATE ${LLVM_LIBRARY_DIR}/TargetParser/) Why do we need to touch CMake file that aren't RISC-V? ===

[PATCH] D135360: [clang][analyzer] Add some more functions to StreamChecker and StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1818-1857 +// int fgetpos(FILE *restrict stream, fpos_t *restrict pos); +// From 'The Open Group Base Specifications Issue 7, 2018 edition': +// "The fgetpos(

[clang] 49dd02b - Revert "[clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin"

Author: Hans Wennborg Date: 2022-12-20T17:45:07+01:00 New Revision: 49dd02bd081901db6011bdbe676573bfd5482627 URL: https://github.com/llvm/llvm-project/commit/49dd02bd081901db6011bdbe676573bfd5482627 DIFF: https://github.com/llvm/llvm-project/commit/49dd02bd081901db6011bdbe676573bfd5482627.diff

[PATCH] D139938: [clang] Don't spuriously pass -stdlib=libc++ to CC1 on Darwin

hans added a comment. This seems to have broken the instrprof-darwin-exports.c test, see e.g. https://green.lab.llvm.org/green/job/clang-stage1-RA/32351/ I'll revert for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139938/new/ https://revie

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

koops updated this revision to Diff 484290. koops added a comment. Taking care of : 1. "The nowait clause may only appear on a taskwait directive if the depend clause is present.". 2. "Please do not add any new tests using -no-opaque-pointers". 3. Added a new test to expect failure for point 1.

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

Mordante added a comment. In D139986#4005997 , @dblaikie wrote: > In D139986#4003873 , @Mordante > wrote: > >> In D139986#4001180 , @Michael137 >> wrote: >> >>> Missed c

[PATCH] D137516: [TargetSupport] Move TargetParser API in a separate LLVM component.

fpetrogalli abandoned this revision. fpetrogalli added a comment. Replaced by D137838 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137516/new/ https://reviews.llvm.org/D137516 ___

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 484283. fpetrogalli added a comment. Herald added a subscriber: pengfei. This update is not based anymore on D137516 , but uses the refactoring of `TargetParser` as part of `LLVMSupport` into the new component `LLVMTarge

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary marked 3 inline comments as done. lenary added a comment. Nits addressed. Will land in the new year, when I'm back at work. Right now it's time for a break! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary edited the summary of this revision. lenary updated this revision to Diff 484281. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140222/new/ https://reviews.llvm.org/D140222 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/He

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/test/CodeGenCXX/PR19955.cpp:20 +// CHECK-64: store ptr @"?var@@3HA", ptr @"?varp@@3PEAHEA" +// CHECK: ret void @rnk was concerned about varp pointing to dllimport var. That does it I think. CHANGES SINCE LAS

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484278. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D140387: [clang][analyzer] Add stream related functions to StdLibraryFunctionsChecker.

Szelethus added a comment. In D140387#4007751 , @balazske wrote: > This patch and D140395 is (almost) the > same code as D135360 and D135247 > . The

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. In D137838#4007920 , @thakis wrote: > Thanks for the heads-up. I updated the GN build in > 4ac51dd53d93b8dd18c58093766483c657fe3a08 > and > 2aa998d22fe09191cd

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" barannikov88 wrote: > The prefix must remai

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

barannikov88 added inline comments. Comment at: bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.in:17 -#define LLVM_LIBDIR_SUFFIX "@LLVM_LIBDIR_SUFFIX@" +#define CMAKE_INSTALL_LIBDIR "@CMAKE_INSTALL_LIBDIR@" The prefix must remain LLVM_* In other comp

[PATCH] D137838: [Support] Move TargetParsers to new component

thakis added a comment. Thanks for the heads-up. I updated the GN build in 4ac51dd53d93b8dd18c58093766483c657fe3a08 and 2aa998d22fe09191cd6c1b697e373266c1131502

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { Do you agree this should be done only when one of those flags is on? CHANGES SI

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484258. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5009 + if (isStaticInit(D, getLangOpts()) && NeedsGlobalCtor && NeedsGlobalDtor) { +EmitCXXCtorInit(D, GV, true, 201, llvm::StringLiteral("ctor"), false

  1   2   >